From: Keith Packard <keithp@keithp.com>
To: intel-gfx@lists.freedesktop.org
Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 4/7] drm/i915: Let panel power sequencing hardware do its job
Date: Wed, 02 Nov 2011 00:31:40 -0700 [thread overview]
Message-ID: <yunwrbjvv37.fsf@aiko.keithp.com> (raw)
In-Reply-To: <1320214830-12696-5-git-send-email-keithp@keithp.com>
[-- Attachment #1: Type: text/plain, Size: 914 bytes --]
On Tue, 1 Nov 2011 23:20:27 -0700, Keith Packard <keithp@keithp.com> wrote:
> -static void ironlake_wait_panel_off(struct intel_dp *intel_dp)
> +#define IDLE_ON_MASK (PP_ON | PP_READY | PP_SEQUENCE_MASK | 0 | PP_SEQUENCE_STATE_MASK)
> +#define IDLE_ON_VALUE (PP_ON | PP_READY | PP_SEQUENCE_NONE | 0 | PP_SEQUENCE_STATE_ON_IDLE)
A bit more testing -- looks like the MacBook Air doesn't mange to get
PP_READY set when it's time to turn the panel on. I should look at this
a bit more closely; there's no reason it shouldn't be set. But, nothing
bad seems to happen if we simply ignore the PP_READY bit
+#define IDLE_ON_MASK (PP_ON | 0 | PP_SEQUENCE_MASK | 0 | PP_SEQUENCE_STATE_MASK)
+#define IDLE_ON_VALUE (PP_ON | 0 | PP_SEQUENCE_NONE | 0 | PP_SEQUENCE_STATE_ON_IDLE)
--
keith.packard@intel.com
[-- Attachment #2: Type: application/pgp-signature, Size: 827 bytes --]
next prev parent reply other threads:[~2011-11-02 7:31 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-02 6:20 [PATCH 0/7] drm/i915: Fix PCH eDP support for SNB Keith Packard
2011-11-02 6:20 ` [PATCH 1/7] drm/i915: Move common PCH_PP_CONTROL setup to ironlake_get_pp_control Keith Packard
2011-11-02 16:02 ` [Intel-gfx] " Jesse Barnes
2011-11-02 16:13 ` Keith Packard
2011-11-02 16:13 ` Keith Packard
2011-11-02 6:20 ` [PATCH 2/7] drm/i915: Remove link_status field from intel_dp structure Keith Packard
2011-11-02 16:13 ` [Intel-gfx] " Jesse Barnes
2011-11-02 6:20 ` [PATCH 3/7] drm/i915: Treat PCH eDP like DP in most places Keith Packard
2011-11-02 15:29 ` [Intel-gfx] " Adam Jackson
2011-11-02 16:55 ` Keith Packard
2011-11-02 16:55 ` Keith Packard
2011-11-02 17:35 ` Keith Packard
2011-11-02 16:20 ` Jesse Barnes
2011-11-02 17:10 ` Keith Packard
2011-11-02 17:13 ` Adam Jackson
2011-11-02 17:13 ` Adam Jackson
2011-11-02 17:31 ` [Intel-gfx] " Keith Packard
2011-11-02 17:31 ` Keith Packard
2011-11-02 19:36 ` [Intel-gfx] " Adam Jackson
2011-11-02 20:05 ` Keith Packard
2011-11-02 20:35 ` Adam Jackson
2011-11-02 21:13 ` Keith Packard
2011-11-02 21:16 ` Adam Jackson
2011-11-02 18:54 ` Keith Packard
2011-11-02 18:54 ` Keith Packard
2011-11-02 19:07 ` Alex Deucher
2011-11-02 6:20 ` [PATCH 4/7] drm/i915: Let panel power sequencing hardware do its job Keith Packard
2011-11-02 7:31 ` Keith Packard [this message]
2011-11-02 16:23 ` [Intel-gfx] " Jesse Barnes
2011-11-02 17:14 ` Keith Packard
2011-11-02 17:37 ` Keith Packard
2011-11-03 19:57 ` Jesse Barnes
2011-11-03 22:01 ` Keith Packard
2011-11-02 6:20 ` [PATCH 5/7] drm/i915: Make DP prepare/commit consistent with DP dpms Keith Packard
2011-11-03 20:00 ` [Intel-gfx] " Jesse Barnes
2011-11-03 20:00 ` Jesse Barnes
2011-11-03 22:30 ` [Intel-gfx] " Keith Packard
2011-11-03 22:41 ` Jesse Barnes
2011-11-03 22:59 ` Keith Packard
2011-11-02 6:20 ` [PATCH 6/7] drm/i915: Try harder during dp pattern 1 link training Keith Packard
2011-11-02 9:12 ` Chris Wilson
2011-11-02 9:12 ` Chris Wilson
2011-11-02 17:20 ` Keith Packard
2011-11-02 17:38 ` Keith Packard
2011-11-03 20:03 ` [Intel-gfx] " Jesse Barnes
2011-11-03 22:32 ` Keith Packard
2011-11-02 6:20 ` [PATCH 7/7] drm/i915: Remove trailing white space Keith Packard
2011-11-03 20:03 ` [Intel-gfx] " Jesse Barnes
2011-11-03 22:36 ` Keith Packard
2011-11-03 22:48 ` Keith Packard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yunwrbjvv37.fsf@aiko.keithp.com \
--to=keithp@keithp.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.