From: Keith Packard <keithp@keithp.com>
To: Jesse Barnes <jbarnes@virtuousgeek.org>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 6/8] drm/i915/dp: clear DP encoder CRTC if the receiver disappears
Date: Fri, 01 Jul 2011 16:48:27 -0700 [thread overview]
Message-ID: <yuny60hef5g.fsf@aiko.keithp.com> (raw)
In-Reply-To: <1309558978-4704-7-git-send-email-jbarnes@virtuousgeek.org>
[-- Attachment #1.1: Type: text/plain, Size: 528 bytes --]
On Fri, 1 Jul 2011 15:22:56 -0700, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> If the receiver goes away, drop any associated CRTC. This will force a
> full mode set on any subsequent setcrtc call, which is what we need if
> the receiver is gone and the link is down.
This doesn't look like a good solution to me -- we're smashing the
connection between the DP output and the selected CRTC. If you plug the
cable back in, won't this mess things up when we try to retrain again?
--
keith.packard@intel.com
[-- Attachment #1.2: Type: application/pgp-signature, Size: 189 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2011-07-01 23:48 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-01 22:22 [RFC] misc DP fixes/changes Jesse Barnes
2011-07-01 22:22 ` [PATCH 1/8] drm/i915/dp: retry link status read 3 times on failure Jesse Barnes
2011-07-01 23:41 ` Keith Packard
2011-07-01 23:47 ` Jesse Barnes
2011-07-06 4:27 ` Eric Anholt
2011-07-06 16:09 ` Jesse Barnes
2011-07-01 22:22 ` [PATCH 2/8] drm/i915/dp: use DP DPCD defines when looking at DPCD values Jesse Barnes
2011-07-01 23:43 ` Keith Packard
2011-07-01 22:22 ` [PATCH 3/8] drm/i915/dp: read more receiver capability bits on hotplug Jesse Barnes
2011-07-01 23:45 ` Keith Packard
2011-07-01 22:22 ` [PATCH 4/8] drm/i915/dp: try to read receiver capabilities 3 times when detecting Jesse Barnes
2011-07-01 23:45 ` Keith Packard
2011-07-01 22:22 ` [PATCH 5/8] drm/i915/dp: set DP DPMS mode to "on" in ->commit Jesse Barnes
2011-07-01 23:46 ` Keith Packard
2011-07-01 22:22 ` [PATCH 6/8] drm/i915/dp: clear DP encoder CRTC if the receiver disappears Jesse Barnes
2011-07-01 23:48 ` Keith Packard [this message]
2011-07-01 23:59 ` Jesse Barnes
2011-07-02 0:31 ` Keith Packard
2011-07-01 22:22 ` [PATCH 7/8] drm/i915/dp: rename dpms_mode to receiver_configured Jesse Barnes
2011-07-01 23:50 ` Keith Packard
2011-07-01 22:22 ` [PATCH 8/8] drm/i915/dp: clear receiver_configured when link training fails Jesse Barnes
2011-07-01 23:51 ` Keith Packard
2011-07-01 23:39 ` [RFC] misc DP fixes/changes Keith Packard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yuny60hef5g.fsf@aiko.keithp.com \
--to=keithp@keithp.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jbarnes@virtuousgeek.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.