From: Keith Packard <keithp@keithp.com>
To: Jesse Barnes <jbarnes@virtuousgeek.org>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: move IRQ function table init to i915_irq.c
Date: Tue, 28 Jun 2011 13:52:00 -0700 [thread overview]
Message-ID: <yuny60lfzm7.fsf@aiko.keithp.com> (raw)
In-Reply-To: <1309291241-3545-1-git-send-email-jbarnes@virtuousgeek.org>
[-- Attachment #1.1: Type: text/plain, Size: 545 bytes --]
On Tue, 28 Jun 2011 13:00:41 -0700, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> This lets us make the various IRQ functions static and helps avoid
> problems like the one fixed in "drm/i915: Use chipset-specific irq
> installers" where one of the exported functions was called rather than
> the chipset specific version.
This also looks like it fixes a fairly serious UMS-mode bug -- the
correct irq functions were only getting loaded in the KMS path, right?
As such, it's a candidate for 3.0.
--
keith.packard@intel.com
[-- Attachment #1.2: Type: application/pgp-signature, Size: 189 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2011-06-28 20:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-28 20:00 [PATCH] drm/i915: move IRQ function table init to i915_irq.c Jesse Barnes
2011-06-28 20:24 ` Ben Widawsky
2011-06-28 20:52 ` Keith Packard [this message]
2011-06-28 21:00 ` Jesse Barnes
2011-06-28 21:16 ` Keith Packard
2011-06-30 3:43 ` Keith Packard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yuny60lfzm7.fsf@aiko.keithp.com \
--to=keithp@keithp.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jbarnes@virtuousgeek.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.