All of lore.kernel.org
 help / color / mirror / Atom feed
From: Keith Packard <keithp@keithp.com>
To: Eric Anholt <eric@anholt.net>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] intel: Stop using sized buckets for the BO cache.
Date: Mon, 07 Jun 2010 00:14:00 -0700	[thread overview]
Message-ID: <yuny6erfh6v.fsf@aiko.keithp.com> (raw)
In-Reply-To: <1275893579-20155-1-git-send-email-eric@anholt.net>


[-- Attachment #1.1: Type: text/plain, Size: 608 bytes --]

On Sun,  6 Jun 2010 23:52:59 -0700, Eric Anholt <eric@anholt.net> wrote:
> Theory being that we don't keep *that* many buffers around, and the
> pain of trying to find the right size in the list is less than the
> pain of using gratuitous amounts of system memory for our BOs.

And, if you sorted the list in size order, you could locate a matching
object in log instead of linear time, eliminating most of the potential
performance impact. Either a RB tree or a skip list might make sense
here; I'd probably use a skip list as those are easier to understand though.

-- 
keith.packard@intel.com

[-- Attachment #1.2: Type: application/pgp-signature, Size: 189 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2010-06-07  7:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-07  6:52 [PATCH] intel: Stop using sized buckets for the BO cache Eric Anholt
2010-06-07  7:14 ` Keith Packard [this message]
2010-06-07 13:15 ` Chris Wilson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yuny6erfh6v.fsf@aiko.keithp.com \
    --to=keithp@keithp.com \
    --cc=eric@anholt.net \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.