From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: USB: serial: option: set driver_info for SIM5218 and compatibles From: =?utf-8?b?TcOlbnMgUnVsbGfDpXJk?= Message-Id: Date: Tue, 19 Mar 2019 12:25:53 +0000 To: Johan Hovold Cc: =?iso-8859-1?Q?Bj=F8rn?= Mork , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org List-ID: Sm9oYW4gSG92b2xkIDxqb2hhbkBrZXJuZWwub3JnPiB3cml0ZXM6Cgo+IE9uIFR1ZSwgTWFyIDE5 LCAyMDE5IGF0IDEwOjU0OjAwQU0gKzAwMDAsIE3DpW5zIFJ1bGxnw6VyZCB3cm90ZToKPj4gSm9o YW4gSG92b2xkIDxqb2hhbkBrZXJuZWwub3JnPiB3cml0ZXM6Cj4KPj4gPj4gUmVnYXJkbGVzcywg c2V0dGluZyB0aGUgTkNUUkwgZmxhZyBzaG91bGQgYmUgaGFybWxlc3MuCj4+ID4KPj4gPiBXZWxs LCB0aGVyZSBhcmUgZGV2aWNlcyB0aGF0IGRlcGVuZCBvbiBnZXR0aW5nIHRoZXNlIHJlcXVlc3Rz LCBhdCBsZWFzdAo+PiA+IGZvciB0aGUgUU1JIGludGVyZmFjZS4gQnV0IHdlIGNhbiBhbHdheXMg cmV2ZXJ0IGlmIGFueW9uZSBjb21wbGFpbnMuCj4+IAo+PiBUaGUgUU1JIGludGVyZmFjZSBkb2Vz bid0IGV2ZW4gcHJldGVuZCB0byBiZSBhIHVhcnQuICBUaGUgb3RoZXIgb25lcyBkbywKPj4gYnV0 IHRoZXJlIGlzbid0IGFjdHVhbGx5IGFueSByZWFsIHVhcnQgYmVoaW5kIHRoZW0uICBGb3IgaW5z dGFuY2UsIGl0Cj4+IGRvZXNuJ3QgbWF0dGVyIHdoYXQgYmF1ZCByYXRlIG9uZSBzZXRzLgo+Cj4g U3VyZSwgYnV0IHNvbWUgZGV2aWNlcyBzdGlsbCByZXF1aXJlICJEVFIiIHRvIGJlIHNldCBmb3Ig dGhlIFFNSQo+IGludGVyZmFjZSwgc28gdGhlcmUgbm90IGJlaW5nIGFueSByZWFsIHVhcnQgaXMg bm8gZ3VhcmFudGVlIHRoYXQgdGhlcmUKPiBpcyBubyBmaXJtd2FyZSB0aGF0IGV4cGVjdHMgdGhl c2UgY2FsbHMuCgpOb3cgSSdtIHRob3JvdWdobHkgY29uZnVzZWQuICBUaGUgUU1JIGludGVyZmFj ZSBoYXMgYSBjb21wbGV0ZWx5CnNlcGFyYXRlIGRyaXZlciB0aGF0IGNyZWF0ZXMgYSBuZXR3b3Jr IGRldmljZSAoaWYgSSdtIHJlYWRpbmcgdGhlIGNvZGUKY29ycmVjdGx5KS4K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4349AC43381 for ; Tue, 19 Mar 2019 12:25:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 06D77213F2 for ; Tue, 19 Mar 2019 12:25:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727535AbfCSMZz convert rfc822-to-8bit (ORCPT ); Tue, 19 Mar 2019 08:25:55 -0400 Received: from unicorn.mansr.com ([81.2.72.234]:38040 "EHLO unicorn.mansr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726876AbfCSMZz (ORCPT ); Tue, 19 Mar 2019 08:25:55 -0400 Received: by unicorn.mansr.com (Postfix, from userid 51770) id 4966F14CEB; Tue, 19 Mar 2019 12:25:53 +0000 (GMT) From: =?iso-8859-1?Q?M=E5ns_Rullg=E5rd?= To: Johan Hovold Cc: =?iso-8859-1?Q?Bj=F8rn?= Mork , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] USB: serial: option: set driver_info for SIM5218 and compatibles References: <20190226170710.12709-1-mans@mansr.com> <20190227083342.GJ4747@localhost> <20190227131315.GO4747@localhost> <20190319102840.GI6124@localhost> <20190319110819.GB3178@localhost> Date: Tue, 19 Mar 2019 12:25:53 +0000 In-Reply-To: <20190319110819.GB3178@localhost> (Johan Hovold's message of "Tue, 19 Mar 2019 12:08:19 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Johan Hovold writes: > On Tue, Mar 19, 2019 at 10:54:00AM +0000, Måns Rullgård wrote: >> Johan Hovold writes: > >> >> Regardless, setting the NCTRL flag should be harmless. >> > >> > Well, there are devices that depend on getting these requests, at least >> > for the QMI interface. But we can always revert if anyone complains. >> >> The QMI interface doesn't even pretend to be a uart. The other ones do, >> but there isn't actually any real uart behind them. For instance, it >> doesn't matter what baud rate one sets. > > Sure, but some devices still require "DTR" to be set for the QMI > interface, so there not being any real uart is no guarantee that there > is no firmware that expects these calls. Now I'm thoroughly confused. The QMI interface has a completely separate driver that creates a network device (if I'm reading the code correctly). -- Måns Rullgård