From: "Måns Rullgård" <mans@mansr.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 2/2] arm: Make arch specific memcpy thumb-safe.
Date: Sat, 21 Apr 2018 14:24:02 +0100 [thread overview]
Message-ID: <yw1xbmecelql.fsf@mansr.com> (raw)
In-Reply-To: <20180420195144.32900-3-klaus.goger@theobroma-systems.com> (Klaus Goger's message of "Fri, 20 Apr 2018 21:51:44 +0200")
Klaus Goger <klaus.goger@theobroma-systems.com> writes:
> The current arch implementation of memcpy cannot be called
> from thumb code, because it does not use bx instructions on return.
> This patch addresses that. Note, that this patch does not touch
> the hot loop of memcpy, so performance is not affected.
>
> Tested on MXS (arm926ejs) with and without thumb-mode enabled.
>
> Signed-off-by: Klaus Goger <klaus.goger@theobroma-systems.com>
> Signed-off-by: Christoph Muellner <christoph.muellner@theobroma-systems.com>
There are many more instances of mov to pc that ought to be fixed too.
Why not do them all at once rather than picking them off one by one as
they happen to break things?
--
Måns Rullgård
next prev parent reply other threads:[~2018-04-21 13:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-20 19:51 [U-Boot] [PATCH v2 0/2] While trying to compile u-boot in thumb due space constraints on a mxs Klaus Goger
2018-04-20 19:51 ` [U-Boot] [PATCH v2 1/2] arm: make arm926ejs startup code thumb compatible Klaus Goger
2018-04-20 21:55 ` Marek Vasut
2018-04-20 22:11 ` klaus.goger at theobroma-systems.com
2018-04-21 13:10 ` Måns Rullgård
2018-04-21 16:45 ` Christoph Müllner
2018-04-20 19:51 ` [U-Boot] [PATCH v2 2/2] arm: Make arch specific memcpy thumb-safe Klaus Goger
2018-04-21 13:24 ` Måns Rullgård [this message]
2018-04-21 16:45 ` Christoph Müllner
2018-04-21 17:00 ` Måns Rullgård
2018-04-21 17:21 ` Christoph Müllner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yw1xbmecelql.fsf@mansr.com \
--to=mans@mansr.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.