From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: USB: serial: option: set driver_info for SIM5218 and compatibles From: =?utf-8?b?TcOlbnMgUnVsbGfDpXJk?= Message-Id: Date: Tue, 19 Mar 2019 10:54:00 +0000 To: Johan Hovold Cc: =?iso-8859-1?Q?Bj=F8rn?= Mork , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org List-ID: Sm9oYW4gSG92b2xkIDxqb2hhbkBrZXJuZWwub3JnPiB3cml0ZXM6Cgo+IE9uIFdlZCwgRmViIDI3 LCAyMDE5IGF0IDAyOjMyOjU4UE0gKzAwMDAsIE3DpW5zIFJ1bGxnw6VyZCB3cm90ZToKPj4gSm9o YW4gSG92b2xkIDxqb2hhbkBrZXJuZWwub3JnPiB3cml0ZXM6Cj4+IAo+PiA+IEFkZGluZyBCasO4 cm4uCj4+ID4KPj4gPiBPbiBXZWQsIEZlYiAyNywgMjAxOSBhdCAxMTo1NzoxNkFNICswMDAwLCBN w6VucyBSdWxsZ8OlcmQgd3JvdGU6Cj4+ID4+IEpvaGFuIEhvdm9sZCA8am9oYW5Aa2VybmVsLm9y Zz4gd3JpdGVzOgo+PiA+PiAKPj4gPj4gPiBPbiBUdWUsIEZlYiAyNiwgMjAxOSBhdCAwNTowNzox MFBNICswMDAwLCBNYW5zIFJ1bGxnYXJkIHdyb3RlOgo+PiA+PiA+PiBUaGUgU0lNQ29tIFNJTTUy MTggYW5kIGNvbXBhdGlibGUgZGV2aWNlcyBoYXZlIDUgVVNCIGludGVyZmFjZXMsIG9ubHkgNAo+ PiA+PiA+PiBvZiB3aGljaCBhcmUgc2VyaWFsIHBvcnRzLiAgVGhlIGZpZnRoIGlzIGEgbmV0d29y ayBpbnRlcmZhY2Ugc3VwcG9ydGVkCj4+ID4+ID4+IGJ5IHRoZSBxbWktd3dhbiBkcml2ZXIuICBG dXJ0aGVybW9yZSwgdGhlIHNlcmlhbCBwb3J0cyBkbyBub3Qgc3VwcG9ydAo+PiA+PiA+PiBtb2Rl bSBjb250cm9sIHNpZ25hbHMuICBBZGQgZHJpdmVyX2luZm8gZmxhZ3MgdG8gcmVmbGVjdCB0aGlz Lgo+PiA+PiA+PiAKPj4gPj4gPj4gU2lnbmVkLW9mZi1ieTogTWFucyBSdWxsZ2FyZCA8bWFuc0Bt YW5zci5jb20+Cj4+ID4+ID4+IC0tLQo+PiA+PiA+PiAgZHJpdmVycy91c2Ivc2VyaWFsL29wdGlv bi5jIHwgMyArKy0KPj4gPj4gPj4gIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDEg ZGVsZXRpb24oLSkKPj4gPj4gPj4gCj4+ID4+ID4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3VzYi9z ZXJpYWwvb3B0aW9uLmMgYi9kcml2ZXJzL3VzYi9zZXJpYWwvb3B0aW9uLmMKPj4gPj4gPj4gaW5k ZXggZmI1NDQzNDA4ODhiLi5hZjRjYmZlY2MzZmYgMTAwNjQ0Cj4+ID4+ID4+IC0tLSBhL2RyaXZl cnMvdXNiL3NlcmlhbC9vcHRpb24uYwo+PiA+PiA+PiArKysgYi9kcml2ZXJzL3VzYi9zZXJpYWwv b3B0aW9uLmMKPj4gPj4gPj4gQEAgLTEwNjYsNyArMTA2Niw4IEBAIHN0YXRpYyBjb25zdCBzdHJ1 Y3QgdXNiX2RldmljZV9pZCBvcHRpb25faWRzW10gPSB7Cj4+ID4+ID4+ICAJICAuZHJpdmVyX2lu Zm8gPSBSU1ZEKDMpIH0sCj4+ID4+ID4+ICAJeyBVU0JfREVWSUNFKFFVQUxDT01NX1ZFTkRPUl9J RCwgMHg2NjEzKX0sIC8qIE9uZGEgSDYwMC9aVEUgTUYzMzAgKi8KPj4gPj4gPj4gIAl7IFVTQl9E RVZJQ0UoUVVBTENPTU1fVkVORE9SX0lELCAweDAwMjMpfSwgLyogT05ZWCAzRyBkZXZpY2UgKi8K Pj4gPj4gPj4gLQl7IFVTQl9ERVZJQ0UoUVVBTENPTU1fVkVORE9SX0lELCAweDkwMDApfSwgLyog U0lNQ29tIFNJTTUyMTggKi8KPj4gPj4gPj4gKwl7IFVTQl9ERVZJQ0UoUVVBTENPTU1fVkVORE9S X0lELCAweDkwMDApLCAvKiBTSU1Db20gU0lNNTIxOCAqLwo+PiA+PiA+PiArCSAgLmRyaXZlcl9p bmZvID0gTkNUUkwoMCkgfCBOQ1RSTCgxKSB8IE5DVFJMKDIpIHwgTkNUUkwoMykgfCBSU1ZEKDQp IH0sCj4+ID4+ID4+ICAJLyogUXVlY3RlbCBwcm9kdWN0cyB1c2luZyBRdWFsY29tbSB2ZW5kb3Ig SUQgKi8KPj4gPj4gPj4gIAl7IFVTQl9ERVZJQ0UoUVVBTENPTU1fVkVORE9SX0lELCBRVUVDVEVM X1BST0RVQ1RfVUMxNSl9LAo+PiA+PiA+PiAgCXsgVVNCX0RFVklDRShRVUFMQ09NTV9WRU5ET1Jf SUQsIFFVRUNURUxfUFJPRFVDVF9VQzIwKSwKPj4gPj4gPgo+PiA+PiA+IENvdWxkIHlvdSBwbGVh c2UgcHJvdmlkZSB0aGUgb3V0cHV0IG9mIHVzYi1kZXZpY2VzIChvciBsc3VzYiAtdikgZm9yCj4+ ID4+ID4gdGhpcyBkZXZpY2U/Cj4+ID4+IAo+PiA+PiBsc3VzYiAtdjoKPj4gPj4gWy4uLl0KPj4g Cj4+ID4gU28gdGhlIHBhdGNoIGxvb2tzIGZpbmUgdG8gbWUuIFRoZSBmaWZ0aCBpbnRlcmZhY2Ug aXMgUU1JLCBidXQgaGFzbid0Cj4+ID4gYmVlbiBhdmFpbGFibGUgZm9yIHVzZSB1bnRpbCBub3cg dGhlbiwgYW5kIHRoaXMgc2VlbXMgdG8gaGF2ZSBiZWVuIHRoZQo+PiA+IHZlbmRvcnMgaWRlYSBm cm9tIHRoZSBzdGFydDoKPj4gPgo+PiA+IAlodHRwOi8vd3d3Lm1pY3JvY2hpcC51YS9zaW1jb20v V0NETUEvQVBQTk9URVMvU0lNQ29tXzNHX0xpbnV4X2RyaXZlcl9BcHBsaWNhdGlvbiUyME5vdGVf VjEuMDAucGRmCj4+IAo+PiBUaGF0IGRvY3VtZW50IHByZWRhdGVzIHRoZSBxbWktd3dhbiBkcml2 ZXIgaW4gdGhlIGtlcm5lbC4gIE5vdGUgdGhhdAo+PiB0aGlzIGRyaXZlciBoYXMgYW4gSUQgdGFi bGUgZW50cnkgZm9yIGludGVyZmFjZSA0IG9mIHRoaXMgZGV2aWNlLiAgUmlnaHQKPj4gbm93LCB3 aGljaGV2ZXIgZHJpdmVyIGlzIHByb2JlZCBmaXJzdCBjbGFpbXMgdGhhdCBpbnRlcmZhY2UuICBJ IGhhdmVuJ3QKPj4gYWN0dWFsbHkgdHJpZWQgdXNpbmcgdGhlIFFNSSBpbnRlcmZhY2UsIHRob3Vn aC4KPgo+IEkgZGlkbid0IHNheSBpdCB3YXMgY29ycmVjdCwganVzdCB0aGF0IHRoZSB2ZW5kb3Ig cHJvcG9zZWQgYmluZGluZyB0byBpdAo+IGFueXdheS4KPgo+PiA+IEFuZCB5b3UncmUgc2VlaW5n IGVycm9ycyB3aGVuIG9wZW5pbmcgcG9ydHMgMC0zIGR1ZSB0byB0aGUgRFRSIGNhbGxzCj4+ID4g d2hpY2ggSSBndWVzcyBubyBvbmUgbm90aWNlZCBvciBjYXJlZCBhYm91dCBiZWZvcmU/Cj4+IAo+ PiBSaWdodCwgc29tZSB1c2Vyc3BhY2UgdG9vbHMgY29tcGxhaW4gYWJvdXQgdGhpcy4KPgo+IEht bS4gWW91IHNob3VsZG4ndCBzZWUgYW55IGVycm9ycyBvbiBvcGVuICh0aGV5J3JlIG5vdCBldmVu IGxvZ2dlZCksIGJ1dAo+IEkgZ3Vlc3MgeW91ciB1c2VyIHNwYWNlIHRvb2xzIGNvbXBsYWlucyBv biByZWNlaXZpbmcgLUVQUk9UTyBpbnN0ZWFkIG9mCj4gLUVJTlZBTCB3aGVuIHRyeWluZyB0byBt YW5hZ2UgdGhlc2Ugc2lnbmFscyBkaXJlY3RseT8KClllcywgb25lIHNwZWNpZmljIGNhc2UgaXMg cHlzZXJpYWwuICBPbiBvcGVuLCBpdCBhdHRlbXB0cyB0byBzZXQgdGhvc2UKc2lnbmFscyBhbmQs IGRlcGVuZGluZyBvbiB0aGUgZXJyb3IgcmV0dXJuZWQsIGVpdGhlciBhYm9ydHMgb3IgbWFya3MK dGhlbSBhcyB1bmF2YWlsYWJsZS4KCj4+ID4gQmVmb3JlIHlvdSBzZW50IG1lIHRoZSBsc3VzYiBJ IHNlYXJjaGVkIGZvciBpdCBhbmQgY2FtZSBhY3Jvc3MgdGhlIGJlbG93Cj4+ID4gdGhyZWFkIHdo ZXJlIEJqw7hybidzIGhhdmluZyBhIGdvIGF0IFNJTUNvbS4gSW4gaXQgdGhlcmUncyBvdXRwdXQg ZnJvbSBhCj4+ID4gc2Vjb25kIGRldmljZSB1c2luZyB0aGUgc2FtZSBpZCBidXQgd2l0aCBlbnRp cmVseSBkaWZmZXJlbnQgZGVzY3JpcHRvcnMuCj4+ID4KPj4gPiAJaHR0cHM6Ly9mb3J1bS5vcGVu d3J0Lm9yZy90L2x0ZS13aXJlbGVzcy1tb2R1bGUtc3VwcG9ydC1ieS1vcGVud3J0LWxlZC1vbi10 cGxpbmsvMTM1ODY/cGFnZT0zCj4+ID4KPj4gPiBJZiB0aGlzIGlzIGEgY29tbW9uIHRoZW1lIHdp dGggdGhpcyB2ZW5kb3Igd2UgbWF5IG5lZWQgdG8gYmUgZXh0cmEKPj4gPiBjYXJlZnVsIHdoZW4g bWFraW5nIGNoYW5nZXMuCj4+IAo+PiBJc24ndCB0aGlzIGEgY29tbW9uIHRoZW1lIHdpdGggbW9z dCBVU0IgdmVuZG9ycywgZXNwZWNpYWxseSB3aXJlbGVzcyB0aGluZ3M/Cj4+IAo+PiBSZWdhcmRs ZXNzLCBzZXR0aW5nIHRoZSBOQ1RSTCBmbGFnIHNob3VsZCBiZSBoYXJtbGVzcy4KPgo+IFdlbGws IHRoZXJlIGFyZSBkZXZpY2VzIHRoYXQgZGVwZW5kIG9uIGdldHRpbmcgdGhlc2UgcmVxdWVzdHMs IGF0IGxlYXN0Cj4gZm9yIHRoZSBRTUkgaW50ZXJmYWNlLiBCdXQgd2UgY2FuIGFsd2F5cyByZXZl cnQgaWYgYW55b25lIGNvbXBsYWlucy4KClRoZSBRTUkgaW50ZXJmYWNlIGRvZXNuJ3QgZXZlbiBw cmV0ZW5kIHRvIGJlIGEgdWFydC4gIFRoZSBvdGhlciBvbmVzIGRvLApidXQgdGhlcmUgaXNuJ3Qg YWN0dWFsbHkgYW55IHJlYWwgdWFydCBiZWhpbmQgdGhlbS4gIEZvciBpbnN0YW5jZSwgaXQKZG9l c24ndCBtYXR0ZXIgd2hhdCBiYXVkIHJhdGUgb25lIHNldHMuCgo+IE5vdyBhcHBsaWVkLCB0aGFu a3MuCgpUaGFua3MuCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0B28C43381 for ; Tue, 19 Mar 2019 10:54:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BC43A20857 for ; Tue, 19 Mar 2019 10:54:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727504AbfCSKyD convert rfc822-to-8bit (ORCPT ); Tue, 19 Mar 2019 06:54:03 -0400 Received: from unicorn.mansr.com ([81.2.72.234]:37116 "EHLO unicorn.mansr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725862AbfCSKyD (ORCPT ); Tue, 19 Mar 2019 06:54:03 -0400 Received: by unicorn.mansr.com (Postfix, from userid 51770) id E361D14CEB; Tue, 19 Mar 2019 10:54:00 +0000 (GMT) From: =?iso-8859-1?Q?M=E5ns_Rullg=E5rd?= To: Johan Hovold Cc: =?iso-8859-1?Q?Bj=F8rn?= Mork , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] USB: serial: option: set driver_info for SIM5218 and compatibles References: <20190226170710.12709-1-mans@mansr.com> <20190227083342.GJ4747@localhost> <20190227131315.GO4747@localhost> <20190319102840.GI6124@localhost> Date: Tue, 19 Mar 2019 10:54:00 +0000 In-Reply-To: <20190319102840.GI6124@localhost> (Johan Hovold's message of "Tue, 19 Mar 2019 11:28:40 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Johan Hovold writes: > On Wed, Feb 27, 2019 at 02:32:58PM +0000, Måns Rullgård wrote: >> Johan Hovold writes: >> >> > Adding Bjørn. >> > >> > On Wed, Feb 27, 2019 at 11:57:16AM +0000, Måns Rullgård wrote: >> >> Johan Hovold writes: >> >> >> >> > On Tue, Feb 26, 2019 at 05:07:10PM +0000, Mans Rullgard wrote: >> >> >> The SIMCom SIM5218 and compatible devices have 5 USB interfaces, only 4 >> >> >> of which are serial ports. The fifth is a network interface supported >> >> >> by the qmi-wwan driver. Furthermore, the serial ports do not support >> >> >> modem control signals. Add driver_info flags to reflect this. >> >> >> >> >> >> Signed-off-by: Mans Rullgard >> >> >> --- >> >> >> drivers/usb/serial/option.c | 3 ++- >> >> >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> >> >> >> >> diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c >> >> >> index fb544340888b..af4cbfecc3ff 100644 >> >> >> --- a/drivers/usb/serial/option.c >> >> >> +++ b/drivers/usb/serial/option.c >> >> >> @@ -1066,7 +1066,8 @@ static const struct usb_device_id option_ids[] = { >> >> >> .driver_info = RSVD(3) }, >> >> >> { USB_DEVICE(QUALCOMM_VENDOR_ID, 0x6613)}, /* Onda H600/ZTE MF330 */ >> >> >> { USB_DEVICE(QUALCOMM_VENDOR_ID, 0x0023)}, /* ONYX 3G device */ >> >> >> - { USB_DEVICE(QUALCOMM_VENDOR_ID, 0x9000)}, /* SIMCom SIM5218 */ >> >> >> + { USB_DEVICE(QUALCOMM_VENDOR_ID, 0x9000), /* SIMCom SIM5218 */ >> >> >> + .driver_info = NCTRL(0) | NCTRL(1) | NCTRL(2) | NCTRL(3) | RSVD(4) }, >> >> >> /* Quectel products using Qualcomm vendor ID */ >> >> >> { USB_DEVICE(QUALCOMM_VENDOR_ID, QUECTEL_PRODUCT_UC15)}, >> >> >> { USB_DEVICE(QUALCOMM_VENDOR_ID, QUECTEL_PRODUCT_UC20), >> >> > >> >> > Could you please provide the output of usb-devices (or lsusb -v) for >> >> > this device? >> >> >> >> lsusb -v: >> >> [...] >> >> > So the patch looks fine to me. The fifth interface is QMI, but hasn't >> > been available for use until now then, and this seems to have been the >> > vendors idea from the start: >> > >> > http://www.microchip.ua/simcom/WCDMA/APPNOTES/SIMCom_3G_Linux_driver_Application%20Note_V1.00.pdf >> >> That document predates the qmi-wwan driver in the kernel. Note that >> this driver has an ID table entry for interface 4 of this device. Right >> now, whichever driver is probed first claims that interface. I haven't >> actually tried using the QMI interface, though. > > I didn't say it was correct, just that the vendor proposed binding to it > anyway. > >> > And you're seeing errors when opening ports 0-3 due to the DTR calls >> > which I guess no one noticed or cared about before? >> >> Right, some userspace tools complain about this. > > Hmm. You shouldn't see any errors on open (they're not even logged), but > I guess your user space tools complains on receiving -EPROTO instead of > -EINVAL when trying to manage these signals directly? Yes, one specific case is pyserial. On open, it attempts to set those signals and, depending on the error returned, either aborts or marks them as unavailable. >> > Before you sent me the lsusb I searched for it and came across the below >> > thread where Bjørn's having a go at SIMCom. In it there's output from a >> > second device using the same id but with entirely different descriptors. >> > >> > https://forum.openwrt.org/t/lte-wireless-module-support-by-openwrt-led-on-tplink/13586?page=3 >> > >> > If this is a common theme with this vendor we may need to be extra >> > careful when making changes. >> >> Isn't this a common theme with most USB vendors, especially wireless things? >> >> Regardless, setting the NCTRL flag should be harmless. > > Well, there are devices that depend on getting these requests, at least > for the QMI interface. But we can always revert if anyone complains. The QMI interface doesn't even pretend to be a uart. The other ones do, but there isn't actually any real uart behind them. For instance, it doesn't matter what baud rate one sets. > Now applied, thanks. Thanks. -- Måns Rullgård