From: "Måns Rullgård" <mans@mansr.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Miguel Ojeda Sandonis <miguel.ojeda.sandonis@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] auxdisplay: charlcd: make backlight initial state configurable
Date: Tue, 12 Mar 2019 15:48:06 +0000 [thread overview]
Message-ID: <yw1xo96g2ix5.fsf@mansr.com> (raw)
In-Reply-To: <CAHp75VfZUN0PVwveB9FM6QvyJicVE5WjCX3b5rfCGZOQs9hO8A@mail.gmail.com> (Andy Shevchenko's message of "Tue, 12 Mar 2019 17:45:24 +0200")
Andy Shevchenko <andy.shevchenko@gmail.com> writes:
> On Fri, Mar 1, 2019 at 9:14 PM Mans Rullgard <mans@mansr.com> wrote:
>>
>> The charlcd driver currently flashes the backlight once on init.
>> This may not be desirable. Thus, add options for turning the
>> backlight off or on as well.
>>
>> Signed-off-by: Mans Rullgard <mans@mansr.com>
>> ---
>> drivers/auxdisplay/Kconfig | 21 +++++++++++++++++++++
>> drivers/auxdisplay/charlcd.c | 10 +++++++++-
>> 2 files changed, 30 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/auxdisplay/Kconfig b/drivers/auxdisplay/Kconfig
>> index 7d3fe27d6868..c52c738e554a 100644
>> --- a/drivers/auxdisplay/Kconfig
>> +++ b/drivers/auxdisplay/Kconfig
>> @@ -445,6 +445,27 @@ config PANEL_BOOT_MESSAGE
>> An empty message will only clear the display at driver init time. Any other
>> printf()-formatted message is valid with newline and escape codes.
>>
>> +choice
>> + prompt "Backlight initial state"
>> + default CHARLCD_BL_FLASH
>
> LGTM, but I don't agree on this default. I would prefer either on or
> off, not flashing for sure.
> Though it seems the case before the patch...
The current code unconditionally flashes the light once. I though it
best to keep that behaviour as default, even if it's not seen as ideal.
--
Måns Rullgård
next prev parent reply other threads:[~2019-03-12 15:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-01 18:48 [PATCH 1/3] auxdisplay: deconfuse configuration Mans Rullgard
2019-03-01 18:48 ` [PATCH 2/3] auxdisplay: charlcd: simplify init message display Mans Rullgard
2019-03-06 10:03 ` Miguel Ojeda
2019-03-01 18:48 ` [PATCH 3/3] auxdisplay: charlcd: make backlight initial state configurable Mans Rullgard
2019-03-06 9:56 ` Miguel Ojeda
2019-03-06 10:03 ` Miguel Ojeda
2019-03-06 14:49 ` Måns Rullgård
2019-03-12 15:45 ` Andy Shevchenko
2019-03-12 15:48 ` Måns Rullgård [this message]
2019-03-17 7:43 ` Miguel Ojeda
2019-03-17 16:52 ` Måns Rullgård
2019-03-06 10:14 ` [PATCH 1/3] auxdisplay: deconfuse configuration Miguel Ojeda
2019-03-06 15:08 ` Måns Rullgård
2019-03-23 14:28 ` Miguel Ojeda
2019-03-23 14:50 ` Randy Dunlap
2019-03-23 15:00 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yw1xo96g2ix5.fsf@mansr.com \
--to=mans@mansr.com \
--cc=andy.shevchenko@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.