From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: USB: serial: option: set driver_info for SIM5218 and compatibles From: =?utf-8?b?TcOlbnMgUnVsbGfDpXJk?= Message-Id: Date: Tue, 19 Mar 2019 14:35:18 +0000 To: Dan Williams Cc: Johan Hovold , =?iso-8859-1?Q?Bj=F8rn?= Mork , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org List-ID: RGFuIFdpbGxpYW1zIDxkY2J3QHJlZGhhdC5jb20+IHdyaXRlczoKCj4gT24gVHVlLCAyMDE5LTAz LTE5IGF0IDEzOjQzICswMTAwLCBKb2hhbiBIb3ZvbGQgd3JvdGU6Cj4+IE9uIFR1ZSwgTWFyIDE5 LCAyMDE5IGF0IDAxOjI3OjE5UE0gKzAxMDAsIEpvaGFuIEhvdm9sZCB3cm90ZToKPj4gPiBPbiBU dWUsIE1hciAxOSwgMjAxOSBhdCAxMjoyNTo1M1BNICswMDAwLCBNw6VucyBSdWxsZ8OlcmQgd3Jv dGU6Cj4+ID4gPiBKb2hhbiBIb3ZvbGQgPGpvaGFuQGtlcm5lbC5vcmc+IHdyaXRlczoKPj4gPiA+ IAo+PiA+ID4gPiBPbiBUdWUsIE1hciAxOSwgMjAxOSBhdCAxMDo1NDowMEFNICswMDAwLCBNw6Vu cyBSdWxsZ8OlcmQgd3JvdGU6Cj4+ID4gPiA+ID4gSm9oYW4gSG92b2xkIDxqb2hhbkBrZXJuZWwu b3JnPiB3cml0ZXM6Cj4+ID4gPiA+ID4gPiA+IFJlZ2FyZGxlc3MsIHNldHRpbmcgdGhlIE5DVFJM IGZsYWcgc2hvdWxkIGJlIGhhcm1sZXNzLgo+PiA+ID4gPiA+ID4gCj4+ID4gPiA+ID4gPiBXZWxs LCB0aGVyZSBhcmUgZGV2aWNlcyB0aGF0IGRlcGVuZCBvbiBnZXR0aW5nIHRoZXNlCj4+ID4gPiA+ ID4gPiByZXF1ZXN0cywgYXQgbGVhc3QKPj4gPiA+ID4gPiA+IGZvciB0aGUgUU1JIGludGVyZmFj ZS4gQnV0IHdlIGNhbiBhbHdheXMgcmV2ZXJ0IGlmIGFueW9uZQo+PiA+ID4gPiA+ID4gY29tcGxh aW5zLgo+PiA+ID4gPiA+IAo+PiA+ID4gPiA+IFRoZSBRTUkgaW50ZXJmYWNlIGRvZXNuJ3QgZXZl biBwcmV0ZW5kIHRvIGJlIGEgdWFydC4gIFRoZQo+PiA+ID4gPiA+IG90aGVyIG9uZXMgZG8sCj4+ ID4gPiA+ID4gYnV0IHRoZXJlIGlzbid0IGFjdHVhbGx5IGFueSByZWFsIHVhcnQgYmVoaW5kIHRo ZW0uICBGb3IKPj4gPiA+ID4gPiBpbnN0YW5jZSwgaXQKPj4gPiA+ID4gPiBkb2Vzbid0IG1hdHRl ciB3aGF0IGJhdWQgcmF0ZSBvbmUgc2V0cy4KPj4gPiA+ID4gCj4+ID4gPiA+IFN1cmUsIGJ1dCBz b21lIGRldmljZXMgc3RpbGwgcmVxdWlyZSAiRFRSIiB0byBiZSBzZXQgZm9yIHRoZQo+PiA+ID4g PiBRTUkKPj4gPiA+ID4gaW50ZXJmYWNlLCBzbyB0aGVyZSBub3QgYmVpbmcgYW55IHJlYWwgdWFy dCBpcyBubyBndWFyYW50ZWUKPj4gPiA+ID4gdGhhdCB0aGVyZQo+PiA+ID4gPiBpcyBubyBmaXJt d2FyZSB0aGF0IGV4cGVjdHMgdGhlc2UgY2FsbHMuCj4+ID4gPiAKPj4gPiA+IE5vdyBJJ20gdGhv cm91Z2hseSBjb25mdXNlZC4gIFRoZSBRTUkgaW50ZXJmYWNlIGhhcyBhIGNvbXBsZXRlbHkKPj4g PiA+IHNlcGFyYXRlIGRyaXZlciB0aGF0IGNyZWF0ZXMgYSBuZXR3b3JrIGRldmljZSAoaWYgSSdt IHJlYWRpbmcgdGhlCj4+ID4gPiBjb2RlCj4+ID4gPiBjb3JyZWN0bHkpLgo+PiA+IAo+PiA+IEkg d2FzIGp1c3QgZ2l2aW5nIGFuIGV4YW1wbGUgb2YgZmlybXdhcmUgc29tZXRpbWVzIGRvaW5nIHVu ZXhwZWN0ZWQKPj4gPiB0aGluZ3MuCj4+IAo+PiBTZWUgOTM3MjUxNDk3OTRkICgibmV0OiBxbWlf d3dhbjogTURNOXgzMCBzcGVjaWZpYyBwb3dlciBtYW5hZ2VtZW50IikKPj4gZm9yIHNvbWUgYmFj a2dyb3VuZC4KPgo+IFRMRFI7IHNvbWUgZmlybXdhcmUgdXNlcyB0aGUgRFRSIHNpZ25hbCBhcyBh biBpbmRpY2F0b3IgdG8gY29tZSBvdXQgb2YKPiBsb3ctcG93ZXIgbW9kZS4gV2l0aG91dCBkb2lu ZyBzbyB5b3UgY2Fubm90IHRhbGsgdG8gdGhlIG1vZGVtIG92ZXIgYW55Cj4gb2YgaXQncyBwb3J0 cywgUU1JLCBuZXQsIG9yIHNlcmlhbC4KCkkgbXVzdCBiZSBtaXNzaW5nIHNvbWV0aGluZywgYnV0 IGhvdyBkb2VzIGEgbmV0d29yayBpbnRlcmZhY2UgaGF2ZSBhIERUUgpzaWduYWw/Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98C27C43381 for ; Tue, 19 Mar 2019 14:35:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 616652133D for ; Tue, 19 Mar 2019 14:35:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727661AbfCSOfV convert rfc822-to-8bit (ORCPT ); Tue, 19 Mar 2019 10:35:21 -0400 Received: from unicorn.mansr.com ([81.2.72.234]:39426 "EHLO unicorn.mansr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726573AbfCSOfU (ORCPT ); Tue, 19 Mar 2019 10:35:20 -0400 Received: by unicorn.mansr.com (Postfix, from userid 51770) id E54B114CEB; Tue, 19 Mar 2019 14:35:18 +0000 (GMT) From: =?iso-8859-1?Q?M=E5ns_Rullg=E5rd?= To: Dan Williams Cc: Johan Hovold , =?iso-8859-1?Q?Bj=F8rn?= Mork , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] USB: serial: option: set driver_info for SIM5218 and compatibles References: <20190226170710.12709-1-mans@mansr.com> <20190227083342.GJ4747@localhost> <20190227131315.GO4747@localhost> <20190319102840.GI6124@localhost> <20190319110819.GB3178@localhost> <20190319122719.GC3178@localhost> <20190319124358.GK6124@localhost> <6c89938b00ad289e1802f675bd00e288b1458d73.camel@redhat.com> Date: Tue, 19 Mar 2019 14:35:18 +0000 In-Reply-To: <6c89938b00ad289e1802f675bd00e288b1458d73.camel@redhat.com> (Dan Williams's message of "Tue, 19 Mar 2019 09:30:25 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dan Williams writes: > On Tue, 2019-03-19 at 13:43 +0100, Johan Hovold wrote: >> On Tue, Mar 19, 2019 at 01:27:19PM +0100, Johan Hovold wrote: >> > On Tue, Mar 19, 2019 at 12:25:53PM +0000, Måns Rullgård wrote: >> > > Johan Hovold writes: >> > > >> > > > On Tue, Mar 19, 2019 at 10:54:00AM +0000, Måns Rullgård wrote: >> > > > > Johan Hovold writes: >> > > > > > > Regardless, setting the NCTRL flag should be harmless. >> > > > > > >> > > > > > Well, there are devices that depend on getting these >> > > > > > requests, at least >> > > > > > for the QMI interface. But we can always revert if anyone >> > > > > > complains. >> > > > > >> > > > > The QMI interface doesn't even pretend to be a uart. The >> > > > > other ones do, >> > > > > but there isn't actually any real uart behind them. For >> > > > > instance, it >> > > > > doesn't matter what baud rate one sets. >> > > > >> > > > Sure, but some devices still require "DTR" to be set for the >> > > > QMI >> > > > interface, so there not being any real uart is no guarantee >> > > > that there >> > > > is no firmware that expects these calls. >> > > >> > > Now I'm thoroughly confused. The QMI interface has a completely >> > > separate driver that creates a network device (if I'm reading the >> > > code >> > > correctly). >> > >> > I was just giving an example of firmware sometimes doing unexpected >> > things. >> >> See 93725149794d ("net: qmi_wwan: MDM9x30 specific power management") >> for some background. > > TLDR; some firmware uses the DTR signal as an indicator to come out of > low-power mode. Without doing so you cannot talk to the modem over any > of it's ports, QMI, net, or serial. I must be missing something, but how does a network interface have a DTR signal? -- Måns Rullgård