From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: USB: serial: option: set driver_info for SIM5218 and compatibles From: =?utf-8?b?TcOlbnMgUnVsbGfDpXJk?= Message-Id: Date: Mon, 18 Mar 2019 14:32:14 +0000 To: Johan Hovold Cc: =?iso-8859-1?Q?Bj=F8rn?= Mork , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org List-ID: TcOlbnMgUnVsbGfDpXJkIDxtYW5zQG1hbnNyLmNvbT4gd3JpdGVzOgoKPiBKb2hhbiBIb3ZvbGQg PGpvaGFuQGtlcm5lbC5vcmc+IHdyaXRlczoKPgo+PiBBZGRpbmcgQmrDuHJuLgo+Pgo+PiBPbiBX ZWQsIEZlYiAyNywgMjAxOSBhdCAxMTo1NzoxNkFNICswMDAwLCBNw6VucyBSdWxsZ8OlcmQgd3Jv dGU6Cj4+PiBKb2hhbiBIb3ZvbGQgPGpvaGFuQGtlcm5lbC5vcmc+IHdyaXRlczoKPj4+IAo+Pj4g PiBPbiBUdWUsIEZlYiAyNiwgMjAxOSBhdCAwNTowNzoxMFBNICswMDAwLCBNYW5zIFJ1bGxnYXJk IHdyb3RlOgo+Pj4gPj4gVGhlIFNJTUNvbSBTSU01MjE4IGFuZCBjb21wYXRpYmxlIGRldmljZXMg aGF2ZSA1IFVTQiBpbnRlcmZhY2VzLCBvbmx5IDQKPj4+ID4+IG9mIHdoaWNoIGFyZSBzZXJpYWwg cG9ydHMuICBUaGUgZmlmdGggaXMgYSBuZXR3b3JrIGludGVyZmFjZSBzdXBwb3J0ZWQKPj4+ID4+ IGJ5IHRoZSBxbWktd3dhbiBkcml2ZXIuICBGdXJ0aGVybW9yZSwgdGhlIHNlcmlhbCBwb3J0cyBk byBub3Qgc3VwcG9ydAo+Pj4gPj4gbW9kZW0gY29udHJvbCBzaWduYWxzLiAgQWRkIGRyaXZlcl9p bmZvIGZsYWdzIHRvIHJlZmxlY3QgdGhpcy4KPj4+ID4+IAo+Pj4gPj4gU2lnbmVkLW9mZi1ieTog TWFucyBSdWxsZ2FyZCA8bWFuc0BtYW5zci5jb20+Cj4+PiA+PiAtLS0KPj4+ID4+ICBkcml2ZXJz L3VzYi9zZXJpYWwvb3B0aW9uLmMgfCAzICsrLQo+Pj4gPj4gIDEgZmlsZSBjaGFuZ2VkLCAyIGlu c2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKPj4+ID4+IAo+Pj4gPj4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvdXNiL3NlcmlhbC9vcHRpb24uYyBiL2RyaXZlcnMvdXNiL3NlcmlhbC9vcHRpb24uYwo+ Pj4gPj4gaW5kZXggZmI1NDQzNDA4ODhiLi5hZjRjYmZlY2MzZmYgMTAwNjQ0Cj4+PiA+PiAtLS0g YS9kcml2ZXJzL3VzYi9zZXJpYWwvb3B0aW9uLmMKPj4+ID4+ICsrKyBiL2RyaXZlcnMvdXNiL3Nl cmlhbC9vcHRpb24uYwo+Pj4gPj4gQEAgLTEwNjYsNyArMTA2Niw4IEBAIHN0YXRpYyBjb25zdCBz dHJ1Y3QgdXNiX2RldmljZV9pZCBvcHRpb25faWRzW10gPSB7Cj4+PiA+PiAgCSAgLmRyaXZlcl9p bmZvID0gUlNWRCgzKSB9LAo+Pj4gPj4gIAl7IFVTQl9ERVZJQ0UoUVVBTENPTU1fVkVORE9SX0lE LCAweDY2MTMpfSwgLyogT25kYSBINjAwL1pURSBNRjMzMCAqLwo+Pj4gPj4gIAl7IFVTQl9ERVZJ Q0UoUVVBTENPTU1fVkVORE9SX0lELCAweDAwMjMpfSwgLyogT05ZWCAzRyBkZXZpY2UgKi8KPj4+ ID4+IC0JeyBVU0JfREVWSUNFKFFVQUxDT01NX1ZFTkRPUl9JRCwgMHg5MDAwKX0sIC8qIFNJTUNv bSBTSU01MjE4ICovCj4+PiA+PiArCXsgVVNCX0RFVklDRShRVUFMQ09NTV9WRU5ET1JfSUQsIDB4 OTAwMCksIC8qIFNJTUNvbSBTSU01MjE4ICovCj4+PiA+PiArCSAgLmRyaXZlcl9pbmZvID0gTkNU UkwoMCkgfCBOQ1RSTCgxKSB8IE5DVFJMKDIpIHwgTkNUUkwoMykgfCBSU1ZEKDQpIH0sCj4+PiA+ PiAgCS8qIFF1ZWN0ZWwgcHJvZHVjdHMgdXNpbmcgUXVhbGNvbW0gdmVuZG9yIElEICovCj4+PiA+ PiAgCXsgVVNCX0RFVklDRShRVUFMQ09NTV9WRU5ET1JfSUQsIFFVRUNURUxfUFJPRFVDVF9VQzE1 KX0sCj4+PiA+PiAgCXsgVVNCX0RFVklDRShRVUFMQ09NTV9WRU5ET1JfSUQsIFFVRUNURUxfUFJP RFVDVF9VQzIwKSwKPj4+ID4KPj4+ID4gQ291bGQgeW91IHBsZWFzZSBwcm92aWRlIHRoZSBvdXRw dXQgb2YgdXNiLWRldmljZXMgKG9yIGxzdXNiIC12KSBmb3IKPj4+ID4gdGhpcyBkZXZpY2U/Cj4+ PiAKPj4+IGxzdXNiIC12Ogo+Pj4gWy4uLl0KPgo+PiBTbyB0aGUgcGF0Y2ggbG9va3MgZmluZSB0 byBtZS4gVGhlIGZpZnRoIGludGVyZmFjZSBpcyBRTUksIGJ1dCBoYXNuJ3QKPj4gYmVlbiBhdmFp bGFibGUgZm9yIHVzZSB1bnRpbCBub3cgdGhlbiwgYW5kIHRoaXMgc2VlbXMgdG8gaGF2ZSBiZWVu IHRoZQo+PiB2ZW5kb3JzIGlkZWEgZnJvbSB0aGUgc3RhcnQ6Cj4+Cj4+IAlodHRwOi8vd3d3Lm1p Y3JvY2hpcC51YS9zaW1jb20vV0NETUEvQVBQTk9URVMvU0lNQ29tXzNHX0xpbnV4X2RyaXZlcl9B cHBsaWNhdGlvbiUyME5vdGVfVjEuMDAucGRmCj4KPiBUaGF0IGRvY3VtZW50IHByZWRhdGVzIHRo ZSBxbWktd3dhbiBkcml2ZXIgaW4gdGhlIGtlcm5lbC4gIE5vdGUgdGhhdAo+IHRoaXMgZHJpdmVy IGhhcyBhbiBJRCB0YWJsZSBlbnRyeSBmb3IgaW50ZXJmYWNlIDQgb2YgdGhpcyBkZXZpY2UuICBS aWdodAo+IG5vdywgd2hpY2hldmVyIGRyaXZlciBpcyBwcm9iZWQgZmlyc3QgY2xhaW1zIHRoYXQg aW50ZXJmYWNlLiAgSSBoYXZlbid0Cj4gYWN0dWFsbHkgdHJpZWQgdXNpbmcgdGhlIFFNSSBpbnRl cmZhY2UsIHRob3VnaC4KPgo+PiBBbmQgeW91J3JlIHNlZWluZyBlcnJvcnMgd2hlbiBvcGVuaW5n IHBvcnRzIDAtMyBkdWUgdG8gdGhlIERUUiBjYWxscwo+PiB3aGljaCBJIGd1ZXNzIG5vIG9uZSBu b3RpY2VkIG9yIGNhcmVkIGFib3V0IGJlZm9yZT8KPgo+IFJpZ2h0LCBzb21lIHVzZXJzcGFjZSB0 b29scyBjb21wbGFpbiBhYm91dCB0aGlzLgo+Cj4+IEJlZm9yZSB5b3Ugc2VudCBtZSB0aGUgbHN1 c2IgSSBzZWFyY2hlZCBmb3IgaXQgYW5kIGNhbWUgYWNyb3NzIHRoZSBiZWxvdwo+PiB0aHJlYWQg d2hlcmUgQmrDuHJuJ3MgaGF2aW5nIGEgZ28gYXQgU0lNQ29tLiBJbiBpdCB0aGVyZSdzIG91dHB1 dCBmcm9tIGEKPj4gc2Vjb25kIGRldmljZSB1c2luZyB0aGUgc2FtZSBpZCBidXQgd2l0aCBlbnRp cmVseSBkaWZmZXJlbnQgZGVzY3JpcHRvcnMuCj4+Cj4+IAlodHRwczovL2ZvcnVtLm9wZW53cnQu b3JnL3QvbHRlLXdpcmVsZXNzLW1vZHVsZS1zdXBwb3J0LWJ5LW9wZW53cnQtbGVkLW9uLXRwbGlu ay8xMzU4Nj9wYWdlPTMKPj4KPj4gSWYgdGhpcyBpcyBhIGNvbW1vbiB0aGVtZSB3aXRoIHRoaXMg dmVuZG9yIHdlIG1heSBuZWVkIHRvIGJlIGV4dHJhCj4+IGNhcmVmdWwgd2hlbiBtYWtpbmcgY2hh bmdlcy4KPgo+IElzbid0IHRoaXMgYSBjb21tb24gdGhlbWUgd2l0aCBtb3N0IFVTQiB2ZW5kb3Jz LCBlc3BlY2lhbGx5IHdpcmVsZXNzIHRoaW5ncz8KPgo+IFJlZ2FyZGxlc3MsIHNldHRpbmcgdGhl IE5DVFJMIGZsYWcgc2hvdWxkIGJlIGhhcm1sZXNzLgoKQW55IGZ1cnRoZXIgY29tbWVudHMgb24g dGhpcz8K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 893F0C43381 for ; Mon, 18 Mar 2019 14:32:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4FD402085A for ; Mon, 18 Mar 2019 14:32:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727890AbfCROcQ convert rfc822-to-8bit (ORCPT ); Mon, 18 Mar 2019 10:32:16 -0400 Received: from unicorn.mansr.com ([81.2.72.234]:56320 "EHLO unicorn.mansr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727673AbfCROcP (ORCPT ); Mon, 18 Mar 2019 10:32:15 -0400 Received: by unicorn.mansr.com (Postfix, from userid 51770) id 528ED15060; Mon, 18 Mar 2019 14:32:14 +0000 (GMT) From: =?iso-8859-1?Q?M=E5ns_Rullg=E5rd?= To: Johan Hovold Cc: =?iso-8859-1?Q?Bj=F8rn?= Mork , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] USB: serial: option: set driver_info for SIM5218 and compatibles References: <20190226170710.12709-1-mans@mansr.com> <20190227083342.GJ4747@localhost> <20190227131315.GO4747@localhost> Date: Mon, 18 Mar 2019 14:32:14 +0000 In-Reply-To: (=?iso-8859-1?Q?=22M=E5ns_Rullg?= =?iso-8859-1?Q?=E5rd=22's?= message of "Wed, 27 Feb 2019 14:32:58 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Måns Rullgård writes: > Johan Hovold writes: > >> Adding Bjørn. >> >> On Wed, Feb 27, 2019 at 11:57:16AM +0000, Måns Rullgård wrote: >>> Johan Hovold writes: >>> >>> > On Tue, Feb 26, 2019 at 05:07:10PM +0000, Mans Rullgard wrote: >>> >> The SIMCom SIM5218 and compatible devices have 5 USB interfaces, only 4 >>> >> of which are serial ports. The fifth is a network interface supported >>> >> by the qmi-wwan driver. Furthermore, the serial ports do not support >>> >> modem control signals. Add driver_info flags to reflect this. >>> >> >>> >> Signed-off-by: Mans Rullgard >>> >> --- >>> >> drivers/usb/serial/option.c | 3 ++- >>> >> 1 file changed, 2 insertions(+), 1 deletion(-) >>> >> >>> >> diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c >>> >> index fb544340888b..af4cbfecc3ff 100644 >>> >> --- a/drivers/usb/serial/option.c >>> >> +++ b/drivers/usb/serial/option.c >>> >> @@ -1066,7 +1066,8 @@ static const struct usb_device_id option_ids[] = { >>> >> .driver_info = RSVD(3) }, >>> >> { USB_DEVICE(QUALCOMM_VENDOR_ID, 0x6613)}, /* Onda H600/ZTE MF330 */ >>> >> { USB_DEVICE(QUALCOMM_VENDOR_ID, 0x0023)}, /* ONYX 3G device */ >>> >> - { USB_DEVICE(QUALCOMM_VENDOR_ID, 0x9000)}, /* SIMCom SIM5218 */ >>> >> + { USB_DEVICE(QUALCOMM_VENDOR_ID, 0x9000), /* SIMCom SIM5218 */ >>> >> + .driver_info = NCTRL(0) | NCTRL(1) | NCTRL(2) | NCTRL(3) | RSVD(4) }, >>> >> /* Quectel products using Qualcomm vendor ID */ >>> >> { USB_DEVICE(QUALCOMM_VENDOR_ID, QUECTEL_PRODUCT_UC15)}, >>> >> { USB_DEVICE(QUALCOMM_VENDOR_ID, QUECTEL_PRODUCT_UC20), >>> > >>> > Could you please provide the output of usb-devices (or lsusb -v) for >>> > this device? >>> >>> lsusb -v: >>> [...] > >> So the patch looks fine to me. The fifth interface is QMI, but hasn't >> been available for use until now then, and this seems to have been the >> vendors idea from the start: >> >> http://www.microchip.ua/simcom/WCDMA/APPNOTES/SIMCom_3G_Linux_driver_Application%20Note_V1.00.pdf > > That document predates the qmi-wwan driver in the kernel. Note that > this driver has an ID table entry for interface 4 of this device. Right > now, whichever driver is probed first claims that interface. I haven't > actually tried using the QMI interface, though. > >> And you're seeing errors when opening ports 0-3 due to the DTR calls >> which I guess no one noticed or cared about before? > > Right, some userspace tools complain about this. > >> Before you sent me the lsusb I searched for it and came across the below >> thread where Bjørn's having a go at SIMCom. In it there's output from a >> second device using the same id but with entirely different descriptors. >> >> https://forum.openwrt.org/t/lte-wireless-module-support-by-openwrt-led-on-tplink/13586?page=3 >> >> If this is a common theme with this vendor we may need to be extra >> careful when making changes. > > Isn't this a common theme with most USB vendors, especially wireless things? > > Regardless, setting the NCTRL flag should be harmless. Any further comments on this? -- Måns Rullgård