From: "Måns Rullgård" <mans@mansr.com>
To: Nishka Dasgupta <nishkadg.linux@gmail.com>
Cc: vigneshr@ti.com, marc.w.gonzalez@free.fr, richard@nod.at,
marek.vasut@gmail.com, linux-mtd@lists.infradead.org,
miquel.raynal@bootlin.com, computersforpeace@gmail.com,
dwmw2@infradead.org
Subject: Re: [PATCH] mtd: rawnand: tango: Add of_node_put() before return
Date: Tue, 09 Jul 2019 19:42:48 +0100 [thread overview]
Message-ID: <yw1xtvbvf3rr.fsf@mansr.com> (raw)
In-Reply-To: <20190709171316.13451-1-nishkadg.linux@gmail.com> (Nishka Dasgupta's message of "Tue, 9 Jul 2019 22:43:16 +0530")
Nishka Dasgupta <nishkadg.linux@gmail.com> writes:
> Each iteration of for_each_child_of_node puts the previous node, but in
> the case of a return from the middle of the loop, there is no put, thus
> causing a memory leak. Hence add an of_node_put before the return.
> Issue found with Coccinelle.
>
> Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
> ---
> drivers/mtd/nand/raw/tango_nand.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mtd/nand/raw/tango_nand.c b/drivers/mtd/nand/raw/tango_nand.c
> index b3f2cabcc7c0..9acf2de37ee0 100644
> --- a/drivers/mtd/nand/raw/tango_nand.c
> +++ b/drivers/mtd/nand/raw/tango_nand.c
> @@ -659,6 +659,7 @@ static int tango_nand_probe(struct platform_device *pdev)
> err = chip_init(&pdev->dev, np);
> if (err) {
> tango_nand_remove(pdev);
> + of_node_put(np);
> return err;
> }
> }
> --
Acked-by: Mans Rullgard <mans@mansr.com>
--
Måns Rullgård
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2019-07-09 18:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-09 17:13 [PATCH] mtd: rawnand: tango: Add of_node_put() before return Nishka Dasgupta
2019-07-09 18:42 ` Måns Rullgård [this message]
2019-07-25 7:55 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yw1xtvbvf3rr.fsf@mansr.com \
--to=mans@mansr.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marc.w.gonzalez@free.fr \
--cc=marek.vasut@gmail.com \
--cc=miquel.raynal@bootlin.com \
--cc=nishkadg.linux@gmail.com \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.