From: Sangsu Park <sangsu4u.park@samsung.com>
To: 'Mark Brown' <broonie@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org, linux-samsung-soc@vger.kernel.org,
sbkim73@samsung.com, 'Kukjin Kim' <kgene.kim@samsung.com>,
ben-linux@fluff.org, lrg@ti.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ASoC: SAMSUNG: Add SND_SOC_DAIFMT_CONT option for snd_soc_set_fmt()
Date: Mon, 03 Sep 2012 11:10:03 +0900 [thread overview]
Message-ID: <001001cd8979$3b260d10$b1722730$@samsung.com> (raw)
In-Reply-To: <20120830174317.GG4356@opensource.wolfsonmicro.com>
On Sun, Aug 31, 2012 at 2:43 AM +0900, Mark Brown wrote:
> On Wed, Aug 29, 2012 at 08:06:32PM +0900, Sangsu Park wrote:
>
> Please check your mailer configuration, it looks like it's reformatting
> all the text with much longer line widths.
I've changed line width configuration. Is it ok now?
>
> > On Sun, Aug 26, 2012 at 05:45:54PM +0900, Mark Brown wrote:
>
> > > a whole lot of sense on the slave side, it's related to the clock
> generation so should have no
> > > effect at all on the slave side. The driver code looks reasonably
> sensible though.
>
> > You mean cpu side is slave?
>
> Yes.
But, Samsung pcm is working only for cpu master.
>
>
> > > What specifically is going wrong here?
>
> > SND_SOC_DAIFMT_CONT is used sound/soc/Samsung/pcm.c (s3c_pcm_set_fmt()) like
> below.
>
> > switch (fmt & SND_SOC_DAIFMT_CLOCK_MASK) {
> > case SND_SOC_DAIFMT_CONT:
> > pcm->idleclk = 1;
> > break;
> > case SND_SOC_DAIFMT_GATED:
> > pcm->idleclk = 0;
> > break;
> > default:
> > dev_err(pcm->dev, "Invalid Clock gating request!\n");
> > ret = -EINVAL;
> > goto exit;
> > }
>
> > If fmt argument has no SND_SOC_DAIFMT_ option, s3c_pcm_set_fmt() return -
> EINVAL.
>
> So, clearly this is unrelated to the change you mentioned in your commit
> message - it looks like this is just a plain issue in the machine
> driver. That said the above code should be changed to at least ignore
> the setting in slave mode (since the clock shouldn't be being driven and
> it doesn't matter).
Do you think that changing pcm driver is right approach?
Then I'll fix pcm driver. (I think that pcm driver has some strange code.)
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2012-09-03 2:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-26 8:45 [PATCH] ASoC: SAMSUNG: Add SND_SOC_DAIFMT_CONT option for snd_soc_set_fmt() 박상수
2012-08-27 20:45 ` Mark Brown
2012-08-29 11:06 ` Sangsu Park
2012-08-30 17:43 ` Mark Brown
2012-09-03 2:10 ` Sangsu Park [this message]
2012-09-06 0:21 ` Mark Brown
2012-09-06 8:57 ` Sangsu Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='001001cd8979$3b260d10$b1722730$@samsung.com' \
--to=sangsu4u.park@samsung.com \
--cc=alsa-devel@alsa-project.org \
--cc=ben-linux@fluff.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=lrg@ti.com \
--cc=sbkim73@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox