From: "Liao, Bard" <yung-chuan.liao@linux.intel.com>
To: Brent Lu <brent.lu@intel.com>, alsa-devel@alsa-project.org
Cc: Cezary Rojewski <cezary.rojewski@intel.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Liam Girdwood <liam.r.girdwood@linux.intel.com>,
Peter Ujfalusi <peter.ujfalusi@linux.intel.com>,
Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
linux-kernel@vger.kernel.org, Yong Zhi <yong.zhi@intel.com>,
Ajye Huang <ajye_huang@compal.corp-partner.google.com>,
Uday M Bhat <uday.m.bhat@intel.com>,
Terry Cheong <htcheong@chromium.org>,
Mac Chiang <mac.chiang@intel.com>,
"Dharageswari . R" <dharageswari.r@intel.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Subject: Re: [PATCH 1/2] ASoC: Intel: maxim-common: get codec number from ACPI
Date: Wed, 26 Jul 2023 19:25:31 +0800 [thread overview]
Message-ID: <00321a54-2c13-2a93-a6ab-7a76f1a87a3d@linux.intel.com> (raw)
In-Reply-To: <ff55e63f-1c17-12ef-57e6-144a5bea4480@linux.intel.com>
On 7/26/2023 4:47 PM, Liao, Bard wrote:
> ;
>> - /* add regular speakers dapm route */
>> - ret = snd_soc_dapm_add_routes(&card->dapm, max_98390_dapm_routes,
>> - ARRAY_SIZE(max_98390_dapm_routes));
>
> Don't we need to add max_98390_dapm_routes for the 4 speakers case?
>
Please ignore this comment. I didn't notice that it is a fallthrough not
break in the end of case 4.
next prev parent reply other threads:[~2023-07-26 11:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-20 9:26 [PATCH 0/2] Intel: sof_rt5682: remove quirk flag Brent Lu
2023-07-20 9:26 ` [PATCH 1/2] ASoC: Intel: maxim-common: get codec number from ACPI Brent Lu
2023-07-24 9:08 ` Pierre-Louis Bossart
2023-07-24 9:52 ` Andy Shevchenko
2023-07-24 11:06 ` Lu, Brent
2023-07-24 11:16 ` Andy Shevchenko
2023-07-26 6:16 ` Lu, Brent
2023-07-26 8:47 ` Liao, Bard
2023-07-26 11:25 ` Liao, Bard [this message]
2023-07-27 2:14 ` Lu, Brent
2023-07-27 3:21 ` Liao, Bard
2023-07-27 5:41 ` Pierre-Louis Bossart
2023-07-27 11:36 ` Mark Brown
2023-07-28 6:12 ` Lu, Brent
2023-07-20 9:26 ` [PATCH 2/2] ASoC: Intel: sof_rt5682: remove SOF_MAX98390_TWEETER_SPEAKER_PRESENT flag Brent Lu
2023-07-21 9:53 ` [PATCH 0/2] Intel: sof_rt5682: remove quirk flag Kai Vehmanen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00321a54-2c13-2a93-a6ab-7a76f1a87a3d@linux.intel.com \
--to=yung-chuan.liao@linux.intel.com \
--cc=ajye_huang@compal.corp-partner.google.com \
--cc=alsa-devel@alsa-project.org \
--cc=brent.lu@intel.com \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=dharageswari.r@intel.com \
--cc=htcheong@chromium.org \
--cc=kai.vehmanen@linux.intel.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mac.chiang@intel.com \
--cc=perex@perex.cz \
--cc=peter.ujfalusi@linux.intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=tiwai@suse.com \
--cc=uday.m.bhat@intel.com \
--cc=yong.zhi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox