From: Kukjin Kim <kgene.kim@samsung.com>
To: 'Jassi Brar' <jassisinghbrar@gmail.com>, alsa-devel@alsa-project.org
Cc: 'Jassi Brar' <jassi.brar@samsung.com>,
broonie@opensource.wolfsonmicro.com, mcuelenaere@gmail.com,
cw00.choi@samsung.com, ben-linux@fluff.org, june.bae@samsung.com,
lrg@slimlogic.co.uk, sw.youn@samsung.com
Subject: Re: [PATCHv2] ASoC: Overhaul Samsung drivers
Date: Fri, 22 Oct 2010 23:08:35 +0900 [thread overview]
Message-ID: <006f01cb71f2$a0136100$e03a2300$%kim@samsung.com> (raw)
In-Reply-To: <1287736238-11846-1-git-send-email-jassisinghbrar@gmail.com>
Jassi Brar wrote:
>
> From: Jassi Brar <jassi.brar@samsung.com>
>
> Hi,
>
Hi,
> Submitting revised patch series.
>
> Patches 11 through 16 apply to Kgene's tree, rest apply to
> Mark Brown's.
>
Hmm...
I faced with following build error after applying above 6 patches into my
tree.
It means can't make clean tree with only arch/arm patches?...
NO...just need to update arch/arm/plat-samsung/include/plat/audio.h of your
10/24 patch.
Please separate 10/24...there is no reason that to change plat/audio.h
belong to 10/24(Add common I2S driver)
arch/arm/mach-s3c64xx/dev-audio.c:77: error: unknown field 'type' specified
in initializer
arch/arm/mach-s3c64xx/dev-audio.c:77: error: extra brace group at end of
initializer
arch/arm/mach-s3c64xx/dev-audio.c:77: error: (near initialization for
'i2sv3_pdata')
arch/arm/mach-s3c64xx/dev-audio.c:78: error: extra brace group at end of
initializer
arch/arm/mach-s3c64xx/dev-audio.c:78: error: (near initialization for
'i2sv3_pdata')
arch/arm/mach-s3c64xx/dev-audio.c:81: warning: excess elements in struct
initializer
arch/arm/mach-s3c64xx/dev-audio.c:81: warning: (near initialization for
'i2sv3_pdata')
arch/arm/mach-s3c64xx/dev-audio.c:144: error: unknown field 'type' specified
in initializer
arch/arm/mach-s3c64xx/dev-audio.c:144: error: extra brace group at end of
initializer
arch/arm/mach-s3c64xx/dev-audio.c:144: error: (near initialization for
'i2sv4_pdata')
arch/arm/mach-s3c64xx/dev-audio.c:145: error: extra brace group at end of
initializer
arch/arm/mach-s3c64xx/dev-audio.c:145: error: (near initialization for
'i2sv4_pdata')
arch/arm/mach-s3c64xx/dev-audio.c:146: error: 'QUIRK_PRI_6CHAN' undeclared
here (not in a function)
arch/arm/mach-s3c64xx/dev-audio.c:149: warning: excess elements in struct
initializer
arch/arm/mach-s3c64xx/dev-audio.c:149: warning: (near initialization for
'i2sv4_pdata')
arch/arm/mach-s3c64xx/dev-audio.c:151: error: expected expression before
'struct'
arch/arm/mach-s3c64xx/dev-audio.c:151: warning: excess elements in struct
initializer
arch/arm/mach-s3c64xx/dev-audio.c:151: warning: (near initialization for
'i2sv4_pdata')
arch/arm/mach-s5p6442/dev-audio.c:52: error: unknown field 'type' specified
in initializer
arch/arm/mach-s5p6442/dev-audio.c:52: error: extra brace group at end of
initializer
arch/arm/mach-s5p6442/dev-audio.c:52: error: (near initialization for
'i2sv35_pdata')
arch/arm/mach-s5p6442/dev-audio.c:53: error: extra brace group at end of
initializer
arch/arm/mach-s5p6442/dev-audio.c:53: error: (near initialization for
'i2sv35_pdata')
arch/arm/mach-s5p6442/dev-audio.c:54: error: 'QUIRK_SEC_DAI' undeclared here
(not in a function)
arch/arm/mach-s5p6442/dev-audio.c:54: error: 'QUIRK_NEED_RSTCLR' undeclared
here (not in a function)
arch/arm/mach-s5p6442/dev-audio.c:57: warning: excess elements in struct
initializer
arch/arm/mach-s5p6442/dev-audio.c:57: warning: (near initialization for
'i2sv35_pdata')
arch/arm/mach-s5p6442/dev-audio.c:100: error: unknown field 'type' specified
in initializer
arch/arm/mach-s5p6442/dev-audio.c:100: error: extra brace group at end of
initializer
arch/arm/mach-s5p6442/dev-audio.c:100: error: (near initialization for
'i2sv3_pdata')
arch/arm/mach-s5p6442/dev-audio.c:101: error: extra brace group at end of
initializer
arch/arm/mach-s5p6442/dev-audio.c:101: error: (near initialization for
'i2sv3_pdata')
arch/arm/mach-s5p6442/dev-audio.c:104: warning: excess elements in struct
initializer
arch/arm/mach-s5p6442/dev-audio.c:104: warning: (near initialization for
'i2sv3_pdata')
arch/arm/mach-s5p64x0/dev-audio.c:45: error: unknown field 'type' specified
in initializer
arch/arm/mach-s5p64x0/dev-audio.c:45: error: extra brace group at end of
initializer
arch/arm/mach-s5p64x0/dev-audio.c:45: error: (near initialization for
's5p64x0_i2s_pdata')
arch/arm/mach-s5p64x0/dev-audio.c:46: error: extra brace group at end of
initializer
arch/arm/mach-s5p64x0/dev-audio.c:46: error: (near initialization for
's5p64x0_i2s_pdata')
arch/arm/mach-s5p64x0/dev-audio.c:47: error: 'QUIRK_PRI_6CHAN' undeclared
here (not in a function)
arch/arm/mach-s5p64x0/dev-audio.c:50: warning: excess elements in struct
initializer
arch/arm/mach-s5p64x0/dev-audio.c:50: warning: (near initialization for
's5p64x0_i2s_pdata')
arch/arm/mach-s5pc100/dev-audio.c:49: error: unknown field 'type' specified
in initializer
arch/arm/mach-s5pc100/dev-audio.c:49: error: extra brace group at end of
initializer
arch/arm/mach-s5pc100/dev-audio.c:49: error: (near initialization for
'i2sv5_pdata')
arch/arm/mach-s5pc100/dev-audio.c:50: error: extra brace group at end of
initializer
arch/arm/mach-s5pc100/dev-audio.c:50: error: (near initialization for
'i2sv5_pdata')
arch/arm/mach-s5pc100/dev-audio.c:51: error: 'QUIRK_PRI_6CHAN' undeclared
here (not in a function)
arch/arm/mach-s5pc100/dev-audio.c:51: error: 'QUIRK_SEC_DAI' undeclared here
(not in a function)
arch/arm/mach-s5pc100/dev-audio.c:52: error: 'QUIRK_NEED_RSTCLR' undeclared
here (not in a function)
arch/arm/mach-s5pc100/dev-audio.c:55: warning: excess elements in struct
initializer
arch/arm/mach-s5pc100/dev-audio.c:55: warning: (near initialization for
'i2sv5_pdata')
arch/arm/mach-s5pc100/dev-audio.c:98: error: unknown field 'type' specified
in initializer
arch/arm/mach-s5pc100/dev-audio.c:98: error: extra brace group at end of
initializer
arch/arm/mach-s5pc100/dev-audio.c:98: error: (near initialization for
'i2sv3_pdata')
arch/arm/mach-s5pc100/dev-audio.c:99: error: extra brace group at end of
initializer
arch/arm/mach-s5pc100/dev-audio.c:99: error: (near initialization for
'i2sv3_pdata')
arch/arm/mach-s5pc100/dev-audio.c:102: warning: excess elements in struct
initializer
arch/arm/mach-s5pc100/dev-audio.c:102: warning: (near initialization for
'i2sv3_pdata')
arch/arm/mach-s5pv210/dev-audio.c:50: error: unknown field 'type' specified
in initializer
arch/arm/mach-s5pv210/dev-audio.c:50: error: extra brace group at end of
initializer
arch/arm/mach-s5pv210/dev-audio.c:50: error: (near initialization for
'i2sv5_pdata')
arch/arm/mach-s5pv210/dev-audio.c:51: error: extra brace group at end of
initializer
arch/arm/mach-s5pv210/dev-audio.c:51: error: (near initialization for
'i2sv5_pdata')
arch/arm/mach-s5pv210/dev-audio.c:52: error: 'QUIRK_PRI_6CHAN' undeclared
here (not in a function)
arch/arm/mach-s5pv210/dev-audio.c:52: error: 'QUIRK_SEC_DAI' undeclared here
(not in a function)
arch/arm/mach-s5pv210/dev-audio.c:53: error: 'QUIRK_NEED_RSTCLR' undeclared
here (not in a function)
arch/arm/mach-s5pv210/dev-audio.c:56: warning: excess elements in struct
initializer
arch/arm/mach-s5pv210/dev-audio.c:56: warning: (near initialization for
'i2sv5_pdata')
arch/arm/mach-s5pv210/dev-audio.c:99: error: unknown field 'type' specified
in initializer
arch/arm/mach-s5pv210/dev-audio.c:99: error: extra brace group at end of
initializer
arch/arm/mach-s5pv210/dev-audio.c:99: error: (near initialization for
'i2sv3_pdata')
arch/arm/mach-s5pv210/dev-audio.c:100: error: extra brace group at end of
initializer
arch/arm/mach-s5pv210/dev-audio.c:100: error: (near initialization for
'i2sv3_pdata')
arch/arm/mach-s5pv210/dev-audio.c:103: warning: excess elements in struct
initializer
arch/arm/mach-s5pv210/dev-audio.c:103: warning: (near initialization for
'i2sv3_pdata')
Unfortunately, not yet cleaned after applying to change plat/audio.h...
arch/arm/mach-s3c64xx/dev-audio.c:151: error: expected expression before
'struct'
arch/arm/mach-s3c64xx/dev-audio.c:151: warning: excess elements in struct
initializer
arch/arm/mach-s3c64xx/dev-audio.c:151: warning: (near initialization for
'i2sv4_pdata')
-> missing brace :-(
arch/arm/mach-s5pv210/dev-audio.c:52: error: unknown field 'quriks'
specified in initializer
-> typo?...quirks...
Please add plat/audio.h patch and update them.
> Since v1:
> a) Use case 16 in set_bfs and default for error
> b) Better code comments.
> c) Use switch case in i2sv2_i2s_set_clkdiv
> d) Use SNDRV_PCM_RATE_8000_96000
> e) MAX_I2S -> SAMSUNG_I2S_SECOFF
> f) Local namespace cleanup with i2s driver.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
next prev parent reply other threads:[~2010-10-22 14:08 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-22 8:30 [PATCHv2] ASoC: Overhaul Samsung drivers Jassi Brar
2010-10-22 8:31 ` [PATCH 01/24] ASoC: Samsung: Remove redundant AQUILA driver Jassi Brar
2010-10-22 8:32 ` [PATCH 02/24] ASoC: Samsung: Rename DMA device Jassi Brar
2010-10-22 8:34 ` [PATCH 03/24] ARM: Samsung: Define common audio-dma device Jassi Brar
2010-10-22 8:34 ` [PATCH 04/24] ASoC: Samsung: Rename ASoC DMA driver Jassi Brar
2010-10-22 8:34 ` [PATCH 05/24] ASoC: Samsung: Rename AC97 platform device Jassi Brar
2010-10-22 8:35 ` [PATCH 06/24] ASoC: Samsung: Rename AC97 driver Jassi Brar
2010-10-22 8:35 ` [PATCH 07/24] ASoC: Samsung: Rename PCM driver Jassi Brar
2010-10-22 8:35 ` [PATCH 08/24] ASoC: Samsung: Generalize DMA driver namespace Jassi Brar
2010-10-22 8:35 ` [PATCH 09/24] ASoC: Samsung: Rename s3c64xx I2S device Jassi Brar
2010-10-22 8:35 ` [PATCH 10/24] ASoC: Samsung: Add common I2S driver Jassi Brar
2010-10-22 8:36 ` [PATCH 11/24] ARM: S3C64XX: I2S: Upgrade platform device Jassi Brar
2010-10-22 8:36 ` [PATCH 12/24] ARM: S5P64X0: " Jassi Brar
2010-10-22 8:36 ` [PATCH 13/24] ARM: S5P6442: " Jassi Brar
2010-10-22 8:37 ` [PATCH 14/24] ARM: S5PC100: " Jassi Brar
2010-10-22 8:37 ` [PATCH 15/24] ARM: S5PV210: " Jassi Brar
2010-10-22 8:37 ` [PATCH 16/24] ARM: S5PV310: Add audio platform devices Jassi Brar
2010-10-22 8:38 ` [PATCH 17/24] ASoC: SMARTQ: Move to use new I2S driver Jassi Brar
2010-10-22 8:39 ` [PATCH 18/24] ASoC: GONI: " Jassi Brar
2010-10-22 8:39 ` [PATCH 19/24] ASoC: SMDK64XX: " Jassi Brar
2010-10-22 8:39 ` [PATCH 20/24] ASoC: S3C64XX: Remove obsoleted I2S drivers Jassi Brar
2010-10-22 8:39 ` [PATCH 21/24] ASoC: SMDK64XX: Rename for other platforms Jassi Brar
2010-10-22 8:40 ` [PATCH 22/24] ASoC: SMDK_WM8580: Enable for SMDKC100 Jassi Brar
2010-10-22 8:40 ` [PATCH 23/24] ASoC: Samsung: Generalize Kconfig symbols Jassi Brar
2010-10-23 1:43 ` Kyungmin Park
2010-10-22 8:40 ` [PATCH 24/24] ASoC: Samsung: Rename from s3c24xx to samsung Jassi Brar
2010-10-23 1:39 ` Kyungmin Park
2010-10-22 14:08 ` Kukjin Kim [this message]
2010-10-25 2:17 ` [PATCHv2] ASoC: Overhaul Samsung drivers Jassi Brar
2010-10-25 2:31 ` Kukjin Kim
2010-10-25 7:20 ` Jassi Brar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='006f01cb71f2$a0136100$e03a2300$%kim@samsung.com' \
--to=kgene.kim@samsung.com \
--cc=alsa-devel@alsa-project.org \
--cc=ben-linux@fluff.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=cw00.choi@samsung.com \
--cc=jassi.brar@samsung.com \
--cc=jassisinghbrar@gmail.com \
--cc=june.bae@samsung.com \
--cc=lrg@slimlogic.co.uk \
--cc=mcuelenaere@gmail.com \
--cc=sw.youn@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox