From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Jaroslav Kysela <perex@perex.cz>,
jack.yu@realtek.com, broonie@kernel.org, lgirdwood@gmail.com
Cc: oder_chiou@realtek.com, alsa-devel@alsa-project.org,
lars@metafoo.de, derek.fang@realtek.com, flove@realtek.com,
shumingf@realtek.com, bard.liao@intel.com
Subject: Re: [PATCH] ASoC: rt715: add main capture switch and main capture volume control
Date: Mon, 14 Dec 2020 09:07:41 -0600 [thread overview]
Message-ID: <0096059b-de76-d9a3-2446-b4c3becabce8@linux.intel.com> (raw)
In-Reply-To: <8eeddc8c-91cb-e62d-6114-547117d4d83e@perex.cz>
On 12/14/20 1:35 AM, Jaroslav Kysela wrote:
> Dne 14. 12. 20 v 7:49 jack.yu@realtek.com napsal(a):
>> From: Jack Yu <jack.yu@realtek.com>
>>
>> Add main capture switch and main capture volume for callback to be in
>> single operation.
>
> Could you be more verbose, what you're trying to do in the patch description?
>
>> + * "Main Capture Volume" looks the same as "ADC 07 Capture Volume",
>
> I would just use "Capture Volume" and "Capture Switch" here without the Main
> prefix to follow other drivers.
It's similar to the 'Master Capture Switch' used in HDaudio, what other
drivers were you referring to?
next prev parent reply other threads:[~2020-12-14 15:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-14 6:49 [PATCH] ASoC: rt715: add main capture switch and main capture volume control jack.yu
2020-12-14 7:35 ` Jaroslav Kysela
2020-12-14 15:07 ` Pierre-Louis Bossart [this message]
2020-12-14 16:44 ` Jaroslav Kysela
2020-12-14 16:58 ` Takashi Iwai
2020-12-14 17:12 ` Pierre-Louis Bossart
2020-12-15 10:39 ` Jaroslav Kysela
2020-12-15 16:00 ` Pierre-Louis Bossart
2020-12-15 16:27 ` Jaroslav Kysela
2020-12-15 17:05 ` Pierre-Louis Bossart
2020-12-15 17:31 ` Jaroslav Kysela
2021-01-05 8:11 ` Jack Yu
2021-01-06 9:39 ` Yang, Libin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0096059b-de76-d9a3-2446-b4c3becabce8@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=bard.liao@intel.com \
--cc=broonie@kernel.org \
--cc=derek.fang@realtek.com \
--cc=flove@realtek.com \
--cc=jack.yu@realtek.com \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=oder_chiou@realtek.com \
--cc=perex@perex.cz \
--cc=shumingf@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox