[PATCH] ALSA: usb-audio: add implicit fb quirk for Behringer UFX1204

[PATCH] ALSA: usb-audio: add implicit fb quirk for Behringer UFX1204

[Lassi Ylikojola]

Add quirk to ensure a sync endpoint is properly configured.
This patch is a fix for same symptoms on Behringer UFX1204 as patch
from Albertto Aquirre on Dec 8 2016 for Axe-Fx II.

Signed-off-by: Lassi Ylikojola <lassi.ylikojola@gmail.com>
---
 sound/usb/pcm.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/sound/usb/pcm.c b/sound/usb/pcm.c
index b9c9a19f9588..2d8b9e19e99b 100644
--- a/sound/usb/pcm.c
+++ b/sound/usb/pcm.c
@@ -352,6 +352,15 @@ static int set_sync_ep_implicit_fb_quirk(struct snd_usb_substream *subs,
                ep = 0x86;
                iface = usb_ifnum_to_if(dev, 2);
 
+               if (!iface || iface->num_altsetting == 0)
+                       return -EINVAL;
+
+               alts = &iface->altsetting[1];
+               goto add_sync_ep;
+       case USB_ID(0x1397, 0x0002): /* Behringer UFX1204 */
+               ep = 0x81;
+               iface = usb_ifnum_to_if(dev, 1);
+
                if (!iface || iface->num_altsetting == 0)
                        return -EINVAL;
 
-- 
2.14.3

Re: [PATCH] ALSA: usb-audio: add implicit fb quirk for Behringer UFX1204

[Takashi Iwai]

On Sat, 03 Feb 2018 15:42:40 +0100,
Lassi Ylikojola wrote:
> 
> Add quirk to ensure a sync endpoint is properly configured.
> This patch is a fix for same symptoms on Behringer UFX1204 as patch
> from Albertto Aquirre on Dec 8 2016 for Axe-Fx II.
> 
> Signed-off-by: Lassi Ylikojola <lassi.ylikojola@gmail.com>

The patch doesn't seem applied cleanly to the latest tree.
Could you check it and repost with the proper patch for the latest
Linus tree?


thanks,

Takashi

Re: [PATCH] ALSA: usb-audio: add implicit fb quirk for Behringer UFX1204

[Lassi Ylikojola]

Add quirk to ensure a sync endpoint is properly configured.
This patch is a fix for same symptoms on Behringer UFX1204 as patch
from Albertto Aquirre on Dec 8 2016 for Axe-Fx II.
Resending. Seems that there is a difference between git diff/commit versions 2.7.4 and 2.14.3.
I had to insert a line break with 2.4.13 to align properly(hopefully). 

Signed-off-by: Lassi Ylikojola <lassi.ylikojola@gmail.com>
---
 sound/usb/pcm.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/sound/usb/pcm.c b/sound/usb/pcm.c
index b9c9a19f9588..116a6ccc5b31 100644
--- a/sound/usb/pcm.c
+++ b/sound/usb/pcm.c
@@ -357,6 +357,16 @@ static int set_sync_ep_implicit_fb_quirk(struct snd_usb_substream *subs,
 
                alts = &iface->altsetting[1];
                goto add_sync_ep;
+       case USB_ID(0x1397, 0x0002):
+               ep = 0x81;
+               iface = usb_ifnum_to_if(dev, 1);
+
+               if (!iface || iface->num_altsetting == 0)
+                       return -EINVAL;
+
+               alts = &iface->altsetting[1];
+               goto add_sync_ep;
+
 
        }
        if (attr == USB_ENDPOINT_SYNC_ASYNC &&
-- 
2.14.3

Re: [PATCH] ALSA: usb-audio: add implicit fb quirk for Behringer UFX1204

[Takashi Iwai]

On Fri, 09 Feb 2018 15:51:36 +0100,
Lassi Ylikojola wrote:
> 
> Add quirk to ensure a sync endpoint is properly configured.
> This patch is a fix for same symptoms on Behringer UFX1204 as patch
> from Albertto Aquirre on Dec 8 2016 for Axe-Fx II.
> Resending. Seems that there is a difference between git diff/commit versions 2.7.4 and 2.14.3.
> I had to insert a line break with 2.4.13 to align properly(hopefully). 

Hrm, still some mess with the embedded patch, but never mind, I fixed
manually and applied to my tree.

But at the next time if you resend a patch, please refresh completely,
not continuing a thread with "Re:" to the subject.  Maybe you can try
git-send-email at the next time.


thanks,

Takashi

> 
> Signed-off-by: Lassi Ylikojola <lassi.ylikojola@gmail.com>
> ---
>  sound/usb/pcm.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/sound/usb/pcm.c b/sound/usb/pcm.c
> index b9c9a19f9588..116a6ccc5b31 100644
> --- a/sound/usb/pcm.c
> +++ b/sound/usb/pcm.c
> @@ -357,6 +357,16 @@ static int set_sync_ep_implicit_fb_quirk(struct snd_usb_substream *subs,
>  
>                 alts = &iface->altsetting[1];
>                 goto add_sync_ep;
> +       case USB_ID(0x1397, 0x0002):
> +               ep = 0x81;
> +               iface = usb_ifnum_to_if(dev, 1);
> +
> +               if (!iface || iface->num_altsetting == 0)
> +                       return -EINVAL;
> +
> +               alts = &iface->altsetting[1];
> +               goto add_sync_ep;
> +
>  
>         }
>         if (attr == USB_ENDPOINT_SYNC_ASYNC &&
> -- 
> 2.14.3
>