* [PATCH 0/2] ASoC: wm8903: Adjustments for wm8903_i2c_probe() @ 2017-11-24 9:51 SF Markus Elfring 2017-11-24 9:53 ` [PATCH 1/2] ASoC: wm8903: Delete an error message for a failed memory allocation in wm8903_i2c_probe() SF Markus Elfring 2017-11-24 9:55 ` [PATCH 2/2] ASoC: wm8903: Improve two size determinations in wm8903_i2c_probe() SF Markus Elfring 0 siblings, 2 replies; 7+ messages in thread From: SF Markus Elfring @ 2017-11-24 9:51 UTC (permalink / raw) To: alsa-devel, patches, Jaroslav Kysela, Liam Girdwood, Linus Walleij, Mark Brown, Takashi Iwai Cc: kernel-janitors, LKML From: Markus Elfring <elfring@users.sourceforge.net> Date: Fri, 24 Nov 2017 10:44:55 +0100 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete an error message for a failed memory allocation Improve two size determinations sound/soc/codecs/wm8903.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) -- 2.15.0 ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/2] ASoC: wm8903: Delete an error message for a failed memory allocation in wm8903_i2c_probe() 2017-11-24 9:51 [PATCH 0/2] ASoC: wm8903: Adjustments for wm8903_i2c_probe() SF Markus Elfring @ 2017-11-24 9:53 ` SF Markus Elfring 2017-11-24 9:57 ` Charles Keepax 2017-11-27 18:54 ` Applied "ASoC: wm8903: Delete an error message for a failed memory allocation in wm8903_i2c_probe()" to the asoc tree Mark Brown 2017-11-24 9:55 ` [PATCH 2/2] ASoC: wm8903: Improve two size determinations in wm8903_i2c_probe() SF Markus Elfring 1 sibling, 2 replies; 7+ messages in thread From: SF Markus Elfring @ 2017-11-24 9:53 UTC (permalink / raw) To: alsa-devel, patches, Jaroslav Kysela, Liam Girdwood, Linus Walleij, Mark Brown, Takashi Iwai Cc: kernel-janitors, LKML From: Markus Elfring <elfring@users.sourceforge.net> Date: Fri, 24 Nov 2017 10:05:43 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> --- sound/soc/codecs/wm8903.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/sound/soc/codecs/wm8903.c b/sound/soc/codecs/wm8903.c index 237eeb9a8b97..51eb7d61d446 100644 --- a/sound/soc/codecs/wm8903.c +++ b/sound/soc/codecs/wm8903.c @@ -2020,10 +2020,8 @@ static int wm8903_i2c_probe(struct i2c_client *i2c, wm8903->pdata = devm_kzalloc(&i2c->dev, sizeof(struct wm8903_platform_data), GFP_KERNEL); - if (wm8903->pdata == NULL) { - dev_err(&i2c->dev, "Failed to allocate pdata\n"); + if (!wm8903->pdata) return -ENOMEM; - } if (i2c->irq) { ret = wm8903_set_pdata_irq_trigger(i2c, wm8903->pdata); -- 2.15.0 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] ASoC: wm8903: Delete an error message for a failed memory allocation in wm8903_i2c_probe() 2017-11-24 9:53 ` [PATCH 1/2] ASoC: wm8903: Delete an error message for a failed memory allocation in wm8903_i2c_probe() SF Markus Elfring @ 2017-11-24 9:57 ` Charles Keepax 2017-11-27 18:54 ` Applied "ASoC: wm8903: Delete an error message for a failed memory allocation in wm8903_i2c_probe()" to the asoc tree Mark Brown 1 sibling, 0 replies; 7+ messages in thread From: Charles Keepax @ 2017-11-24 9:57 UTC (permalink / raw) To: SF Markus Elfring Cc: alsa-devel, patches, Linus Walleij, Takashi Iwai, kernel-janitors, Liam Girdwood, Mark Brown, LKML On Fri, Nov 24, 2017 at 10:53:33AM +0100, SF Markus Elfring wrote: > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Fri, 24 Nov 2017 10:05:43 +0100 > > Omit an extra message for a memory allocation failure in this function. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> > --- Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com> Thanks, Charles ^ permalink raw reply [flat|nested] 7+ messages in thread
* Applied "ASoC: wm8903: Delete an error message for a failed memory allocation in wm8903_i2c_probe()" to the asoc tree 2017-11-24 9:53 ` [PATCH 1/2] ASoC: wm8903: Delete an error message for a failed memory allocation in wm8903_i2c_probe() SF Markus Elfring 2017-11-24 9:57 ` Charles Keepax @ 2017-11-27 18:54 ` Mark Brown 1 sibling, 0 replies; 7+ messages in thread From: Mark Brown @ 2017-11-27 18:54 UTC (permalink / raw) To: Markus Elfring Cc: Charles Keepax, Mark Brown, alsa-devel, patches, Jaroslav Kysela, Liam Girdwood, Linus Walleij The patch ASoC: wm8903: Delete an error message for a failed memory allocation in wm8903_i2c_probe() has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From cce7c0ac44832225ca86afff308cf6a5fb19cf2c Mon Sep 17 00:00:00 2001 From: Markus Elfring <elfring@users.sourceforge.net> Date: Fri, 24 Nov 2017 10:05:43 +0100 Subject: [PATCH] ASoC: wm8903: Delete an error message for a failed memory allocation in wm8903_i2c_probe() Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com> Signed-off-by: Mark Brown <broonie@kernel.org> --- sound/soc/codecs/wm8903.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/sound/soc/codecs/wm8903.c b/sound/soc/codecs/wm8903.c index 237eeb9a8b97..51eb7d61d446 100644 --- a/sound/soc/codecs/wm8903.c +++ b/sound/soc/codecs/wm8903.c @@ -2020,10 +2020,8 @@ static int wm8903_i2c_probe(struct i2c_client *i2c, wm8903->pdata = devm_kzalloc(&i2c->dev, sizeof(struct wm8903_platform_data), GFP_KERNEL); - if (wm8903->pdata == NULL) { - dev_err(&i2c->dev, "Failed to allocate pdata\n"); + if (!wm8903->pdata) return -ENOMEM; - } if (i2c->irq) { ret = wm8903_set_pdata_irq_trigger(i2c, wm8903->pdata); -- 2.15.0 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 2/2] ASoC: wm8903: Improve two size determinations in wm8903_i2c_probe() 2017-11-24 9:51 [PATCH 0/2] ASoC: wm8903: Adjustments for wm8903_i2c_probe() SF Markus Elfring 2017-11-24 9:53 ` [PATCH 1/2] ASoC: wm8903: Delete an error message for a failed memory allocation in wm8903_i2c_probe() SF Markus Elfring @ 2017-11-24 9:55 ` SF Markus Elfring 2017-11-24 10:10 ` Charles Keepax 2017-11-27 18:54 ` Applied "ASoC: wm8903: Improve two size determinations in wm8903_i2c_probe()" to the asoc tree Mark Brown 1 sibling, 2 replies; 7+ messages in thread From: SF Markus Elfring @ 2017-11-24 9:55 UTC (permalink / raw) To: alsa-devel, patches, Jaroslav Kysela, Liam Girdwood, Linus Walleij, Mark Brown, Takashi Iwai Cc: kernel-janitors, LKML From: Markus Elfring <elfring@users.sourceforge.net> Date: Fri, 24 Nov 2017 10:40:43 +0100 Replace the specification of two data structures by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> --- sound/soc/codecs/wm8903.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/sound/soc/codecs/wm8903.c b/sound/soc/codecs/wm8903.c index 51eb7d61d446..cba90f21161f 100644 --- a/sound/soc/codecs/wm8903.c +++ b/sound/soc/codecs/wm8903.c @@ -1995,8 +1995,7 @@ static int wm8903_i2c_probe(struct i2c_client *i2c, unsigned int val, irq_pol; int ret, i; - wm8903 = devm_kzalloc(&i2c->dev, sizeof(struct wm8903_priv), - GFP_KERNEL); + wm8903 = devm_kzalloc(&i2c->dev, sizeof(*wm8903), GFP_KERNEL); if (wm8903 == NULL) return -ENOMEM; @@ -2017,9 +2016,8 @@ static int wm8903_i2c_probe(struct i2c_client *i2c, if (pdata) { wm8903->pdata = pdata; } else { - wm8903->pdata = devm_kzalloc(&i2c->dev, - sizeof(struct wm8903_platform_data), - GFP_KERNEL); + wm8903->pdata = devm_kzalloc(&i2c->dev, sizeof(*wm8903->pdata), + GFP_KERNEL); if (!wm8903->pdata) return -ENOMEM; -- 2.15.0 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] ASoC: wm8903: Improve two size determinations in wm8903_i2c_probe() 2017-11-24 9:55 ` [PATCH 2/2] ASoC: wm8903: Improve two size determinations in wm8903_i2c_probe() SF Markus Elfring @ 2017-11-24 10:10 ` Charles Keepax 2017-11-27 18:54 ` Applied "ASoC: wm8903: Improve two size determinations in wm8903_i2c_probe()" to the asoc tree Mark Brown 1 sibling, 0 replies; 7+ messages in thread From: Charles Keepax @ 2017-11-24 10:10 UTC (permalink / raw) To: SF Markus Elfring Cc: alsa-devel, patches, Linus Walleij, Takashi Iwai, kernel-janitors, Liam Girdwood, Mark Brown, LKML On Fri, Nov 24, 2017 at 10:55:31AM +0100, SF Markus Elfring wrote: > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Fri, 24 Nov 2017 10:40:43 +0100 > > Replace the specification of two data structures by pointer dereferences > as the parameter for the operator "sizeof" to make the corresponding size > determination a bit safer according to the Linux coding style convention. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> > --- Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com> Thanks, Charles ^ permalink raw reply [flat|nested] 7+ messages in thread
* Applied "ASoC: wm8903: Improve two size determinations in wm8903_i2c_probe()" to the asoc tree 2017-11-24 9:55 ` [PATCH 2/2] ASoC: wm8903: Improve two size determinations in wm8903_i2c_probe() SF Markus Elfring 2017-11-24 10:10 ` Charles Keepax @ 2017-11-27 18:54 ` Mark Brown 1 sibling, 0 replies; 7+ messages in thread From: Mark Brown @ 2017-11-27 18:54 UTC (permalink / raw) To: Markus Elfring Cc: Charles Keepax, Mark Brown, alsa-devel, patches, Jaroslav Kysela, Liam Girdwood, Linus Walleij The patch ASoC: wm8903: Improve two size determinations in wm8903_i2c_probe() has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From 017b9b35cb107c0aeaad2ad770460c49e3f71395 Mon Sep 17 00:00:00 2001 From: Markus Elfring <elfring@users.sourceforge.net> Date: Fri, 24 Nov 2017 10:40:43 +0100 Subject: [PATCH] ASoC: wm8903: Improve two size determinations in wm8903_i2c_probe() Replace the specification of two data structures by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com> Signed-off-by: Mark Brown <broonie@kernel.org> --- sound/soc/codecs/wm8903.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/sound/soc/codecs/wm8903.c b/sound/soc/codecs/wm8903.c index 51eb7d61d446..cba90f21161f 100644 --- a/sound/soc/codecs/wm8903.c +++ b/sound/soc/codecs/wm8903.c @@ -1995,8 +1995,7 @@ static int wm8903_i2c_probe(struct i2c_client *i2c, unsigned int val, irq_pol; int ret, i; - wm8903 = devm_kzalloc(&i2c->dev, sizeof(struct wm8903_priv), - GFP_KERNEL); + wm8903 = devm_kzalloc(&i2c->dev, sizeof(*wm8903), GFP_KERNEL); if (wm8903 == NULL) return -ENOMEM; @@ -2017,9 +2016,8 @@ static int wm8903_i2c_probe(struct i2c_client *i2c, if (pdata) { wm8903->pdata = pdata; } else { - wm8903->pdata = devm_kzalloc(&i2c->dev, - sizeof(struct wm8903_platform_data), - GFP_KERNEL); + wm8903->pdata = devm_kzalloc(&i2c->dev, sizeof(*wm8903->pdata), + GFP_KERNEL); if (!wm8903->pdata) return -ENOMEM; -- 2.15.0 ^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-11-27 18:54 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2017-11-24 9:51 [PATCH 0/2] ASoC: wm8903: Adjustments for wm8903_i2c_probe() SF Markus Elfring 2017-11-24 9:53 ` [PATCH 1/2] ASoC: wm8903: Delete an error message for a failed memory allocation in wm8903_i2c_probe() SF Markus Elfring 2017-11-24 9:57 ` Charles Keepax 2017-11-27 18:54 ` Applied "ASoC: wm8903: Delete an error message for a failed memory allocation in wm8903_i2c_probe()" to the asoc tree Mark Brown 2017-11-24 9:55 ` [PATCH 2/2] ASoC: wm8903: Improve two size determinations in wm8903_i2c_probe() SF Markus Elfring 2017-11-24 10:10 ` Charles Keepax 2017-11-27 18:54 ` Applied "ASoC: wm8903: Improve two size determinations in wm8903_i2c_probe()" to the asoc tree Mark Brown
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).