From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 81966C43334 for ; Thu, 16 Jun 2022 06:30:51 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 67E6E1AD7; Thu, 16 Jun 2022 08:29:59 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 67E6E1AD7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1655361049; bh=wif9O5KgkHB6xEW3qKmsm9ZXlJa2XQra7Oa5kcrBsGA=; h=Date:Subject:To:References:From:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=nlejvdu6vn8I2EO/pjXYumuGOHkMBM6Eq4cLz2NXCUIGmgwWa15drimKuAIzKeVxJ XtnkCiUT3iIAqFSqw3vf1rLYy09qUrJ0x9TmXS/xTzAKdwFYHH25T9v0rOW3iwG9eS MPTjCL4KHcYerTk7+5O07NZqF/859yuN1Ynu7Sgk= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 0E534F8012A; Thu, 16 Jun 2022 08:29:59 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 171CAF80310; Thu, 16 Jun 2022 08:29:53 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 45F02F8012A; Thu, 16 Jun 2022 08:29:42 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 45F02F8012A Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="ibS7oTvi" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1655360987; x=1686896987; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=wif9O5KgkHB6xEW3qKmsm9ZXlJa2XQra7Oa5kcrBsGA=; b=ibS7oTviJWOcxkGlkZ3S+04cgYIUuBQHapdpkR2WqtxOlVnKiqLinWFM MmnQ1y53+dkBRu8Uzd9Y8kWHJGadGB7rFayUxgXRsizImVyLILVNO3j40 Wt9xqA8SfiI4aDCkvWbrWRQMfr1KZnrt94vBZOb+INWR4eLA3FSNxTuUD 7kpw6Y/Ulkz1mhWwhm9gwsx5tutT6hwvcQxbFYZPBHUle+qTDGE+sesGv XUnHkvtTas5h9HAZl5vYHsFER4sPLb1dkS6PQCyWreRF/fodYnABEM9xx Pfhc4zQzc9o0UkyJy/SXlaOqImZw7M96I14JiF++k8azxSso2Rdh4N2BJ Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10379"; a="280212640" X-IronPort-AV: E=Sophos;i="5.91,304,1647327600"; d="scan'208";a="280212640" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jun 2022 23:29:40 -0700 X-IronPort-AV: E=Sophos;i="5.91,304,1647327600"; d="scan'208";a="831426996" Received: from marlonpr-mobl3.ger.corp.intel.com (HELO [10.249.254.228]) ([10.249.254.228]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jun 2022 23:29:36 -0700 Message-ID: <01641154-8cf3-ef29-3bc2-c3c1b31b877c@linux.intel.com> Date: Thu, 16 Jun 2022 09:30:14 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Firefox/91.0 Thunderbird/91.10.0 Subject: Re: [PATCH] ASoC: SOF: ipc4-topology: Fix error code in sof_ipc4_volume_put() Content-Language: en-US To: Dan Carpenter , Pierre-Louis Bossart , Ranjani Sridharan References: From: =?UTF-8?Q?P=c3=a9ter_Ujfalusi?= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: alsa-devel@alsa-project.org, Kai Vehmanen , Daniel Baluta , kernel-janitors@vger.kernel.org, Takashi Iwai , Liam Girdwood , Mark Brown , Bard Liao , Rander Wang , sound-open-firmware@alsa-project.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 16/06/2022 07:31, Dan Carpenter wrote: > The sof_ipc4_volume_put() function returns type bool so returning > -ENOENT means returning true. Return false instead. Good catch, Acked-by: Peter Ujfalusi > Fixes: 955e84fc0b6d ("ASoC: SOF: ipc4-topology: Add control IO ops") > Signed-off-by: Dan Carpenter > --- > sound/soc/sof/ipc4-control.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/sof/ipc4-control.c b/sound/soc/sof/ipc4-control.c > index 95ee121dd3cf..0d5a578c3496 100644 > --- a/sound/soc/sof/ipc4-control.c > +++ b/sound/soc/sof/ipc4-control.c > @@ -142,7 +142,7 @@ static bool sof_ipc4_volume_put(struct snd_sof_control *scontrol, > > if (!widget_found) { > dev_err(scomp->dev, "Failed to find widget for kcontrol %s\n", scontrol->name); > - return -ENOENT; > + return false; > } > > ret = sof_ipc4_set_volume_data(sdev, swidget, scontrol); -- Péter