From: Astrid Rost <astridr@axis.com>
To: Mark Brown <broonie@kernel.org>, Astrid Rost <astrid.rost@axis.com>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
kernel@axis.com,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Subject: Re: [PATCH v3 2/3] ASoC: simple-card-utils: create jack inputs for aux_devs
Date: Mon, 30 Jan 2023 10:39:18 +0100 [thread overview]
Message-ID: <0177c346-d969-f8d2-6a31-e3ce570c8251@axis.com> (raw)
In-Reply-To: <Y9PBZjkW7Nrsg4j9@sirena.org.uk>
On 1/27/23 13:19, Mark Brown wrote:
> On Mon, Jan 23, 2023 at 02:59:12PM +0100, Astrid Rost wrote:
>> Add a generic way to create jack inputs for auxiliary jack detection
>> drivers (e.g. via i2c, spi), which are not part of any real codec.
>> The simple-card can be used as combining card driver to add the jacks,
>> no new one is required.
>>
>> Create a jack (for input-events) for jack devices in the auxiliary
>> device list (aux_devs). A device which returns a valid value on
>> get_jack_type counts as jack device; set_jack is required
>> to add the jack to the device.
>>
>> Signed-off-by: Astrid Rost <astrid.rost@axis.com>
>> ---
>> include/sound/simple_card_utils.h | 3 ++
>> sound/soc/generic/simple-card-utils.c | 49 +++++++++++++++++++++++++++
>> sound/soc/generic/simple-card.c | 4 +++
>> 3 files changed, 56 insertions(+)
>
> Given that everyone is really supposed to be using the
> audio-graph cards for new systems this should be hooked up there
> too.
Hello,
Yes auxiliary devices are very useful, e.g. for GPIO. I can make a patch
for audio-graph-card.c to add it.
Best Regards
Astrid
next prev parent reply other threads:[~2023-01-30 9:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-23 13:59 [PATCH v3 0/3] ASoC: simple-card-utils: create jack inputs for aux_devs Astrid Rost
2023-01-23 13:59 ` [PATCH v3 1/3] ASoC: soc-component: add get_jack_type Astrid Rost
2023-01-23 13:59 ` [PATCH v3 2/3] ASoC: simple-card-utils: create jack inputs for aux_devs Astrid Rost
2023-01-27 12:19 ` Mark Brown
2023-01-30 9:39 ` Astrid Rost [this message]
2023-01-23 13:59 ` [PATCH v3 3/3] ASoC: ts3a227e: add set_jack and get_jack_type Astrid Rost
2023-01-28 10:48 ` [PATCH v3 0/3] ASoC: simple-card-utils: create jack inputs for aux_devs Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0177c346-d969-f8d2-6a31-e3ce570c8251@axis.com \
--to=astridr@axis.com \
--cc=alsa-devel@alsa-project.org \
--cc=astrid.rost@axis.com \
--cc=broonie@kernel.org \
--cc=kernel@axis.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox