From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: "Amadeusz Sławiński" <amadeuszx.slawinski@linux.intel.com>,
sathya.prakash.m.r@intel.com
Cc: naveen.m@intel.com, alsa-devel@alsa-project.org, broonie@kernel.org
Subject: Re: [alsa-devel] [PATCH 1/2] ASoC: Intel: boards: Add CML m/c using RT1011 and RT5682
Date: Tue, 24 Sep 2019 08:52:44 -0500 [thread overview]
Message-ID: <01929cf2-6bae-8099-e432-d76286ab0114@linux.intel.com> (raw)
In-Reply-To: <20190924110700.2897cc18@xxx>
>> +static const struct snd_soc_dapm_route cml_rt1011_rt5682_map[] = {
>> + /*speaker*/
>> + {"TL Ext Spk", NULL, "TL SPO"},
>> + {"TR Ext Spk", NULL, "TR SPO"},
>> + {"WL Ext Spk", NULL, "WL SPO"},
>> + {"WR Ext Spk", NULL, "WR SPO"},
>> +
>> + /* HP jack connectors - unknown if we have jack detection */
>> + { "Headphone Jack", NULL, "HPOL" },
>> + { "Headphone Jack", NULL, "HPOR" },
>> +
>> + /* other jacks */
>> + { "IN1P", NULL, "Headset Mic" },
>> +
>> + /* DMIC */
>> + {"DMic", NULL, "SoC DMIC"},
>
> There is some inconsistent spacing around the braces.
Indeed, thanks for spotting this. checkpatch did not complain in the
previous reviews.
>> + for (i = 0; i < rtd->num_codecs; i++) {
>> + codec_dai = rtd->codec_dais[i];
>
> This looks like candidate for for_each_rtd_codec_dai macro
Good suggestion.
Sathya P, can you update this patch and send a v2? Thanks!
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2019-09-24 13:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-24 8:09 [alsa-devel] [PATCH 0/2] Add CML M/C for RT5682 and RT1011 sathya.prakash.m.r
2019-09-24 8:09 ` [alsa-devel] [PATCH 1/2] ASoC: Intel: boards: Add CML m/c using RT1011 and RT5682 sathya.prakash.m.r
2019-09-24 9:07 ` Amadeusz Sławiński
2019-09-24 13:52 ` Pierre-Louis Bossart [this message]
2019-09-24 10:03 ` Kai Vehmanen
2019-09-24 8:09 ` [alsa-devel] [PATCH 2/2] ASoC: Intel: Add acpi match for rt1011 based m/c driver sathya.prakash.m.r
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01929cf2-6bae-8099-e432-d76286ab0114@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=amadeuszx.slawinski@linux.intel.com \
--cc=broonie@kernel.org \
--cc=naveen.m@intel.com \
--cc=sathya.prakash.m.r@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox