From: "Padmanabhan Rajanbabu" <p.rajanbabu@samsung.com>
To: "'Krzysztof Kozlowski'" <krzysztof.kozlowski@linaro.org>,
<lgirdwood@gmail.com>, <broonie@kernel.org>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>, <s.nawrocki@samsung.com>,
<perex@perex.cz>, <tiwai@suse.com>, <pankaj.dubey@samsung.com>,
<alim.akhtar@samsung.com>, <rcsekar@samsung.com>,
<aswani.reddy@samsung.com>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: RE: [PATCH 5/6] arm64: dts: fsd: Add I2S DAI node for Tesla FSD
Date: Tue, 8 Nov 2022 10:56:38 +0530 [thread overview]
Message-ID: <01c001d8f332$af038ef0$0d0aacd0$@samsung.com> (raw)
In-Reply-To: <22272f56-ba55-5725-2dc9-8012e5903eeb@linaro.org>
> -----Original Message-----
> From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@linaro.org]
> Sent: 21 October 2022 06:32 PM
> To: Padmanabhan Rajanbabu <p.rajanbabu@samsung.com>;
> lgirdwood@gmail.com; broonie@kernel.org; robh+dt@kernel.org;
> krzysztof.kozlowski+dt@linaro.org; s.nawrocki@samsung.com;
> perex@perex.cz; tiwai@suse.com; pankaj.dubey@samsung.com;
> alim.akhtar@samsung.com; rcsekar@samsung.com;
> aswani.reddy@samsung.com
> Cc: alsa-devel@alsa-project.org; devicetree@vger.kernel.org; linux-
> kernel@vger.kernel.org; linux-samsung-soc@vger.kernel.org
> Subject: Re: [PATCH 5/6] arm64: dts: fsd: Add I2S DAI node for Tesla FSD
>
> On 21/10/2022 04:49, Padmanabhan Rajanbabu wrote:
> >>>
> >>> cpus {
> >>> @@ -809,6 +811,42 @@
> >>> status = "disabled";
> >>> };
> >>>
> >>> + tdm_0: tdm@140e0000 {
> >>
> >> Node names should be generic, so this looks like i2s.
> >> https://protect2.fireeye.com/v1/url?k=2cfaa5af-4d874de8-2cfb2ee0-
> >> 74fe485fff30-cb16acc0c0c574e9&q=1&e=fc8e3b54-a0ef-475e-a4f2-
> >> 83626a86ac8a&u=https%3A%2F%2Fdevicetree-
> >> specification.readthedocs.io%2Fen%2Flatest%2Fchapter2-devicetree-
> >> basics.html%23generic-names-recommendation
> >
> > Thank you for the link. I could only find audio-controller in the list
> > and not i2s. so I believe I can use audio-controller node name. Please
> > correct me otherwise.
>
> All I2S controllers use node name "i2s", so if this is I2S, then use "i2s".
Okay, I'll ensure the next version will use "i2s" node name
>
>
> Best regards,
> Krzysztof
next prev parent reply other threads:[~2022-11-08 6:20 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20221014104843epcas5p47f6daaad2e67e0c9eedd68c2256c025b@epcas5p4.samsung.com>
2022-10-14 10:21 ` [PATCH 0/6] ASoC: samsung: fsd: audio support for FSD SoC Padmanabhan Rajanbabu
2022-10-14 10:21 ` [PATCH 1/6] ASoC: samsung: i2s: TDM Support for CPU DAI driver Padmanabhan Rajanbabu
2022-10-14 10:21 ` [PATCH 2/6] ASoC: samsung: i2s: configure PSR from sound card Padmanabhan Rajanbabu
2022-10-14 12:02 ` Mark Brown
2022-10-21 8:00 ` Padmanabhan Rajanbabu
2022-10-21 11:53 ` Mark Brown
2022-11-08 5:23 ` Padmanabhan Rajanbabu
2022-11-09 17:38 ` Mark Brown
2023-01-03 4:55 ` Padmanabhan Rajanbabu
2022-10-23 13:12 ` Krzysztof Kozlowski
2022-10-14 10:21 ` [PATCH 3/6] dt-bindings: sound: Add sound card bindings for Tesla FSD Padmanabhan Rajanbabu
2022-10-14 15:13 ` Rob Herring
2022-10-21 8:44 ` Padmanabhan Rajanbabu
2022-10-22 16:48 ` Krzysztof Kozlowski
2022-11-08 5:33 ` Padmanabhan Rajanbabu
2022-11-08 10:36 ` Krzysztof Kozlowski
2022-10-14 10:21 ` [PATCH 4/6] ASoC: samsung: fsd: Add FSD soundcard driver Padmanabhan Rajanbabu
2022-10-14 12:23 ` Mark Brown
2022-10-21 8:09 ` Padmanabhan Rajanbabu
2022-10-16 15:18 ` Krzysztof Kozlowski
2022-10-21 9:04 ` Padmanabhan Rajanbabu
2022-10-14 10:21 ` [PATCH 5/6] arm64: dts: fsd: Add I2S DAI node for Tesla FSD Padmanabhan Rajanbabu
2022-10-14 13:24 ` Alim Akhtar
2022-10-21 8:09 ` Padmanabhan Rajanbabu
2022-10-16 15:14 ` Krzysztof Kozlowski
2022-10-21 8:49 ` Padmanabhan Rajanbabu
2022-10-21 13:01 ` Krzysztof Kozlowski
2022-11-08 5:26 ` Padmanabhan Rajanbabu [this message]
2022-10-14 10:21 ` [PATCH 6/6] arm64: dts: fsd: Add sound card " Padmanabhan Rajanbabu
2022-10-14 13:29 ` Alim Akhtar
2022-10-21 8:12 ` Padmanabhan Rajanbabu
2022-10-21 12:53 ` Krzysztof Kozlowski
2022-11-08 5:25 ` Padmanabhan Rajanbabu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='01c001d8f332$af038ef0$0d0aacd0$@samsung.com' \
--to=p.rajanbabu@samsung.com \
--cc=alim.akhtar@samsung.com \
--cc=alsa-devel@alsa-project.org \
--cc=aswani.reddy@samsung.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=pankaj.dubey@samsung.com \
--cc=perex@perex.cz \
--cc=rcsekar@samsung.com \
--cc=robh+dt@kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox