* [PATCH] ASoC: Fix idma build after update for channel count check
@ 2012-01-09 6:53 Mark Brown
2012-01-09 7:07 ` Joachim Eastwood
0 siblings, 1 reply; 3+ messages in thread
From: Mark Brown @ 2012-01-09 6:53 UTC (permalink / raw)
To: Joachim Eastwood, Liam Girdwood; +Cc: alsa-devel, Mark Brown
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
sound/soc/samsung/idma.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/sound/soc/samsung/idma.c b/sound/soc/samsung/idma.c
index 3ba6aba..c227c31 100644
--- a/sound/soc/samsung/idma.c
+++ b/sound/soc/samsung/idma.c
@@ -398,6 +398,7 @@ static int idma_new(struct snd_soc_pcm_runtime *rtd)
if (pcm->streams[SNDRV_PCM_STREAM_PLAYBACK].substream) {
ret = preallocate_idma_buffer(pcm,
SNDRV_PCM_STREAM_PLAYBACK);
+ }
return ret;
}
--
1.7.7.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: Fix idma build after update for channel count check
2012-01-09 6:53 [PATCH] ASoC: Fix idma build after update for channel count check Mark Brown
@ 2012-01-09 7:07 ` Joachim Eastwood
2012-01-09 7:33 ` Sangbeom Kim
0 siblings, 1 reply; 3+ messages in thread
From: Joachim Eastwood @ 2012-01-09 7:07 UTC (permalink / raw)
To: Mark Brown; +Cc: Joachim Eastwood, alsa-devel, Liam Girdwood
Hi Mark,
On Mon, Jan 9, 2012 at 7:53 AM, Mark Brown
<broonie@opensource.wolfsonmicro.com> wrote:
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
> sound/soc/samsung/idma.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/sound/soc/samsung/idma.c b/sound/soc/samsung/idma.c
> index 3ba6aba..c227c31 100644
> --- a/sound/soc/samsung/idma.c
> +++ b/sound/soc/samsung/idma.c
> @@ -398,6 +398,7 @@ static int idma_new(struct snd_soc_pcm_runtime *rtd)
> if (pcm->streams[SNDRV_PCM_STREAM_PLAYBACK].substream) {
> ret = preallocate_idma_buffer(pcm,
> SNDRV_PCM_STREAM_PLAYBACK);
> + }
>
> return ret;
> }
> --
I accidentally added the brace to the if test in "ASoC: check for
substream not channels_min in pcm engines".
So you either remove the brace from the if test or add another one as you did.
Acked-by: Joachim Eastwood <joachim.eastwood@jotron.com>
regards
Joachim Eastwood
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: Fix idma build after update for channel count check
2012-01-09 7:07 ` Joachim Eastwood
@ 2012-01-09 7:33 ` Sangbeom Kim
0 siblings, 0 replies; 3+ messages in thread
From: Sangbeom Kim @ 2012-01-09 7:33 UTC (permalink / raw)
To: 'Joachim Eastwood', 'Mark Brown'
Cc: 'Joachim Eastwood', alsa-devel, 'Liam Girdwood'
Hi Joachim,
On Mon, Jan 9, 2012 at 4:08 PM, Joachim Eastwood wrote:
> I accidentally added the brace to the if test in "ASoC: check for
> substream not channels_min in pcm engines".
> So you either remove the brace from the if test or add another one as you
> did.
>
> Acked-by: Joachim Eastwood <joachim.eastwood@jotron.com>
>
Thanks for your care to ASoC Samsung code.
If you change ASoC Samsung code, Could you please include me in the CC list?
Acked-by: Sangbeom Kim <sbkim73@samsung.com>
Thanks,
Sangbeom.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-01-09 7:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-09 6:53 [PATCH] ASoC: Fix idma build after update for channel count check Mark Brown
2012-01-09 7:07 ` Joachim Eastwood
2012-01-09 7:33 ` Sangbeom Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).