From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F0D2EC433F5 for ; Thu, 24 Feb 2022 18:06:49 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 5345419FE; Thu, 24 Feb 2022 19:05:57 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 5345419FE DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1645726007; bh=hxBAdTR0owOoMKt0GpG1ZgSex/03IjMwvi0Jz7GXfd8=; h=Date:Subject:To:References:From:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=Xn2FfAvvIeBq2eAd7tqrFuKoEZn/OruOSBHBWjRE/2bqUE2IwOwFR5Ddt2AsOReLB 2WBXHI3PHZq38WePxq16OVthTPFJizCXdz61DE5r7fa5ZGl1vFHFR+J9iMXwp2ydxp NbOQkVnDQJ+8/Mra3pY3XSiVdguzMNwat+vMhkzQ= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id D726FF80169; Thu, 24 Feb 2022 19:05:56 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 10AB9F80118; Thu, 24 Feb 2022 19:05:55 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 46B6FF80118; Thu, 24 Feb 2022 19:05:44 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 46B6FF80118 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="bRHOywwD" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1645725949; x=1677261949; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=hxBAdTR0owOoMKt0GpG1ZgSex/03IjMwvi0Jz7GXfd8=; b=bRHOywwDLe/cDCtZ+tOilpSN/IQpKI3WT9FAAk9xTkycfNG0K+rHNyJQ Qih6VmxRfdf/Y6j7Rgh8/IcHQh/EyBVS81xl1dH2LEAuAL7pbMsnVMGpP aKwfJb6IWvAfeMhvJ5qfWebLPhMys+1GB9svvja+bQ5/09iCGIFiYDWnu iksJ7ifwRQTq38tzYu/jLsZpLqKRI0VOdSOGJTO/kD7GMh6HFjV0m5OE9 1Z0kLDUe/E8kduQ0/0xA10zotg4xc+eSx7UJjclQE7gqA6UfpfyTSj9SV KZz25PbFkNltIP6vUWBrKaKV49bYf+Io4kQPM1JrHhj9E6hp2CMsUgZYL w==; X-IronPort-AV: E=McAfee;i="6200,9189,10268"; a="252039189" X-IronPort-AV: E=Sophos;i="5.90,134,1643702400"; d="scan'208";a="252039189" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Feb 2022 10:05:42 -0800 X-IronPort-AV: E=Sophos;i="5.90,134,1643702400"; d="scan'208";a="533236249" Received: from ronakmeh-mobl1.amr.corp.intel.com (HELO [10.212.97.131]) ([10.212.97.131]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Feb 2022 10:05:40 -0800 Message-ID: <04e79b9c-ccb1-119a-c2e2-34c8ca336215@linux.intel.com> Date: Thu, 24 Feb 2022 12:05:30 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Firefox/91.0 Thunderbird/91.5.0 Subject: Re: [PATCH] ASoC: SOF: Intel: Fix NULL ptr dereference when ENOMEM Content-Language: en-US To: =?UTF-8?Q?P=c3=a9ter_Ujfalusi?= , Ammar Faizi , Mark Brown References: <20220224145124.15985-1-ammarfaizi2@gnuweeb.org> From: Pierre-Louis Bossart In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: alsa-devel@alsa-project.org, Kai Vehmanen , Liam Girdwood , Keyon Jie , Takashi Iwai , stable@vger.kernel.org, linux-kernel@vger.kernel.org, Ranjani Sridharan , Rander Wang , Daniel Baluta , sound-open-firmware@alsa-project.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" >> From: Ammar Faizi >> >> Do not call snd_dma_free_pages() when snd_dma_alloc_pages() returns >> -ENOMEM because it leads to a NULL pointer dereference bug. > > Reviewed-by: Peter Ujfalusi Thanks for this patch. looks good and tested by our CI, so Reviewed-by: Pierre-Louis Bossart