From: "Amadeusz Sławiński" <amadeuszx.slawinski@linux.intel.com>
To: "Rojewski, Cezary" <cezary.rojewski@intel.com>
Cc: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Takashi Iwai <tiwai@suse.com>
Subject: Re: [PATCH v3 0/7] ASoC: topology: Change to resource managed memory
Date: Mon, 2 Nov 2020 12:24:10 +0100 [thread overview]
Message-ID: <05834b5b-a9db-3612-37e9-193b05d56ba0@linux.intel.com> (raw)
In-Reply-To: <3975a572394d4d8ca82778979c5e422f@intel.com>
On 10/30/2020 3:23 PM, Rojewski, Cezary wrote:
> On 2020-10-30 3:54 PM, Amadeusz Sławiński wrote:
>> Almost all other allocations in ASoC API are resource managed, the only
>> exception is soc-topology.c.
>>
>> This patchset clean ups few unnecessary functions in preparation for
>> change and then changes to devm_ functions for allocation.
>>
>
> These address some of the long standing issues of resource allocation
> for topology, thanks for your work.
> Nitpick:
> *the 0/7* looks weird given that only 6 patches are actually part of the
> series.
Yes that was a copy&paste mistake, similarly to already mentioned v3.
There is only 6 patches.
It is a problem caused by manually filling cover letter and copying
title from old cover letter to new one.
I did some reading, and apparently if one operates on branches to
prepare patch sets, they can do something like:
$ git branch --edit-description
$ git format-patch -6 --cover-letter --cover-from-description=subject
And git will automatically populate cover letter with text from branch
description. I will try to remember to try it when sending another
series. Hopefully this will allow me to avoid copy&paste mistakes, as
filling cover letter title and description will be automated ;)
Mark, do let me know if you want me to resend.
>
> For the series:
>
> Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com>
>
> Thanks,
> Czarek
>
>> Amadeusz Sławiński (6):
>> ASoC: topology: Remove unused functions from topology API
>> ASoC: topology: Remove multistep topology loading
>> ASoC: topology: Unify all device references
>> ASoC: topology: Change allocations to resource managed
>> ASoC: topology: Remove empty functions
>> ASoC: topology: Simplify remove_widget function
>>
>> include/sound/soc-topology.h | 13 +-
>> sound/soc/intel/skylake/skl-topology.c | 9 +-
>> sound/soc/soc-topology.c | 302 +++++--------------------
>> sound/soc/sof/pcm.c | 2 +-
>> sound/soc/sof/topology.c | 4 +-
>> 5 files changed, 57 insertions(+), 273 deletions(-)
>>
next prev parent reply other threads:[~2020-11-02 11:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-30 14:54 [PATCH v3 0/7] ASoC: topology: Change to resource managed memory Amadeusz Sławiński
2020-10-30 12:43 ` Amadeusz Sławiński
2020-10-30 14:23 ` Rojewski, Cezary
2020-11-02 11:24 ` Amadeusz Sławiński [this message]
2020-10-30 14:54 ` [PATCH 1/6] ASoC: topology: Remove unused functions from topology API Amadeusz Sławiński
2020-10-30 14:54 ` [PATCH 2/6] ASoC: topology: Remove multistep topology loading Amadeusz Sławiński
2020-10-30 14:54 ` [PATCH 3/6] ASoC: topology: Unify all device references Amadeusz Sławiński
2020-10-30 14:54 ` [PATCH 4/6] ASoC: topology: Change allocations to resource managed Amadeusz Sławiński
2020-10-30 14:54 ` [PATCH 5/6] ASoC: topology: Remove empty functions Amadeusz Sławiński
2020-10-30 14:54 ` [PATCH 6/6] ASoC: topology: Simplify remove_widget function Amadeusz Sławiński
2020-11-04 20:43 ` [PATCH v3 0/7] ASoC: topology: Change to resource managed memory Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=05834b5b-a9db-3612-37e9-193b05d56ba0@linux.intel.com \
--to=amadeuszx.slawinski@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=lgirdwood@gmail.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).