From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0A24C00A89 for ; Mon, 2 Nov 2020 11:25:18 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4F5D52084C for ; Mon, 2 Nov 2020 11:25:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="taiC8Xwt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4F5D52084C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 6247316F1; Mon, 2 Nov 2020 12:24:25 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 6247316F1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1604316315; bh=/dc6reLVdb4BHUpYxYqcuNgfbqa6l3GxYYJ9AEDZ25o=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=taiC8XwtpaKO7gzJz37vUdV4T/Z8kL4CQPjX4Xm9r4IMELL1wSbJzhiEWOzRa/XRF U/0JHlQovEY+NBoTs51dKVTspUaPtUBU6nLAqtp3gYRMudKMvuFnDCDhKKosoFMhP4 G6dAm0ls9zELBoDqM8GNrI+Z3izpmymptPthmR1I= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id B6322F80229; Mon, 2 Nov 2020 12:24:24 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 7A3AAF80232; Mon, 2 Nov 2020 12:24:23 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 66D4AF8015A for ; Mon, 2 Nov 2020 12:24:18 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 66D4AF8015A IronPort-SDR: mtQfXc+Lb2o4LoCfZeNOFWDP+ol/Gos0sZIhBT8QVbMCbEWCPabDabMwrAJd2U3oehzgqqmO2D vFXXGnakUPiw== X-IronPort-AV: E=McAfee;i="6000,8403,9792"; a="168085162" X-IronPort-AV: E=Sophos;i="5.77,444,1596524400"; d="scan'208";a="168085162" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Nov 2020 03:24:15 -0800 IronPort-SDR: Ozni2Ml57Ai0WWrlKQlCgTmECTdQzzDiF7ucz/EF1B/ENBArFsSWwIWX5yZlAxx6ekeeOtWw9y 5MOgjeoW3TwQ== X-IronPort-AV: E=Sophos;i="5.77,444,1596524400"; d="scan'208";a="470341544" Received: from aslawinx-mobl.ger.corp.intel.com (HELO [10.249.130.135]) ([10.249.130.135]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Nov 2020 03:24:13 -0800 Subject: Re: [PATCH v3 0/7] ASoC: topology: Change to resource managed memory To: "Rojewski, Cezary" References: <20201030145427.3497990-1-amadeuszx.slawinski@linux.intel.com> <3975a572394d4d8ca82778979c5e422f@intel.com> From: =?UTF-8?Q?Amadeusz_S=c5=82awi=c5=84ski?= Message-ID: <05834b5b-a9db-3612-37e9-193b05d56ba0@linux.intel.com> Date: Mon, 2 Nov 2020 12:24:10 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <3975a572394d4d8ca82778979c5e422f@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Cc: Pierre-Louis Bossart , "alsa-devel@alsa-project.org" , Mark Brown , Liam Girdwood , Takashi Iwai X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 10/30/2020 3:23 PM, Rojewski, Cezary wrote: > On 2020-10-30 3:54 PM, Amadeusz Sławiński wrote: >> Almost all other allocations in ASoC API are resource managed, the only >> exception is soc-topology.c. >> >> This patchset clean ups few unnecessary functions in preparation for >> change and then changes to devm_ functions for allocation. >> > > These address some of the long standing issues of resource allocation > for topology, thanks for your work. > Nitpick: > *the 0/7* looks weird given that only 6 patches are actually part of the > series. Yes that was a copy&paste mistake, similarly to already mentioned v3. There is only 6 patches. It is a problem caused by manually filling cover letter and copying title from old cover letter to new one. I did some reading, and apparently if one operates on branches to prepare patch sets, they can do something like: $ git branch --edit-description $ git format-patch -6 --cover-letter --cover-from-description=subject And git will automatically populate cover letter with text from branch description. I will try to remember to try it when sending another series. Hopefully this will allow me to avoid copy&paste mistakes, as filling cover letter title and description will be automated ;) Mark, do let me know if you want me to resend. > > For the series: > > Reviewed-by: Cezary Rojewski > > Thanks, > Czarek > >> Amadeusz Sławiński (6): >> ASoC: topology: Remove unused functions from topology API >> ASoC: topology: Remove multistep topology loading >> ASoC: topology: Unify all device references >> ASoC: topology: Change allocations to resource managed >> ASoC: topology: Remove empty functions >> ASoC: topology: Simplify remove_widget function >> >> include/sound/soc-topology.h | 13 +- >> sound/soc/intel/skylake/skl-topology.c | 9 +- >> sound/soc/soc-topology.c | 302 +++++-------------------- >> sound/soc/sof/pcm.c | 2 +- >> sound/soc/sof/topology.c | 4 +- >> 5 files changed, 57 insertions(+), 273 deletions(-) >>