From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Mark Brown <broonie@kernel.org>
Cc: Banajit Goswami <bgoswami@codeaurora.org>,
alsa-devel@alsa-project.org, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>, Patrick Lai <plai@codeaurora.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 3/6] ASoC: codecs: msm8916-wcd-analog: move codec reset to probe
Date: Fri, 28 Jul 2017 15:06:43 +0100 [thread overview]
Message-ID: <064a5aa7-0a87-7e7b-f263-c24cf66f459a@linaro.org> (raw)
In-Reply-To: <20170728134013.vsneppa35kra77ot@sirena.org.uk>
On 28/07/17 14:40, Mark Brown wrote:
> On Wed, Jul 26, 2017 at 02:35:09AM +0200, srinivas.kandagatla@linaro.org wrote:
>> From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
>>
>> This patch move the codec reset code from dai ops to codec probe, so
>> that the codec is not held in reset when headset detection block is
>> still active.
>
> This means that the CODEC will no longer be held in reset (which
> presumably has a power benefit or something) even if jack detection
> isn't in use. What most devices do is have things like this be
> controlled via the bias level or other power management functions and
> then have jack detection hold the CODEC out of the lowest power states
> when it's active.
This chip has two power sources for MBHC logic, one from mic bias which
is used when we have active audio usecase, and other from internal
current source which is for low-power state when no audio use case is
active.
By default with the existing code uses internal current source which
puts chip in low power state.
>
next prev parent reply other threads:[~2017-07-28 14:06 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-26 0:35 [PATCH v1 0/6] ASoC: codecs: msm8916-wcd-analog: Add support to MBHC srinivas.kandagatla
2017-07-26 0:35 ` [PATCH v1 1/6] ASoC: jack: fix snd_soc_codec_set_jack return error srinivas.kandagatla
2017-08-08 11:06 ` Applied "ASoC: jack: fix snd_soc_codec_set_jack return error" to the asoc tree Mark Brown
2017-07-26 0:35 ` [PATCH v1 2/6] ASoC: codecs: msm8916-analog: fix DIG_CLK_CTL_RXD3_CLK_EN define srinivas.kandagatla
2017-07-28 13:36 ` Mark Brown
2017-07-26 0:35 ` [PATCH v1 3/6] ASoC: codecs: msm8916-wcd-analog: move codec reset to probe srinivas.kandagatla
2017-07-28 13:40 ` Mark Brown
2017-07-28 14:06 ` Srinivas Kandagatla [this message]
2017-08-10 15:42 ` Applied "ASoC: codecs: msm8916-wcd-analog: move codec reset to probe" to the asoc tree Mark Brown
2017-07-26 0:35 ` [PATCH v1 4/6] ASoC: codecs: msm8916-wcd-analog: set default micbias voltage to 1.8 srinivas.kandagatla
2017-07-28 13:40 ` Mark Brown
2017-07-28 13:54 ` Srinivas Kandagatla
2017-07-28 14:01 ` Mark Brown
2017-07-28 14:45 ` Srinivas Kandagatla
2017-07-31 10:07 ` Mark Brown
2017-07-31 10:27 ` Srinivas Kandagatla
2017-07-26 0:35 ` [PATCH v1 5/6] ASoC: codecs: msm8916-wcd-analog: add MBHC support srinivas.kandagatla
2017-07-28 13:51 ` Mark Brown
2017-07-28 14:12 ` Srinivas Kandagatla
2017-07-26 0:35 ` [PATCH v1 6/6] ASoC: qcom: apq8016-sbc: Add support to Headset JACK srinivas.kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=064a5aa7-0a87-7e7b-f263-c24cf66f459a@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@codeaurora.org \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=plai@codeaurora.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).