From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pierre-Louis Bossart Subject: Re: [RFC 03/10] ASoC: Intel: Skylake: add HDA BE DAIs Date: Fri, 1 Dec 2017 12:20:10 -0600 Message-ID: <092167b4-2659-cc58-4e7a-00bb3d28068b@linux.intel.com> References: <1512119648-2700-1-git-send-email-rakesh.a.ughreja@intel.com> <1512119648-2700-4-git-send-email-rakesh.a.ughreja@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by alsa0.perex.cz (Postfix) with ESMTP id 68881267044 for ; Fri, 1 Dec 2017 19:20:19 +0100 (CET) In-Reply-To: <1512119648-2700-4-git-send-email-rakesh.a.ughreja@intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Rakesh Ughreja , alsa-devel@alsa-project.org, broonie@kernel.org, tiwai@suse.de, liam.r.girdwood@linux.intel.com Cc: vinod.koul@intel.com, patches.audio@intel.com List-Id: alsa-devel@alsa-project.org On 12/1/17 3:14 AM, Rakesh Ughreja wrote: > Add support for HDA BE DAIs in SKL platform driver. > > Signed-off-by: Rakesh Ughreja > --- > sound/soc/intel/skylake/skl-pcm.c | 32 +++++++++++++++++++++++++------- > 1 file changed, 25 insertions(+), 7 deletions(-) > > diff --git a/sound/soc/intel/skylake/skl-pcm.c b/sound/soc/intel/skylake/skl-pcm.c > index e6fee7a..3dcb241 100644 > --- a/sound/soc/intel/skylake/skl-pcm.c > +++ b/sound/soc/intel/skylake/skl-pcm.c > @@ -956,21 +956,39 @@ static struct snd_soc_dai_driver skl_platform_dai[] = { > }, > }, > { > - .name = "HD-Codec Pin", > + .name = "Analog CPU DAI", > .ops = &skl_link_dai_ops, > .playback = { > - .stream_name = "HD-Codec Tx", > - .channels_min = HDA_STEREO, > + .stream_name = "Analog CPU Playback", > + .channels_min = HDA_MONO, > .channels_max = HDA_STEREO, > .rates = SNDRV_PCM_RATE_48000, > - .formats = SNDRV_PCM_FMTBIT_S16_LE, > + .formats = SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S24_LE, > }, > .capture = { > - .stream_name = "HD-Codec Rx", > - .channels_min = HDA_STEREO, > + .stream_name = "Analog CPU Capture", > + .channels_min = HDA_MONO, > .channels_max = HDA_STEREO, > .rates = SNDRV_PCM_RATE_48000, > - .formats = SNDRV_PCM_FMTBIT_S16_LE, > + .formats = SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S24_LE, > + }, > +}, > +{ > + .name = "Digital CPU DAI", I am not sure I get the meaning of analog/digital. Did you mean external codec vs. iDisp codec? Or did you really mean analog? I don't think you can control this front the CPU side, e.g. if the codec has an S/PDIF output it remains digital. > + .ops = &skl_link_dai_ops, > + .playback = { > + .stream_name = "Digital CPU Playback", > + .channels_min = HDA_MONO, > + .channels_max = HDA_STEREO, > + .rates = SNDRV_PCM_RATE_48000, > + .formats = SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S24_LE, > + }, > + .capture = { > + .stream_name = "Digital CPU Capture", > + .channels_min = HDA_MONO, > + .channels_max = HDA_STEREO, > + .rates = SNDRV_PCM_RATE_48000, > + .formats = SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S24_LE, > }, > }, > }; >