alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Shaokun Zhang <zhangshaokun@hisilicon.com>, alsa-devel@alsa-project.org
Cc: Vinod Koul <vkoul@kernel.org>,
	Bard Liao <yung-chuan.liao@linux.intel.com>,
	Sanyog Kale <sanyog.r.kale@intel.com>
Subject: Re: [PATCH] soundwire: cadence: remove the repeated declaration
Date: Thu, 27 May 2021 07:59:20 -0500	[thread overview]
Message-ID: <09fe3ded-41fa-7826-1307-56ab258804a5@linux.intel.com> (raw)
In-Reply-To: <1622114698-7943-1-git-send-email-zhangshaokun@hisilicon.com>



On 5/27/21 6:24 AM, Shaokun Zhang wrote:
> Function 'cdns_reset_page_addr' is declared twice, so remove the
> repeated declaration.

Indeed, it's been that way since 2018. Thanks for noticing this.

Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>

> 
> Cc: Vinod Koul <vkoul@kernel.org>
> Cc: Bard Liao <yung-chuan.liao@linux.intel.com>
> Cc: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> Cc: Sanyog Kale <sanyog.r.kale@intel.com>
> Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com>
> ---
>   drivers/soundwire/cadence_master.h | 3 ---
>   1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/soundwire/cadence_master.h b/drivers/soundwire/cadence_master.h
> index 4d1aab5b5ec2..0e7f8b35bb21 100644
> --- a/drivers/soundwire/cadence_master.h
> +++ b/drivers/soundwire/cadence_master.h
> @@ -180,9 +180,6 @@ enum sdw_command_response
>   cdns_xfer_msg_defer(struct sdw_bus *bus,
>   		    struct sdw_msg *msg, struct sdw_defer *defer);
>   
> -enum sdw_command_response
> -cdns_reset_page_addr(struct sdw_bus *bus, unsigned int dev_num);
> -
>   int cdns_bus_conf(struct sdw_bus *bus, struct sdw_bus_params *params);
>   
>   int cdns_set_sdw_stream(struct snd_soc_dai *dai,
> 

  reply	other threads:[~2021-05-27 16:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-27 11:24 [PATCH] soundwire: cadence: remove the repeated declaration Shaokun Zhang
2021-05-27 12:59 ` Pierre-Louis Bossart [this message]
2021-05-31 10:04 ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=09fe3ded-41fa-7826-1307-56ab258804a5@linux.intel.com \
    --to=pierre-louis.bossart@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=sanyog.r.kale@intel.com \
    --cc=vkoul@kernel.org \
    --cc=yung-chuan.liao@linux.intel.com \
    --cc=zhangshaokun@hisilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).