From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00,DATE_IN_PAST_03_06, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDAA6C4708A for ; Thu, 27 May 2021 16:12:44 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7BF3E6128B for ; Thu, 27 May 2021 16:12:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7BF3E6128B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id E91F016FA; Thu, 27 May 2021 18:11:50 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz E91F016FA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1622131961; bh=tgf5Ve3EqF67ohKMVuZIgs4XS4/EiFvf1fTdrcZ6VUU=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=MVkF0z23GpR1bx5aHMy0g5y4GKDzsTTQ4UPkQiZCycQ6+XfrMrG+w6vOcLJhw+my0 ZFj4Cr9udFu57t9AXCmSoDhMfTpZdjg2XVYLSnrlZiVp2DCeTphG+UQieGcwa1+YUN 1wXWBQG8lYGta9pLBZszHadkRlnmGOe76oHVwucc= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 7A53AF800F9; Thu, 27 May 2021 18:11:50 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 34AAAF80147; Thu, 27 May 2021 18:11:49 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 78774F800F9 for ; Thu, 27 May 2021 18:11:42 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 78774F800F9 IronPort-SDR: oPMn3P8tt13aUkrvKF1eSVVCzhAzV3jMaH5Jn85i4yHf6nFSHo1VRVE8XWAHgQi+JM5iWCgXUN dMk8rOOmSRVA== X-IronPort-AV: E=McAfee;i="6200,9189,9997"; a="202809101" X-IronPort-AV: E=Sophos;i="5.83,227,1616482800"; d="scan'208";a="202809101" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 May 2021 09:09:23 -0700 IronPort-SDR: 6WA9bodRWD4fVm8DUt3Vogp9sz/nkGuh7kGRNhad0xeaBn3lpYfOLuFcl6KMlSiTmKKpgsT+zj MINK5Wp6mSHA== X-IronPort-AV: E=Sophos;i="5.83,227,1616482800"; d="scan'208";a="480650948" Received: from cblare-mobl1.amr.corp.intel.com (HELO [10.212.12.23]) ([10.212.12.23]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 May 2021 09:09:22 -0700 Subject: Re: [PATCH] soundwire: cadence: remove the repeated declaration To: Shaokun Zhang , alsa-devel@alsa-project.org References: <1622114698-7943-1-git-send-email-zhangshaokun@hisilicon.com> From: Pierre-Louis Bossart Message-ID: <09fe3ded-41fa-7826-1307-56ab258804a5@linux.intel.com> Date: Thu, 27 May 2021 07:59:20 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <1622114698-7943-1-git-send-email-zhangshaokun@hisilicon.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Cc: Vinod Koul , Bard Liao , Sanyog Kale X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 5/27/21 6:24 AM, Shaokun Zhang wrote: > Function 'cdns_reset_page_addr' is declared twice, so remove the > repeated declaration. Indeed, it's been that way since 2018. Thanks for noticing this. Reviewed-by: Pierre-Louis Bossart > > Cc: Vinod Koul > Cc: Bard Liao > Cc: Pierre-Louis Bossart > Cc: Sanyog Kale > Signed-off-by: Shaokun Zhang > --- > drivers/soundwire/cadence_master.h | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/soundwire/cadence_master.h b/drivers/soundwire/cadence_master.h > index 4d1aab5b5ec2..0e7f8b35bb21 100644 > --- a/drivers/soundwire/cadence_master.h > +++ b/drivers/soundwire/cadence_master.h > @@ -180,9 +180,6 @@ enum sdw_command_response > cdns_xfer_msg_defer(struct sdw_bus *bus, > struct sdw_msg *msg, struct sdw_defer *defer); > > -enum sdw_command_response > -cdns_reset_page_addr(struct sdw_bus *bus, unsigned int dev_num); > - > int cdns_bus_conf(struct sdw_bus *bus, struct sdw_bus_params *params); > > int cdns_set_sdw_stream(struct snd_soc_dai *dai, >