* [PATCH] soundwire: cadence: remove the repeated declaration
@ 2021-05-27 11:24 Shaokun Zhang
2021-05-27 12:59 ` Pierre-Louis Bossart
2021-05-31 10:04 ` Vinod Koul
0 siblings, 2 replies; 3+ messages in thread
From: Shaokun Zhang @ 2021-05-27 11:24 UTC (permalink / raw)
To: alsa-devel
Cc: Shaokun Zhang, Sanyog Kale, Vinod Koul, Bard Liao,
Pierre-Louis Bossart
Function 'cdns_reset_page_addr' is declared twice, so remove the
repeated declaration.
Cc: Vinod Koul <vkoul@kernel.org>
Cc: Bard Liao <yung-chuan.liao@linux.intel.com>
Cc: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: Sanyog Kale <sanyog.r.kale@intel.com>
Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com>
---
drivers/soundwire/cadence_master.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/soundwire/cadence_master.h b/drivers/soundwire/cadence_master.h
index 4d1aab5b5ec2..0e7f8b35bb21 100644
--- a/drivers/soundwire/cadence_master.h
+++ b/drivers/soundwire/cadence_master.h
@@ -180,9 +180,6 @@ enum sdw_command_response
cdns_xfer_msg_defer(struct sdw_bus *bus,
struct sdw_msg *msg, struct sdw_defer *defer);
-enum sdw_command_response
-cdns_reset_page_addr(struct sdw_bus *bus, unsigned int dev_num);
-
int cdns_bus_conf(struct sdw_bus *bus, struct sdw_bus_params *params);
int cdns_set_sdw_stream(struct snd_soc_dai *dai,
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] soundwire: cadence: remove the repeated declaration
2021-05-27 11:24 [PATCH] soundwire: cadence: remove the repeated declaration Shaokun Zhang
@ 2021-05-27 12:59 ` Pierre-Louis Bossart
2021-05-31 10:04 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Pierre-Louis Bossart @ 2021-05-27 12:59 UTC (permalink / raw)
To: Shaokun Zhang, alsa-devel; +Cc: Vinod Koul, Bard Liao, Sanyog Kale
On 5/27/21 6:24 AM, Shaokun Zhang wrote:
> Function 'cdns_reset_page_addr' is declared twice, so remove the
> repeated declaration.
Indeed, it's been that way since 2018. Thanks for noticing this.
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
>
> Cc: Vinod Koul <vkoul@kernel.org>
> Cc: Bard Liao <yung-chuan.liao@linux.intel.com>
> Cc: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> Cc: Sanyog Kale <sanyog.r.kale@intel.com>
> Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com>
> ---
> drivers/soundwire/cadence_master.h | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/soundwire/cadence_master.h b/drivers/soundwire/cadence_master.h
> index 4d1aab5b5ec2..0e7f8b35bb21 100644
> --- a/drivers/soundwire/cadence_master.h
> +++ b/drivers/soundwire/cadence_master.h
> @@ -180,9 +180,6 @@ enum sdw_command_response
> cdns_xfer_msg_defer(struct sdw_bus *bus,
> struct sdw_msg *msg, struct sdw_defer *defer);
>
> -enum sdw_command_response
> -cdns_reset_page_addr(struct sdw_bus *bus, unsigned int dev_num);
> -
> int cdns_bus_conf(struct sdw_bus *bus, struct sdw_bus_params *params);
>
> int cdns_set_sdw_stream(struct snd_soc_dai *dai,
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] soundwire: cadence: remove the repeated declaration
2021-05-27 11:24 [PATCH] soundwire: cadence: remove the repeated declaration Shaokun Zhang
2021-05-27 12:59 ` Pierre-Louis Bossart
@ 2021-05-31 10:04 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2021-05-31 10:04 UTC (permalink / raw)
To: Shaokun Zhang; +Cc: Sanyog Kale, alsa-devel, Bard Liao, Pierre-Louis Bossart
On 27-05-21, 19:24, Shaokun Zhang wrote:
> Function 'cdns_reset_page_addr' is declared twice, so remove the
> repeated declaration.
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-05-31 10:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-05-27 11:24 [PATCH] soundwire: cadence: remove the repeated declaration Shaokun Zhang
2021-05-27 12:59 ` Pierre-Louis Bossart
2021-05-31 10:04 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).