From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: "Shuming [范書銘]" <shumingf@realtek.com>,
"broonie@kernel.org" <broonie@kernel.org>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"lars@metafoo.de" <lars@metafoo.de>,
"Flove(HsinFu)" <flove@realtek.com>,
"Oder Chiou" <oder_chiou@realtek.com>,
"Jack Yu" <jack.yu@realtek.com>,
"Derek [方德義]" <derek.fang@realtek.com>,
"pierre-louis.bossart@intel.com" <pierre-louis.bossart@intel.com>
Subject: Re: [PATCH v3] ASoC: rt1320: Add RT1320 SDCA vendor-specific driver
Date: Mon, 20 May 2024 09:17:39 -0500 [thread overview]
Message-ID: <0b8bbcf2-2c34-44ba-b493-e81619a89c7b@linux.intel.com> (raw)
In-Reply-To: <b5e030a953eb4401862781bd88395ed6@realtek.com>
On 5/20/24 09:05, Shuming [范書銘] wrote:
>>> +static const struct sdw_device_id rt1320_id[] = {
>>> + SDW_SLAVE_ENTRY_EXT(0x025d, 0x1320, 0x3, 0x0, 0),
>>> + SDW_SLAVE_ENTRY_EXT(0x025d, 0x1320, 0x3, 0x1, 0),
>>> + {},
>>
>> Sorry, not following why one of the two entries in the table is an SDCA class
>> device and the other not - both rely on SDCA controls/entities/functions/etc.
>> That doesn't really align with the notion that VA and VB only differ by their DSP
>> capabilities, so not sure what the 0/1 difference means.
>
> VA/VB will use class id 0 because of the hardware issue.
> VC will fix this and use the class id 1.
ok, a comment would help.
prev parent reply other threads:[~2024-05-20 14:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-20 9:18 [PATCH v3] ASoC: rt1320: Add RT1320 SDCA vendor-specific driver shumingf
2024-05-20 13:19 ` Pierre-Louis Bossart
2024-05-20 14:05 ` Shuming [范書銘]
2024-05-20 14:17 ` Pierre-Louis Bossart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b8bbcf2-2c34-44ba-b493-e81619a89c7b@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=derek.fang@realtek.com \
--cc=flove@realtek.com \
--cc=jack.yu@realtek.com \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=oder_chiou@realtek.com \
--cc=pierre-louis.bossart@intel.com \
--cc=shumingf@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox