Re: [PATCH v2] ALSA: hda: intel-dsp-cfg: Add Chromebook quirk to ADL/RPL

[Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>]

On 8/15/23 13:00, Curtis Malainey wrote:
> On Tue, Aug 15, 2023 at 10:15 AM Brady Norander <bradynorander@gmail.com> wrote:
>>
>> On Tue, Aug 15, 2023 at 09:56:44AM -0700, Curtis Malainey wrote:
>>> On Tue, Aug 15, 2023 at 8:56 AM Pierre-Louis Bossart <
>>> pierre-louis.bossart@linux.intel.com> wrote:
>>>> On 8/15/23 08:52, Brady Norander wrote:
>>>>> AlderLake and RaptorLake Chromebooks currently use the HDA driver by
>>>>> default. Add a quirk to use the SOF driver on these platforms, which is
>>>>> needed for functional internal audio.
>>>>>
>>>>> Signed-off-by: Brady Norander <bradynorander@gmail.com>
>>>>
>>>> Thanks for the patch
>>>>
>>>> Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
>>>>
>>>
>>> Now that I am looking closer at the patch, I am very curious why we are not
>>> hitting the following case and using SOF
>>
>> The DMIC detection looks for DMIC endpoints in the NHLT, but these
>> devices don't have NHLT.
> 
> There would be the brokenness then. Is the DMIC not something that
> shows up in coreboot? Or is it only defined in the topology? If the
> latter we should probably extend this patch farther back to GLK.

You don't need to expose mics in NHLT, the premise has always been that
Chromebooks are assumed to expose 4 mics and userspace w/ UCM takes care
of selecting which mics are actually used on what platform.

Also there's a difference between NHLT (ACPI table) and NHLT blob in
topology used for IPC4. not the same thing.