From: Lars-Peter Clausen <lars@metafoo.de>
To: brain@jikos.cz, broonie@kernel.org, lgirdwood@gmail.com
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH 1/5] ASoC: tas571x: fix missing bias save level
Date: Mon, 3 Oct 2016 21:11:54 +0200 [thread overview]
Message-ID: <0e94e2d2-0cab-d82f-05ac-afd2c4d81253@metafoo.de> (raw)
In-Reply-To: <429a96e7-1eb4-9d30-9b38-ea7d8c95ffd3@jikos.cz>
On 10/03/2016 09:00 PM, Petr Kulhavy wrote:
>
> On 03/10/16 19:09, Lars-Peter Clausen wrote:
>> On 10/03/2016 04:40 PM, Petr Kulhavy wrote:
>>> The tas571x_set_bias_level() was not saving the new bias level to
>>> codec->dapm.bias_level. This had the effect that bias was switching between
>>> standby and off levels and never entered the on level.
>>>
>>> This fix saves the bias level before returning from the function.
>>>
>> This is done by the ASoC core after the function completes, so this should
>> not be necessary.
> Hi Lars,
>
> since what kernel version is it handled by the ASoC core?
> I've been testing it on a 4.1 based iMX kernel and there the bias levels
Since v4.2. This is the commit:
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=fa880775ab0d5a8d540972f7b6800fad1af16b75
next prev parent reply other threads:[~2016-10-03 19:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-03 14:40 [PATCH 0/5] ASoC: tas571x: fix of several issues for TAS5717 Petr Kulhavy
2016-10-03 14:40 ` [PATCH 1/5] ASoC: tas571x: fix missing bias save level Petr Kulhavy
2016-10-03 17:09 ` Lars-Peter Clausen
2016-10-03 19:00 ` Petr Kulhavy
2016-10-03 19:11 ` Lars-Peter Clausen [this message]
2016-10-03 19:13 ` Lars-Peter Clausen
2016-10-03 20:24 ` Petr Kulhavy
2016-10-03 14:40 ` [PATCH 2/5] ASoC: tas571x: extend the t_i2c time to comply with TAS5721 Petr Kulhavy
2016-10-05 15:21 ` Applied "ASoC: tas571x: extend the t_i2c time to comply with TAS5721" to the asoc tree Mark Brown
2016-10-03 14:40 ` [PATCH 3/5] ASoC: tas571x: remove improper PDN signal usage in set_bias_level Petr Kulhavy
2016-10-05 15:21 ` Applied "ASoC: tas571x: remove improper PDN signal usage in set_bias_level" to the asoc tree Mark Brown
2016-10-03 14:40 ` [PATCH 4/5] ASoC: tas571x: wait 50ms after oscillator trim Petr Kulhavy
2016-10-05 15:22 ` Applied "ASoC: tas571x: wait 50ms after oscillator trim" to the asoc tree Mark Brown
2016-10-03 14:40 ` [PATCH 5/5] ASoC: tas571x: move mixer volume controls from TAS5711 to TAS5717 Petr Kulhavy
2016-10-05 15:21 ` Applied "ASoC: tas571x: move mixer volume controls from TAS5711 to TAS5717" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0e94e2d2-0cab-d82f-05ac-afd2c4d81253@metafoo.de \
--to=lars@metafoo.de \
--cc=alsa-devel@alsa-project.org \
--cc=brain@jikos.cz \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).