From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org,
Banajit Goswami <bgoswami@codeaurora.org>,
Patrick Lai <plai@codeaurora.org>,
linux-kernel@vger.kernel.org, Takashi Iwai <tiwai@suse.com>
Subject: Re: [PATCH v1 4/6] ASoC: codecs: msm8916-wcd-analog: set default micbias voltage to 1.8
Date: Fri, 28 Jul 2017 15:45:08 +0100 [thread overview]
Message-ID: <0f96d65a-f7d9-0139-e0c4-49069e717f34@linaro.org> (raw)
In-Reply-To: <20170728140108.ds5x4irfep4ss3lv@sirena.org.uk>
On 28/07/17 15:01, Mark Brown wrote:
> On Fri, Jul 28, 2017 at 02:54:59PM +0100, Srinivas Kandagatla wrote:
>> On 28/07/17 14:40, Mark Brown wrote:
>>> On Wed, Jul 26, 2017 at 02:35:10AM +0200, srinivas.kandagatla@linaro.org wrote:
>>>> From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
>
>>>> This patch sets the default internal micbias voltage to 1.8v. This
>>>> default value is required for mbhc buttons to work. Also adds dt
>>>> bindings to allow the board level file to specify the required default
>>>> micbias value.
>
>>> What was the default previously?
>
>> This was set to 2.7v previously for special headsets which have high
>> impedance.
>
> So obviously this will break existing users. That's not OK.
This would not break any exiting users, as this part is applicable for
only headset detect usecase. I will try to address this in ("PATCH 5/6
ASoC: codecs: msm8916-wcd-analog: add MBHC support") patch.
The default voltage for most common usecase should be set to 1.8v anyway.
next prev parent reply other threads:[~2017-07-28 14:45 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-26 0:35 [PATCH v1 0/6] ASoC: codecs: msm8916-wcd-analog: Add support to MBHC srinivas.kandagatla
2017-07-26 0:35 ` [PATCH v1 1/6] ASoC: jack: fix snd_soc_codec_set_jack return error srinivas.kandagatla
2017-08-08 11:06 ` Applied "ASoC: jack: fix snd_soc_codec_set_jack return error" to the asoc tree Mark Brown
2017-07-26 0:35 ` [PATCH v1 2/6] ASoC: codecs: msm8916-analog: fix DIG_CLK_CTL_RXD3_CLK_EN define srinivas.kandagatla
2017-07-28 13:36 ` Mark Brown
2017-07-26 0:35 ` [PATCH v1 3/6] ASoC: codecs: msm8916-wcd-analog: move codec reset to probe srinivas.kandagatla
2017-07-28 13:40 ` Mark Brown
2017-07-28 14:06 ` Srinivas Kandagatla
2017-08-10 15:42 ` Applied "ASoC: codecs: msm8916-wcd-analog: move codec reset to probe" to the asoc tree Mark Brown
2017-07-26 0:35 ` [PATCH v1 4/6] ASoC: codecs: msm8916-wcd-analog: set default micbias voltage to 1.8 srinivas.kandagatla
2017-07-28 13:40 ` Mark Brown
2017-07-28 13:54 ` Srinivas Kandagatla
2017-07-28 14:01 ` Mark Brown
2017-07-28 14:45 ` Srinivas Kandagatla [this message]
2017-07-31 10:07 ` Mark Brown
2017-07-31 10:27 ` Srinivas Kandagatla
2017-07-26 0:35 ` [PATCH v1 5/6] ASoC: codecs: msm8916-wcd-analog: add MBHC support srinivas.kandagatla
2017-07-28 13:51 ` Mark Brown
2017-07-28 14:12 ` Srinivas Kandagatla
2017-07-26 0:35 ` [PATCH v1 6/6] ASoC: qcom: apq8016-sbc: Add support to Headset JACK srinivas.kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f96d65a-f7d9-0139-e0c4-49069e717f34@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@codeaurora.org \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=plai@codeaurora.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).