From: "Benoît Thébaudeau" <benoit.thebaudeau@advansee.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Fabio Estevam <fabio.estevam@freescale.com>,
alsa-devel@alsa-project.org, Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH] ASoC: tlv320aic3x: Fix mono
Date: Mon, 28 Jan 2013 22:03:40 +0100 (CET) [thread overview]
Message-ID: <1064296906.226931.1359407020092.JavaMail.root@advansee.com> (raw)
In-Reply-To: <20130127025844.GC4650@opensource.wolfsonmicro.com>
On Sunday, January 27, 2013 3:58:47 AM, Mark Brown wrote:
> On Sat, Jan 26, 2013 at 03:17:01PM +0100, Benoît Thébaudeau wrote:
> > On Saturday, January 26, 2013 9:55:14 AM, Mark Brown wrote:
> > I've only tested with I²S (imx-ssi). But for all the available DAI modes,
> > the
> > data sheet gives the encoding for both stereo channels (from p. 21), and
> > nowhere
> > it says that mono is an option for DAI:
>
> I2S isn't really relevant here, it's not possible to clock I2S as a mono
> interface.
>
> > I will retest with DSP modes if you prefer.
>
> Yes, please.
I have now tested all the DAI formats compatible with both imx-ssi and
tlv320aic3x, i.e.:
- I2S | NB_NF | CBM_CFM,
- DSP_A | IB_NF | CBM_CFM,
- DSP_B | IB_NF | CBM_CFM,
- LEFT_J | NB_NF | CBM_CFM.
In all cases, stereo works just fine.
As to mono, setting .channels_min to 2 also always works fine (as expected, but
not interesting here).
For mono with .channels_min = 1 (i.e. without this patch), I have tried with:
1) snd_soc_dai_set_tdm_slot(cpu_dai, 0xffffffc, 0xffffffc, 2, 0);
-> all DAI formats: wrong sample rate for L/R, playing twice too fast
2) snd_soc_dai_set_tdm_slot(cpu_dai, 0xffffffe, 0xffffffe, 1, 0);
-> all DAI formats: nothing on R, wrong sample rate for L, playing twice too
fast, plus loud noise superimposed for LEFT_J
So, I don't see how to avoid this patch.
I will send a reworded update.
Best regards,
Benoît
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2013-01-28 21:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-25 17:19 [PATCH] ASoC: tlv320aic3x: Fix mono Benoît Thébaudeau
2013-01-26 8:55 ` Mark Brown
2013-01-26 14:17 ` Benoît Thébaudeau
2013-01-27 2:58 ` Mark Brown
2013-01-28 21:03 ` Benoît Thébaudeau [this message]
2013-01-29 2:01 ` Mark Brown
2013-01-29 20:40 ` Benoît Thébaudeau
2013-01-30 2:11 ` Mark Brown
2013-01-30 11:17 ` Benoît Thébaudeau
2013-01-29 20:31 ` [PATCH v2] ASoC: tlv320aic3x: Remove mono support Benoît Thébaudeau
2013-01-30 2:15 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1064296906.226931.1359407020092.JavaMail.root@advansee.com \
--to=benoit.thebaudeau@advansee.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=fabio.estevam@freescale.com \
--cc=lgirdwood@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).