alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Liam Girdwood <lg@opensource.wolfsonmicro.com>
To: Nobin Mathew <nobin.mathew@gmail.com>
Cc: tiwai@suse.de, alsa-devel@alsa-project.org
Subject: Re: [ALSA] ALSA Power Management, Drivers behaving	unexpectedly after suspend/resume cycle
Date: Fri, 25 May 2007 13:39:40 +0100	[thread overview]
Message-ID: <1180096780.13652.57.camel@localhost.localdomain> (raw)
In-Reply-To: <8d6898730705250504p442190e6u5bf71fbcd947df38@mail.gmail.com>

On Fri, 2007-05-25 at 17:34 +0530, Nobin Mathew wrote:
> Every ALSA driver is calling these for suspend
> 
> snd_power_change_state(card, SNDRV_CTL_POWER_D3hot);
> snd_pcm_suspend_all(pcm[i]);
> 
> And for resume
> snd_power_change_state(card, SNDRV_CTL_POWER_D0)
> 
> 
> In ALSA ASoC no driver is calling any of this, even not in soc-core.c
> 
> My driver is an ASoC driver and I am also not calling these functions
> 
> Will this cause any Issue?
> 

These should probably be called to inform the upper layers of the PM
state. Can you log a bug for this in ALSA bugzilla.

Fwiw, this _shouldn't_ effect your resume. You should still see calls to
trigger for your DMA / AC97 to re-start transmission of PCM data.

PM was well tested on pxa2xx, although we did find a few applications
were not too happy resuming audio. e.g. mplayer in alsa mode, although
this was about 1 year ago and afaik it's been fixed.

It may be best to debug this using aplay and placing some debug in your
trigger functions to make sure PCM transmission is restarted correctly.

Liam

  reply	other threads:[~2007-05-25 12:39 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-25  5:57 [ALSA] ALSA Power Management, Drivers behaving unexpectedly after suspend/resume cycle Nobin Mathew
2007-05-25  9:09 ` Liam Girdwood
2007-05-25  9:46 ` Takashi Iwai
2007-05-25 12:04   ` Nobin Mathew
2007-05-25 12:39     ` Liam Girdwood [this message]
2007-05-25 12:54       ` Nobin Mathew
2007-05-25 13:19         ` Liam Girdwood
2007-05-25 13:23       ` Takashi Iwai
2007-05-28  9:16         ` Nobin Mathew
2007-05-28 10:15           ` Nobin Mathew
2007-05-28 12:39             ` Nobin Mathew

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1180096780.13652.57.camel@localhost.localdomain \
    --to=lg@opensource.wolfsonmicro.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=nobin.mathew@gmail.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).