From: Ivan Orlov <ivan.orlov0322@gmail.com>
To: Ruan Jinjie <ruanjinjie@huawei.com>, Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>
Subject: Re: [PATCH -next] ALSA: pcmtest: Drop unnecessary error check for debugfs_create_dir
Date: Thu, 17 Aug 2023 12:30:37 +0400 [thread overview]
Message-ID: <1182f6ea-f303-04f3-e19a-b8cb041252e3@gmail.com> (raw)
In-Reply-To: <021dc4f3-f544-237d-489f-2296c574ec62@huawei.com>
On 17.08.2023 11:03, Ruan Jinjie wrote:
> So the error check is necessary!
Yeah, it is. As Takashi already mentioned, debugfs in this case is the
way how the driver communicates with userspace (forwards flags, receives
filling patterns, etc.), so it is vital part of the driver.
>
>>
>> Maybe we should add a dependency on CONFIG_DEBUG_FS in Kconfig?
>
> I think it's ok!
It sounds like a great idea. Ruan, would you like to do this? If not, I
will take it on.
--
Kind regards,
Ivan Orlov
next prev parent reply other threads:[~2023-08-17 10:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-17 6:39 [PATCH -next] ALSA: pcmtest: Drop unnecessary error check for debugfs_create_dir Ruan Jinjie
2023-08-17 6:47 ` Takashi Iwai
2023-08-17 7:03 ` Ruan Jinjie
2023-08-17 8:30 ` Ivan Orlov [this message]
2023-08-17 8:33 ` Ruan Jinjie
2023-08-17 8:40 ` Ivan Orlov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1182f6ea-f303-04f3-e19a-b8cb041252e3@gmail.com \
--to=ivan.orlov0322@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=perex@perex.cz \
--cc=ruanjinjie@huawei.com \
--cc=tiwai@suse.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox