From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 52291EB64DD for ; Fri, 21 Jul 2023 08:59:25 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 9588DE9F; Fri, 21 Jul 2023 10:58:33 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 9588DE9F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1689929963; bh=9ctZmDV13Kh+Hot8/5Y8puENl1/IkM5Fg2XggDWrado=; h=In-Reply-To:References:Subject:From:Cc:To:Date:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=B7B/MaukuWFvVCinPOge+pPjg9226BI2cziQUpnSGQ/0Lw9NtDfWOoi1MnzaeYWra LRX3077N0r9x9TP6gLk1pI3+bYIHLAWKu/mQMye9sexQNd4PH3igL2fzCRuJx+zf+Y KJeYts9rhfwpPu/Vca3C4d9YlpoNSYu6oz4x//2Y= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 571F1F80652; Fri, 21 Jul 2023 10:54:36 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 649D9F80642; Fri, 21 Jul 2023 10:54:35 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id BBA2BF8047D; Fri, 21 Jul 2023 01:20:38 +0200 (CEST) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 45C53F800D2 for ; Fri, 21 Jul 2023 01:20:29 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 45C53F800D2 Authentication-Results: alsa1.perex.cz; dkim=fail reason="signature verification failed" (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=cYbD9BIb Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DD03261CAE; Thu, 20 Jul 2023 23:20:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2C583C433C8; Thu, 20 Jul 2023 23:20:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689895227; bh=9ctZmDV13Kh+Hot8/5Y8puENl1/IkM5Fg2XggDWrado=; h=In-Reply-To:References:Subject:From:Cc:List-Id:To:Date:From; b=cYbD9BIbKe9OOqdwr3dzlL9wR5KaUX5QP2379F7HDHytuvs+1MP54q0Z68hGsKH4B FYWl7tZYiSDpdOLegT+YQZM1yXUy5lwOu+8wosqMqhfiEPancQh0OsMx7gngCZFRkw pJsU0gGmQ3yzb23zLs6tK4Bc3oZ1qfa0PA7RELaz/17Nk344wIVC1tSV56N7uYZFOa nyr5zxSzIMgd63Ws7TvT1S5JL0M5v+l9wHZlr/Q9lh/6EOA+OyejOA9ESm2BbYF40v AD9xlhIEjpsnEl3JoCBTGL1ZDlPD1p+JZWCY79kM1KNfmzIfj3Ot4lKfzjQq+kUXEx 1F+hprA229KgQ== Message-ID: <11dbf88d12051497ba1e3b16c0d39066.sboyd@kernel.org> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20230605-ep93xx-v3-2-3d63a5f1103e@maquefel.me> References: <20230605-ep93xx-v3-0-3d63a5f1103e@maquefel.me> <20230605-ep93xx-v3-2-3d63a5f1103e@maquefel.me> Subject: Re: [PATCH v3 02/42] dt-bindings: clock: Add Cirrus EP93xx From: Stephen Boyd Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-rtc@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-pm@vger.kernel.org, linux-pwm@vger.kernel.org, linux-spi@vger.kernel.org, netdev@vger.kernel.org, dmaengine@vger.kernel.org, linux-mtd@lists.infradead.org, linux-ide@vger.kernel.org, linux-input@vger.kernel.org, alsa-devel@alsa-project.org To: Alessandro Zummo , Alexander Sverdlin , Alexandre Belloni , Andy Shevchenko , Arnd Bergmann , Bartosz Golaszewski , Conor Dooley , Damien Le Moal , Daniel Lezcano , David S. Miller , Dmitry Torokhov , Eric Dumazet , Guenter Roeck , Hartley Sweeten , Jakub Kicinski , Jaroslav Kysela , Kris Bahnsen , Krzysztof Kozlowski , Lennert Buytenhek , Liam Girdwood , Linus Walleij , Lukasz Majewski , Mark Brown , Michael Peters , Michael Turquette , Miquel Raynal , Nikita Shubin , Nikita Shubin via B4 Relay , Olof Johansson , Paolo Abeni , Richard Weinberger , Rob Herring , Russell King , Sebastian Reichel , Sergey Shtylyov , Takashi Iwai , Thierry Reding , Thomas Gleixner , Uwe =?utf-8?q?Kleine-K=C3=B6nig?= , Vignesh Raghavendra , Vinod Koul , Wim Van Sebroeck , soc@kernel.org Date: Thu, 20 Jul 2023 16:20:24 -0700 User-Agent: alot/0.10 X-MailFrom: sboyd@kernel.org X-Mailman-Rule-Hits: max-recipients X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-size; news-moderation; no-subject; digests; suspicious-header Message-ID-Hash: CYNFLNRL4X6262NRKBR3WXKWNEH5ENHO X-Message-ID-Hash: CYNFLNRL4X6262NRKBR3WXKWNEH5ENHO X-Mailman-Approved-At: Fri, 21 Jul 2023 08:54:07 +0000 X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Quoting Nikita Shubin via B4 Relay (2023-07-20 04:29:02) > diff --git a/Documentation/devicetree/bindings/clock/cirrus,ep9301-clk.ya= ml b/Documentation/devicetree/bindings/clock/cirrus,ep9301-clk.yaml > new file mode 100644 > index 000000000000..111e016601fb > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/cirrus,ep9301-clk.yaml > @@ -0,0 +1,46 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/clock/cirrus,ep9301-clk.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Cirrus Logic ep93xx SoC's clock controller > + > +maintainers: > + - Nikita Shubin > + - Alexander Sverdlin > + > +properties: > + compatible: > + oneOf: > + - const: cirrus,ep9301-clk > + - items: > + - enum: > + - cirrus,ep9302-clk > + - cirrus,ep9307-clk > + - cirrus,ep9312-clk > + - cirrus,ep9315-clk > + - const: cirrus,ep9301-clk > + > + "#clock-cells": > + const: 1 > + > + clocks: > + items: > + - description: reference clock > + > +required: > + - compatible > + - "#clock-cells" > + - clocks > + > +additionalProperties: false > + > +examples: > + - | > + clock-controller { > + compatible =3D "cirrus,ep9301-clk"; Is there a reg property? The driver grabs some syscon and then iomaps it, so presumably there is a register range. Is it part of some other hardware block? If so, can you make that device register sub-devices with the auxiliary bus instead of using a syscon?