Re: [PATCH] ASoC: Intel: bytcr_rt5640: Fix HP Pavilion x2 10-p0XX OVCD current threshold

[Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>]

On 2/24/21 4:50 AM, Hans de Goede wrote:
> When I added the quirk for the "HP Pavilion x2 10-p0XX" I copied the
> byt_rt5640_quirk_table[] entry for the HP Pavilion x2 10-k0XX / 10-n0XX
> models since these use almost the same settings.
> 
> While doing this I accidentally also copied and kept the non-standard
> OVCD_TH_1500UA setting used on those models. This too low threshold is
> causing headsets to often be seen as headphones (without a headset-mic)
> and when correctly identified it is causing ghost play/pause
> button-presses to get detected.
> 
> Correct the HP Pavilion x2 10-p0XX quirk to use the default OVCD_TH_2000UA
> setting, fixing these problems.
> 
> Fixes: fbdae7d6d04d ("ASoC: Intel: bytcr_rt5640: Fix HP Pavilion x2 Detachable quirks")
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>

Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>

> ---
>   sound/soc/intel/boards/bytcr_rt5640.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/intel/boards/bytcr_rt5640.c b/sound/soc/intel/boards/bytcr_rt5640.c
> index 24ced8e4a574..1f6a636571c2 100644
> --- a/sound/soc/intel/boards/bytcr_rt5640.c
> +++ b/sound/soc/intel/boards/bytcr_rt5640.c
> @@ -581,7 +581,7 @@ static const struct dmi_system_id byt_rt5640_quirk_table[] = {
>   		},
>   		.driver_data = (void *)(BYT_RT5640_DMIC1_MAP |
>   					BYT_RT5640_JD_SRC_JD1_IN4P |
> -					BYT_RT5640_OVCD_TH_1500UA |
> +					BYT_RT5640_OVCD_TH_2000UA |
>   					BYT_RT5640_OVCD_SF_0P75 |
>   					BYT_RT5640_MCLK_EN),
>   	},
>