Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Joachim Foerster <mls.JOFT@gmx.de>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel <alsa-devel@alsa-project.org>
Subject: [PATCH] [ML403-AC97CR] Remove duplicate snd_card_set_dev().
Date: Sat, 15 Mar 2008 10:43:09 +0100	[thread overview]
Message-ID: <1205574189.14214.10.camel@md40100b.ft> (raw)

Hi Takashi,

I noticed, that there was a change in ml403-ac97cr.c, which introduces a
second call of snd_card_set_dev() in the _probe()-function. The
"original" one is in the snd_ml403_ac97cr_create()-function.

According the other changes, I guess, we want to have it in the
_probe()-function, now (=> following patch)?


From: Joachim Foerster <JOFT@gmx.de>

We want to have snd_card_set_dev() in _probe(), but not a second one in
snd_ml403_ac97cr_create().

Signed-off-by: Joachim Foerster <JOFT@gmx.de>
---
 sound/drivers/ml403-ac97cr.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/sound/drivers/ml403-ac97cr.c b/sound/drivers/ml403-ac97cr.c
index 05a871a..b654007 100644
--- a/sound/drivers/ml403-ac97cr.c
+++ b/sound/drivers/ml403-ac97cr.c
@@ -1191,8 +1191,6 @@ snd_ml403_ac97cr_create(struct snd_card *card, struct platform_device *pfdev,
 		return err;
 	}
 
-	snd_card_set_dev(card, &pfdev->dev);
-
 	*rml403_ac97cr = ml403_ac97cr;
 	return 0;
 }
-- 
1.5.4.3

             reply	other threads:[~2008-03-15  9:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-15  9:43 Joachim Foerster [this message]
2008-03-17  7:42 ` [PATCH] [ML403-AC97CR] Remove duplicate snd_card_set_dev() Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1205574189.14214.10.camel@md40100b.ft \
    --to=mls.joft@gmx.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox