From: Liam Girdwood <lg@opensource.wolfsonmicro.com>
To: "ing. Davide Rizzo" <davide@elpa.it>, Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel <alsa-devel@alsa-project.org>,
Linux-arm <linux-arm-kernel@lists.arm.linux.org.uk>,
ben-linux <ben-linux@fluff.org>
Subject: Re: [PATCH 2.6.25.1] S3C2410 pcm audio broken
Date: Sun, 04 May 2008 15:30:00 +0100 [thread overview]
Message-ID: <1209911400.3923.3.camel@odin> (raw)
In-Reply-To: <481DB2D6.4000304@elpa.it>
On Sun, 2008-05-04 at 14:57 +0200, ing. Davide Rizzo wrote:
> S3C2410 pcm doesn't work.
> s3c2410_dma_request() now returns the channel number and not 0 if OK.
> Davide
> plain text document attachment (s3c24xx-pcm.patch)
> This patch to update to a s3c2410_dma_request return value change
>
> Signed-off-by: Davide Rizzo <davide@elpa.it>
> ================================================================================
> --- linux-2.6.25.1/sound/soc/s3c24xx/s3c24xx-pcm.c 2008-04-17 04:49:44.000000000 +0200
> +++ linux-2.6.25.1.elpa/sound/soc/s3c24xx/s3c24xx-pcm.c 2008-05-04 09:27:46.000000000 +0200
> @@ -171,7 +171,7 @@ static int s3c24xx_pcm_hw_params(struct
> ret = s3c2410_dma_request(prtd->params->channel,
> prtd->params->client, NULL);
>
> - if (ret) {
> + if (ret < 0) {
> DBG(KERN_ERR "failed to get dma channel\n");
> return ret;
> }
> -------------------------------------------------------------------
Acked-by: Liam Girdwood <lg@opensource.wolfsonmicro.com>
parent reply other threads:[~2008-05-04 14:30 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <481DB2D6.4000304@elpa.it>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1209911400.3923.3.camel@odin \
--to=lg@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=ben-linux@fluff.org \
--cc=davide@elpa.it \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox