From: Liam Girdwood <lg@opensource.wolfsonmicro.com>
To: "ing. Davide Rizzo" <davide@elpa.it>, Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel <alsa-devel@alsa-project.org>,
Linux-arm <linux-arm-kernel@lists.arm.linux.org.uk>,
ben-linux <ben-linux@fluff.org>
Subject: Re: [PATCH 2.6.25.1] S3C2410 i2s programming error
Date: Sun, 04 May 2008 15:31:55 +0100 [thread overview]
Message-ID: <1209911515.3923.5.camel@odin> (raw)
In-Reply-To: <481DB377.2050208@elpa.it>
On Sun, 2008-05-04 at 15:00 +0200, ing. Davide Rizzo wrote:
> S3C2410 i2s driver currently manages only i2s protocol (and not left
> justified one) and slave mode.
> With this small patch, other modes are possible.
> Davide
>
>
> plain text document attachment (s3c24xx-i2s.patch)
> This patch to correctly manage codecs in slave mode and left-justified format
>
> Signed-off-by: Davide Rizzo <davide@elpa.it>
> ================================================================================
> --- linux-2.6.25.1/sound/soc/s3c24xx/s3c24xx-i2s.c 2008-04-17 04:49:44.000000000 +0200
> +++ linux-2.6.25.1.elpa/sound/soc/s3c24xx/s3c24xx-i2s.c 2008-05-04 09:23:34.000000000 +0200
> @@ -224,6 +224,7 @@ static int s3c24xx_i2s_set_fmt(struct sn
> iismod |= S3C2410_IISMOD_SLAVE;
> break;
> case SND_SOC_DAIFMT_CBS_CFS:
> + iismod &= ~S3C2410_IISMOD_SLAVE;
> break;
> default:
> return -EINVAL;
> @@ -234,6 +235,7 @@ static int s3c24xx_i2s_set_fmt(struct sn
> iismod |= S3C2410_IISMOD_MSB;
> break;
> case SND_SOC_DAIFMT_I2S:
> + iismod &= ~S3C2410_IISMOD_MSB;
> break;
> default:
> return -EINVAL;
> -------------------------------------------------------------------
Acked-by: Liam Girdwood <lg@opensource.wolfsonmicro.com>
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
parent reply other threads:[~2008-05-04 14:32 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <481DB377.2050208@elpa.it>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1209911515.3923.5.camel@odin \
--to=lg@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=ben-linux@fluff.org \
--cc=davide@elpa.it \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox