From: Liam Girdwood <lg@opensource.wolfsonmicro.com>
To: Philipp Zabel <philipp.zabel@gmail.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH, RFC] ASoC: uda1380 cleanup
Date: Sat, 10 May 2008 14:48:16 +0100 [thread overview]
Message-ID: <1210427296.20475.135.camel@odin> (raw)
In-Reply-To: <1210425903.3876.22.camel@localhost.localdomain>
On Sat, 2008-05-10 at 15:25 +0200, Philipp Zabel wrote:
> This patch mostly consists of (mostly checkpatch) cleanups, removal of
> the custom dbg macro and uda1380_snd_soc_cnew, which doesn't seem to
> be
> needed anymore. I also removed the hardcoded WinCE/magician register
> values from uda1380_pcm_prepare. Still, a number of FIXMEs remain.
>
> Signed-off-by: Philipp Zabel <philipp.zabel@gmail.com>
> ---
> sound/soc/codecs/uda1380.c | 252
> ++++++++++++++++++++++----------------------
> 1 files changed, 128 insertions(+), 124 deletions(-)
Thanks, applied to ASoC git.
Fwiw, the FIXMEs all look relatively minor and have been worked around
in the driver (although I don't have Magician hardware to test this).
Are any of them showstoppers for upstream ?
Liam
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
prev parent reply other threads:[~2008-05-10 13:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-10 13:25 [PATCH, RFC] ASoC: uda1380 cleanup Philipp Zabel
2008-05-10 13:48 ` Liam Girdwood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1210427296.20475.135.camel@odin \
--to=lg@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=philipp.zabel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox