From: Liam Girdwood <lrg@kernel.org>
To: Tony Lindgren <tony@atomide.com>
Cc: Arun KS <arunks@mistralsolutions.com>,
alsa-devel@alsa-project.org,
"linux-omap@vger.kernel.org List" <linux-omap@vger.kernel.org>,
Jarkko Nikula <jarkko.nikula@nokia.com>,
felipe.balbi@nokia.com, troy.kisky@boundarydevices.com
Subject: Re: [alsa-devel] [PATCH 1/5 v2] ASoC Add TLV320AIC23 codec driver
Date: Fri, 03 Oct 2008 10:06:04 +0100 [thread overview]
Message-ID: <1223024764.6814.69.camel@dell-desktop.example.com> (raw)
In-Reply-To: <20081003081856.GC25482@atomide.com>
On Fri, 2008-10-03 at 11:18 +0300, Tony Lindgren wrote:
> Hi,
>
> * Arun KS <arunks@mistralsolutions.com> [081002 12:18]:
> > ASoC codec driver for TLV320AIC23 device
>
> One comment below based on a quick browse.
>
> <snip>
>
> > +static void tlv320aic23_shutdown(struct snd_pcm_substream *substream)
> > +{
> > + struct snd_soc_pcm_runtime *rtd = substream->private_data;
> > + struct snd_soc_device *socdev = rtd->socdev;
> > + struct snd_soc_codec *codec = socdev->codec;
> > +
> > + /* deactivate */
> > + if (!codec->active) {
> > + udelay(50);
> > + tlv320aic23_write(codec, TLV320AIC23_ACTIVE, 0x0);
> > + }
> > +}
> > +
>
> What's the purpose of the udelay() here? Looks like if needed it should
> be after the twl32aic23_write().. Otherwise the problem is probably
> somewhere else.
>
Iirc this was found to reduce pops and clicks on shutdown on another
very similar codec in this family.
Liam
prev parent reply other threads:[~2008-10-03 9:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-02 9:15 [PATCH 1/5 v2] ASoC Add TLV320AIC23 codec driver Arun KS
2008-10-03 8:18 ` Tony Lindgren
2008-10-03 9:06 ` Liam Girdwood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1223024764.6814.69.camel@dell-desktop.example.com \
--to=lrg@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=arunks@mistralsolutions.com \
--cc=felipe.balbi@nokia.com \
--cc=jarkko.nikula@nokia.com \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
--cc=troy.kisky@boundarydevices.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox