From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org,
Mark Brown <broonie@opensource.wolfsonmicro.com>
Subject: [PATCH 4/8] ASoC: Remove DAPM restriction on mixer control name lengths
Date: Thu, 30 Oct 2008 15:58:25 +0000 [thread overview]
Message-ID: <1225382309-1827-4-git-send-email-broonie@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1225382309-1827-3-git-send-email-broonie@opensource.wolfsonmicro.com>
As well as ensuring that UI-relevant parts of control names don't get
truncated in the DAPM code this avoids conflicts in long control names
that differ only at the end of a long string.
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
sound/soc/soc-dapm.c | 11 ++++++++---
1 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c
index b51d822..407092c 100644
--- a/sound/soc/soc-dapm.c
+++ b/sound/soc/soc-dapm.c
@@ -289,7 +289,7 @@ static int dapm_new_mixer(struct snd_soc_codec *codec,
struct snd_soc_dapm_widget *w)
{
int i, ret = 0;
- char name[32];
+ size_t name_len;
struct snd_soc_dapm_path *path;
/* add kcontrol */
@@ -303,11 +303,16 @@ static int dapm_new_mixer(struct snd_soc_codec *codec,
continue;
/* add dapm control with long name */
- snprintf(name, 32, "%s %s", w->name, w->kcontrols[i].name);
- path->long_name = kstrdup (name, GFP_KERNEL);
+ name_len = 2 + strlen(w->name)
+ + strlen(w->kcontrols[i].name);
+ path->long_name = kmalloc(name_len, GFP_KERNEL);
if (path->long_name == NULL)
return -ENOMEM;
+ snprintf(path->long_name, name_len, "%s %s",
+ w->name, w->kcontrols[i].name);
+ path->long_name[name_len - 1] = '\0';
+
path->kcontrol = snd_soc_cnew(&w->kcontrols[i], w,
path->long_name);
ret = snd_ctl_add(codec->card, path->kcontrol);
--
1.5.6.5
next prev parent reply other threads:[~2008-10-30 15:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-30 15:57 [PATCH 0/8] ASoC updates for next Mark Brown
2008-10-30 15:58 ` [PATCH 1/8] ASoC: Allow setting codec register with debugfs filesystem Mark Brown
2008-10-30 15:58 ` [PATCH 2/8] ASoC: Fix handling of DAPM suspend work Mark Brown
2008-10-30 15:58 ` [PATCH 3/8] ASoC: Convert core to use standard debug print macros Mark Brown
2008-10-30 15:58 ` Mark Brown [this message]
2008-10-30 15:58 ` [PATCH 5/8] ASoC: Add PXA SSP support Mark Brown
2008-10-30 15:58 ` [PATCH 6/8] ASoC: Do a warm reset after cold when resetting the WM9713 Mark Brown
2008-10-30 15:58 ` [PATCH 7/8] ASoC: Use finer grained dependencies in SND_SOC_ALL_CODECS Mark Brown
2008-10-30 15:58 ` [PATCH 8/8] ASoC: Disable automatic volume control in the CS4270 sound driver Mark Brown
2008-10-30 16:22 ` [PATCH 0/8] ASoC updates for next Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1225382309-1827-4-git-send-email-broonie@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox