From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Grazvydas Ignotas <notasas@gmail.com>
Subject: [PATCH 4/4] ALSA: ASoC: TWL4030 codec - fix 256*Fs clock
Date: Thu, 6 Nov 2008 11:40:59 +0000 [thread overview]
Message-ID: <1225971659-26887-4-git-send-email-broonie@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1225971659-26887-3-git-send-email-broonie@opensource.wolfsonmicro.com>
From: Grazvydas Ignotas <notasas@gmail.com>
According to TRM, 256*Fs clock output should be enabled
when TWL4030 is in slave mode, not master.
This allows sound to work on OMAP3 Pandora, which uses
256*Fs clock.
Signed-off-by: Grazvydas Ignotas <notasas@gmail.com>
Acked-by: Steve Sakoman <steve@sakoman.com>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
sound/soc/codecs/twl4030.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/codecs/twl4030.c b/sound/soc/codecs/twl4030.c
index ee2f0d3..90f3b4d 100644
--- a/sound/soc/codecs/twl4030.c
+++ b/sound/soc/codecs/twl4030.c
@@ -469,11 +469,11 @@ static int twl4030_set_dai_fmt(struct snd_soc_dai *codec_dai,
switch (fmt & SND_SOC_DAIFMT_MASTER_MASK) {
case SND_SOC_DAIFMT_CBM_CFM:
format &= ~(TWL4030_AIF_SLAVE_EN);
- format |= TWL4030_CLK256FS_EN;
+ format &= ~(TWL4030_CLK256FS_EN);
break;
case SND_SOC_DAIFMT_CBS_CFS:
- format &= ~(TWL4030_CLK256FS_EN);
format |= TWL4030_AIF_SLAVE_EN;
+ format |= TWL4030_CLK256FS_EN;
break;
default:
return -EINVAL;
--
1.5.6.5
next prev parent reply other threads:[~2008-11-06 11:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-06 11:38 [PATCH 0/4] ASoC updates Mark Brown
2008-11-06 11:40 ` [PATCH 1/4] ASoC: Add Palm/PXA27x unified ASoC audio driver Mark Brown
2008-11-06 11:40 ` [PATCH 2/4] ASoC: Remove core version number Mark Brown
2008-11-06 11:40 ` [PATCH 3/4] ASoC: Add new parameter to s3c24xx_pcm_enqueue Mark Brown
2008-11-06 11:40 ` Mark Brown [this message]
2008-11-06 11:57 ` [PATCH 0/4] ASoC updates Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1225971659-26887-4-git-send-email-broonie@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=notasas@gmail.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).