Re: [PATCH 1/3] introduce i830_hdmi_priv.has_hdmi_sink

[Wu Fengguang <wfg@linux.intel.com>]

On Wed, Nov 12, 2008 at 03:27:47PM +0800, Wang, Zhenyu Z wrote:
> On 2008.11.07 14:23:39 +0800, Wu Fengguang wrote:
> > HDMI is compatible with DVI, and we've seen many boards that
> > use HDMI port for DVI output.
> > 
> > So Zhenyu proposed this flag: i830_hdmi_priv.has_hdmi_sink
> > to indicate the presence of HDMI capable monitors.
> > 
> > Signed-off-by: Wu Fengguang <wfg@linux.intel.com>

> We should check if the symbol is available for xserver compatiblity.
> So below is updated patch for check this. 

> +
> +    if (xf86LoaderCheckSymbol("xf86MonitorIsHDMI") &&
> +	    xf86MonitorIsHDMI(edid_mon))
> +	dev_priv->has_hdmi_sink = TRUE;

I'm OK with the backward compatibility check.
The side effect is that audio output won't be enabled for old xservers.

Thanks,
Fengguang