From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org,
Mark Brown <broonie@opensource.wolfsonmicro.com>
Subject: [PATCH 1/8] ASoC: Work around warnings from some build environments
Date: Wed, 10 Dec 2008 20:01:08 +0000 [thread overview]
Message-ID: <1228939275-7768-1-git-send-email-broonie@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20081210195858.GA4062@rakim.wolfsonmicro.main>
BUG() should be marked as not returning but for at least some
configurations (including some widely deployed compilers) that's either
not happening or being forgotten by the compiler. Add some extra return
statements to the affected paths.
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
sound/soc/codecs/wm8903.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/sound/soc/codecs/wm8903.c b/sound/soc/codecs/wm8903.c
index 0b5bea3..b1f5cf7 100644
--- a/sound/soc/codecs/wm8903.c
+++ b/sound/soc/codecs/wm8903.c
@@ -392,6 +392,7 @@ static int wm8903_output_event(struct snd_soc_dapm_widget *w,
break;
default:
BUG();
+ return -EINVAL; /* Spurious warning from some compilers */
}
switch (w->shift) {
@@ -403,6 +404,7 @@ static int wm8903_output_event(struct snd_soc_dapm_widget *w,
break;
default:
BUG();
+ return -EINVAL; /* Spurious warning from some compilers */
}
if (event & SND_SOC_DAPM_PRE_PMU) {
--
1.5.6.5
next prev parent reply other threads:[~2008-12-10 20:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-10 19:58 [PATCH 0/8] ASoC updates Mark Brown
2008-12-10 20:01 ` Mark Brown [this message]
2008-12-10 20:01 ` [PATCH 2/8] ASoC: TWL4030: Add missing Carkit output Mark Brown
2008-12-10 20:01 ` [PATCH 3/8] ASoC: TWL4030: Small cleanup Mark Brown
2008-12-10 20:01 ` [PATCH 4/8] ASoC: TWL4030: Change the name for the DACs Mark Brown
2008-12-10 20:01 ` [PATCH 5/8] ASoC: Add codec registration API Mark Brown
2008-12-10 20:01 ` [PATCH 6/8] ASoC: Convert WM8900 to do more work at I2C probe time Mark Brown
2008-12-10 20:01 ` [PATCH 7/8] ASoC: Convert WM8903 driver to register " Mark Brown
2008-12-10 20:01 ` [PATCH 8/8] ASoC: Stop WM8903 SYSCLK when suspending Mark Brown
2008-12-10 20:34 ` [PATCH 0/8] ASoC updates Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1228939275-7768-1-git-send-email-broonie@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox