From: Shine Liu <shinel@foxmail.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH] pcm_lib.c: Fixed inaccurate calculation of hw_ptr_interrupt in snd_pcm_update_hw_ptr_interrupt function
Date: Wed, 19 Aug 2009 12:48:26 +0000 [thread overview]
Message-ID: <1250686106.2060.16.camel@sl> (raw)
In-Reply-To: <s5h7hx0c8l2.wl%tiwai@suse.de>
On Wed, 2009-08-19 at 14:05 +0200, Takashi Iwai wrote:
> >
> > But the irq last issued should be at 0x3e80, but not 0x3800 + 0x800 =
> > 0x4000. The DMA engine loaded 0x680 frame not 0x800 frame at the last
> > time.
>
> Then it's a driver bug. If unaligned period size is allowed, it means
> that the irq is really generated in that period, not at the buffer
> boundary. Otherwise, it must have a proper hw-constraint to align the
> period size to the buffer size.
>
> What hardware is it?
Yes, but there's no constraint code currently to force to align the
period size to the buffer size. The bug occurs on linux-2.6.31-rc6 on
ASoC s3c24xx platform.
The constraint to force to align the period size to the buffer size
should not be hardware depended, it shoud be done in the generic layer,
is it?
>
>
> thanks,
>
> Takashi
next prev parent reply other threads:[~2009-08-19 12:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-19 10:22 [PATCH] pcm_lib.c: Fixed inaccurate calculation of hw_ptr_interrupt in snd_pcm_update_hw_ptr_interrupt function Shine Liu
2009-08-19 10:34 ` Takashi Iwai
2009-08-19 10:59 ` Shine Liu
2009-08-19 12:05 ` Takashi Iwai
2009-08-19 12:48 ` Shine Liu [this message]
2009-08-19 12:53 ` Takashi Iwai
2009-08-19 13:01 ` Shine Liu
2009-08-20 7:20 ` Shine Liu
2009-08-20 8:42 ` Clemens Ladisch
2009-08-20 15:02 ` [PATCH] ASoC: S3C24XX : Align the peroid size to the buffer size Shine Liu
2009-08-20 18:44 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1250686106.2060.16.camel@sl \
--to=shinel@foxmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox