From: Liam Girdwood <lrg@slimlogic.co.uk>
To: Grazvydas Ignotas <notasas@gmail.com>
Cc: alsa-devel@alsa-project.org,
Mark Brown <broonie@opensource.wolfsonmicro.com>
Subject: Re: [PATCH] ASoC: OMAP3 Pandora: update for TWL4030 codec changes
Date: Sun, 08 Nov 2009 20:31:17 +0000 [thread overview]
Message-ID: <1257712277.15162.3.camel@vega> (raw)
In-Reply-To: <1257628572-6049-1-git-send-email-notasas@gmail.com>
On Sat, 2009-11-07 at 23:16 +0200, Grazvydas Ignotas wrote:
> A while ago TWL4030 had it's playback stream name changed, but
> pandora needs it for it's playback path. Update to correct stream
> name so that playback works again.
>
> Also mark VIBRA output as not connected.
>
> Signed-off-by: Grazvydas Ignotas <notasas@gmail.com>
> ---
> sound/soc/omap/omap3pandora.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/sound/soc/omap/omap3pandora.c b/sound/soc/omap/omap3pandora.c
> index ad219aa..0cd06f5 100644
> --- a/sound/soc/omap/omap3pandora.c
> +++ b/sound/soc/omap/omap3pandora.c
> @@ -134,7 +134,7 @@ static int omap3pandora_hp_event(struct snd_soc_dapm_widget *w,
> * |P| <--- TWL4030 <--------- Line In and MICs
> */
> static const struct snd_soc_dapm_widget omap3pandora_out_dapm_widgets[] = {
> - SND_SOC_DAPM_DAC("PCM DAC", "Playback", SND_SOC_NOPM, 0, 0),
> + SND_SOC_DAPM_DAC("PCM DAC", "HiFi Playback", SND_SOC_NOPM, 0, 0),
> SND_SOC_DAPM_PGA_E("Headphone Amplifier", SND_SOC_NOPM,
> 0, 0, NULL, 0, omap3pandora_hp_event,
> SND_SOC_DAPM_POST_PMU | SND_SOC_DAPM_PRE_PMD),
> @@ -181,6 +181,7 @@ static int omap3pandora_out_init(struct snd_soc_codec *codec)
> snd_soc_dapm_nc_pin(codec, "CARKITR");
> snd_soc_dapm_nc_pin(codec, "HFL");
> snd_soc_dapm_nc_pin(codec, "HFR");
> + snd_soc_dapm_nc_pin(codec, "VIBRA");
>
> ret = snd_soc_dapm_new_controls(codec, omap3pandora_out_dapm_widgets,
> ARRAY_SIZE(omap3pandora_out_dapm_widgets));
Acked-by:Liam Girdwood <lrg@slimlogic.co.uk>
next prev parent reply other threads:[~2009-11-08 20:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-07 21:16 [PATCH] ASoC: OMAP3 Pandora: update for TWL4030 codec changes Grazvydas Ignotas
2009-11-08 20:31 ` Liam Girdwood [this message]
2009-11-18 10:12 ` Grazvydas Ignotas
2009-11-18 10:27 ` Mark Brown
2009-11-18 13:17 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1257712277.15162.3.camel@vega \
--to=lrg@slimlogic.co.uk \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=notasas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox